cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle side effects correctly in rest params index expressions (#4348) (#4674)

Browse Source
This commit is contained in:
Moti Zilberman
2016-10-05 22:59:41 +03:00
committed by Daniel Tschinder
parent 7a7704fea0
commit 0366d1ad19
4 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
packages/babel-plugin-transform-es2015-parameters/src/rest.js
View File

@@ -17,6 +17,10 @@ let restIndex = template(`
ARGUMENTS.length <= INDEX ? undefined : ARGUMENTS[INDEX]
`);
let restIndexImpure = template(`
REF = INDEX, ARGUMENTS.length <= REF ? undefined : ARGUMENTS[REF]
`);
let restLength = template(`
ARGUMENTS.length <= OFFSET ? 0 : ARGUMENTS.length - OFFSET
`);
@@ -161,10 +165,21 @@ function optimiseIndexGetter(path, argsId, offset) {
index = t.binaryExpression("+", path.parent.property, t.numericLiteral(offset));
}
path.parentPath.replaceWith(restIndex({
ARGUMENTS: argsId,
INDEX: index,
}));
const { scope } = path;
if (!scope.isPure(index)) {
let temp = scope.generateUidIdentifierBasedOnNode(index);
scope.push({id: temp, kind: "var"});
path.parentPath.replaceWith(restIndexImpure({
ARGUMENTS: argsId,
INDEX: index,
REF: temp
}));
} else {
path.parentPath.replaceWith(restIndex({
ARGUMENTS: argsId,
INDEX: index,
}));
}
}
function optimiseLengthGetter(path, argsId, offset) {