perf: partially replace .concat with .push (#13609)

This commit is contained in:
Federico Ciardi
2021-08-14 16:57:06 +02:00
committed by GitHub
parent 6a651e4641
commit 10640b2aad
18 changed files with 93 additions and 74 deletions

View File

@@ -10,7 +10,11 @@ function collect(
const values = value.split(",");
return previousValue ? previousValue.concat(values) : values;
if (previousValue) {
previousValue.push(...values);
return previousValue;
}
return values;
}
commander.option(

View File

@@ -192,7 +192,8 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
let filenames = commander.args.reduce(function (globbed, input) {
let files = glob.sync(input);
if (!files.length) files = [input];
return globbed.concat(files);
globbed.push(...files);
return globbed;
}, []);
filenames = Array.from(new Set(filenames));
@@ -353,5 +354,9 @@ function collect(
const values = value.split(",");
return previousValue ? previousValue.concat(values) : values;
if (previousValue) {
previousValue.push(...values);
return previousValue;
}
return values;
}