cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Throw on duplicate __proto__ props followed by assignment (#13951)

Browse Source
This commit is contained in:
Sneh Khatri 2021-11-12 19:15:56 +05:30 committed by GitHub
parent dd63950c99
commit 135ab837bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 176 additions and 79 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/babel-parser/src/parser/expression.js
View File

@ -309,17 +309,18 @@ export default class ExpressionParser extends LValParser {
if (this.match(tt.eq)) {
node.left = this.toAssignable(left, /* isLHS */ true);
if (refExpressionErrors.doubleProto >= startPos) {
refExpressionErrors.doubleProto = -1; // reset because double __proto__ is valid in assignment expression
}
if (refExpressionErrors.shorthandAssign >= startPos) {
refExpressionErrors.shorthandAssign = -1; // reset because shorthand default was used correctly
}
} else {
node.left = left;
}
if (refExpressionErrors.shorthandAssign >= node.left.start) {
refExpressionErrors.shorthandAssign = -1; // reset because shorthand default was used correctly
}
this.checkLVal(left, "assignment expression");
this.next();
node.right = this.parseMaybeAssign();
return this.finishNode(node, "AssignmentExpression");

5
packages/babel-parser/test/fixtures/es2015/duplicate-proto/with-assignment-expression/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
({
__proto__: a,
__proto__: a,
a: a = 1
})

95
packages/babel-parser/test/fixtures/es2015/duplicate-proto/with-assignment-expression/output.json vendored Normal file
View File

@ -0,0 +1,95 @@
{
"type": "File",
"start":0,"end":48,"loc":{"start":{"line":1,"column":0},"end":{"line":5,"column":2}},
"errors": [
"SyntaxError: Redefinition of __proto__ property. (3:2)"
],
"program": {
"type": "Program",
"start":0,"end":48,"loc":{"start":{"line":1,"column":0},"end":{"line":5,"column":2}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start":0,"end":48,"loc":{"start":{"line":1,"column":0},"end":{"line":5,"column":2}},
"expression": {
"type": "ObjectExpression",
"start":1,"end":47,"loc":{"start":{"line":1,"column":1},"end":{"line":5,"column":1}},
"properties": [
{
"type": "ObjectProperty",
"start":5,"end":17,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":14}},
"method": false,
"key": {
"type": "Identifier",
"start":5,"end":14,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":11},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "Identifier",
"start":16,"end":17,"loc":{"start":{"line":2,"column":13},"end":{"line":2,"column":14},"identifierName":"a"},
"name": "a"
}
},
{
"type": "ObjectProperty",
"start":21,"end":33,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":14}},
"method": false,
"key": {
"type": "Identifier",
"start":21,"end":30,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":11},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "Identifier",
"start":32,"end":33,"loc":{"start":{"line":3,"column":13},"end":{"line":3,"column":14},"identifierName":"a"},
"name": "a"
}
},
{
"type": "ObjectProperty",
"start":37,"end":45,"loc":{"start":{"line":4,"column":2},"end":{"line":4,"column":10}},
"method": false,
"key": {
"type": "Identifier",
"start":37,"end":38,"loc":{"start":{"line":4,"column":2},"end":{"line":4,"column":3},"identifierName":"a"},
"name": "a"
},
"computed": false,
"shorthand": false,
"value": {
"type": "AssignmentExpression",
"start":40,"end":45,"loc":{"start":{"line":4,"column":5},"end":{"line":4,"column":10}},
"operator": "=",
"left": {
"type": "Identifier",
"start":40,"end":41,"loc":{"start":{"line":4,"column":5},"end":{"line":4,"column":6},"identifierName":"a"},
"name": "a"
},
"right": {
"type": "NumericLiteral",
"start":44,"end":45,"loc":{"start":{"line":4,"column":9},"end":{"line":4,"column":10}},
"extra": {
"rawValue": 1,
"raw": "1"
},
"value": 1
}
}
}
],
"extra": {
"parenthesized": true,
"parenStart": 0
}
}
}
],
"directives": []
}
}

4
packages/babel-parser/test/fixtures/es2015/duplicate-proto/without-assignment-expression/input.js vendored Normal file
View File

@ -0,0 +1,4 @@
({
__proto__: a,
__proto__: a,
})

65
packages/babel-parser/test/fixtures/es2015/duplicate-proto/without-assignment-expression/output.json vendored Normal file
View File

@ -0,0 +1,65 @@
{
"type": "File",
"start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":2}},
"errors": [
"SyntaxError: Redefinition of __proto__ property. (3:2)"
],
"program": {
"type": "Program",
"start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":2}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start":0,"end":37,"loc":{"start":{"line":1,"column":0},"end":{"line":4,"column":2}},
"expression": {
"type": "ObjectExpression",
"start":1,"end":36,"loc":{"start":{"line":1,"column":1},"end":{"line":4,"column":1}},
"properties": [
{
"type": "ObjectProperty",
"start":5,"end":17,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":14}},
"method": false,
"key": {
"type": "Identifier",
"start":5,"end":14,"loc":{"start":{"line":2,"column":2},"end":{"line":2,"column":11},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "Identifier",
"start":16,"end":17,"loc":{"start":{"line":2,"column":13},"end":{"line":2,"column":14},"identifierName":"a"},
"name": "a"
}
},
{
"type": "ObjectProperty",
"start":21,"end":33,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":14}},
"method": false,
"key": {
"type": "Identifier",
"start":21,"end":30,"loc":{"start":{"line":3,"column":2},"end":{"line":3,"column":11},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "Identifier",
"start":32,"end":33,"loc":{"start":{"line":3,"column":13},"end":{"line":3,"column":14},"identifierName":"a"},
"name": "a"
}
}
],
"extra": {
"trailingComma": 33,
"parenthesized": true,
"parenStart": 0
}
}
}
],
"directives": []
}
}

1
packages/babel-parser/test/fixtures/es2015/uncategorised/348/input.js vendored
View File

@ -1 +0,0 @@
({ __proto__: 1, __proto__: 2 })

72
packages/babel-parser/test/fixtures/es2015/uncategorised/348/output.json vendored
View File

@ -1,72 +0,0 @@
{
"type": "File",
"start":0,"end":32,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":32}},
"errors": [
"SyntaxError: Redefinition of __proto__ property. (1:17)"
],
"program": {
"type": "Program",
"start":0,"end":32,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":32}},
"sourceType": "script",
"interpreter": null,
"body": [
{
"type": "ExpressionStatement",
"start":0,"end":32,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":32}},
"expression": {
"type": "ObjectExpression",
"start":1,"end":31,"loc":{"start":{"line":1,"column":1},"end":{"line":1,"column":31}},
"properties": [
{
"type": "ObjectProperty",
"start":3,"end":15,"loc":{"start":{"line":1,"column":3},"end":{"line":1,"column":15}},
"method": false,
"key": {
"type": "Identifier",
"start":3,"end":12,"loc":{"start":{"line":1,"column":3},"end":{"line":1,"column":12},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "NumericLiteral",
"start":14,"end":15,"loc":{"start":{"line":1,"column":14},"end":{"line":1,"column":15}},
"extra": {
"rawValue": 1,
"raw": "1"
},
"value": 1
}
},
{
"type": "ObjectProperty",
"start":17,"end":29,"loc":{"start":{"line":1,"column":17},"end":{"line":1,"column":29}},
"method": false,
"key": {
"type": "Identifier",
"start":17,"end":26,"loc":{"start":{"line":1,"column":17},"end":{"line":1,"column":26},"identifierName":"__proto__"},
"name": "__proto__"
},
"computed": false,
"shorthand": false,
"value": {
"type": "NumericLiteral",
"start":28,"end":29,"loc":{"start":{"line":1,"column":28},"end":{"line":1,"column":29}},
"extra": {
"rawValue": 2,
"raw": "2"
},
"value": 2
}
}
],
"extra": {
"parenthesized": true,
"parenStart": 0
}
}
}
],
"directives": []
}
}