From 163c68dd6a3d04ad2d10ed19e9ee98b2c0a0c05d Mon Sep 17 00:00:00 2001 From: Sebastian McKenzie Date: Wed, 29 Oct 2014 20:57:43 +1100 Subject: [PATCH] fix lint errors --- .jshintrc | 9 ++++++++- Makefile | 2 +- benchmark/index.js | 16 ++++++++-------- bin/6to5/file.js | 6 +++--- bin/6to5/index.js | 7 +++---- 5 files changed, 23 insertions(+), 17 deletions(-) diff --git a/.jshintrc b/.jshintrc index f01e5db809..84b94e7dd8 100644 --- a/.jshintrc +++ b/.jshintrc @@ -17,5 +17,12 @@ "loopfunc": true, "white": true, "maxparams": 5, - "maxdepth": 4 + "maxdepth": 4, + + "globals": { + "suite": true, + "set": true, + "before": true, + "bench": true + } } diff --git a/Makefile b/Makefile index 9b9c7e2724..1bb6873b93 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,7 @@ bench: node node_modules/matcha/bin/_matcha test: - $(JSHINT_CMD) lib bin benchmark + $(JSHINT_CMD) lib bin benchmark/index.js $(MOCHA_CMD) test-cov: diff --git a/benchmark/index.js b/benchmark/index.js index 0a10350b09..c7d04b1b65 100644 --- a/benchmark/index.js +++ b/benchmark/index.js @@ -7,7 +7,7 @@ var es6now = require("es6now"); var esnext = require("esnext"); var to5 = require("../lib/6to5"); -var uglify = require("uglify-js"); +//var uglify = require("uglify-js"); var matcha = require("matcha"); var path = require("path"); var fs = require("fs"); @@ -48,7 +48,7 @@ var compilers = { traceur: { runtime: readResolve("traceur/bin/traceur-runtime.js"), - compile: function (code, filename) { + compile: function (code) { return traceur.compile(code, { modules: "commonjs", experimental: true @@ -58,20 +58,20 @@ var compilers = { esnext: { runtime: readResolve("esnext/node_modules/regenerator/runtime.js") || readResolve("regenerator/runtime.js"), - compile: function (code, filename) { + compile: function (code) { return esnext.compile(code).code; } }, es6now: { runtime: readResolve("es6now/runtime/ES6.js"), - compile: function (code, filename) { + compile: function (code) { return es6now.translate(code); } }, "es6-transpiler": { - compile: function (code, filename) { + compile: function (code) { var result = es6tr.run({ src: code }); if (result.errors.length) throw new Error(result.join("; ")); return result.src; @@ -79,7 +79,7 @@ var compilers = { }, jstransform: { - compile: function (code, filename) { + compile: function (code) { return jsTrans.transform(jsTransVisitors, code).code; } } @@ -87,7 +87,7 @@ var compilers = { // versions -var uglifyTitle = "uglify v" + getVersion("uglify-js"); +//var uglifyTitle = "uglify v" + getVersion("uglify-js"); _.each(compilers, function (compiler, name) { compiler.title = name + " v" + (compiler.version || getVersion(name)); @@ -159,7 +159,7 @@ _.each(fs.readdirSync(__dirname + "/fixtures"), function (name) { }); }); - _.each(compilers, function (compiler, name) { + _.each(compilers, function (compiler) { bench(compiler.title, function () { compiler.compile(code, loc); }); diff --git a/bin/6to5/file.js b/bin/6to5/file.js index 1afc7587a2..f59eb6d978 100644 --- a/bin/6to5/file.js +++ b/bin/6to5/file.js @@ -6,7 +6,7 @@ var util = require("./util"); var fs = require("fs"); var _ = require("lodash"); -module.exports = function (commander, filenames, opts) { +module.exports = function (commander, filenames) { var results = []; var buildResult = function () { @@ -48,7 +48,7 @@ module.exports = function (commander, filenames, opts) { return { map: map, code: code - } + }; }; var output = function () { @@ -101,7 +101,7 @@ module.exports = function (commander, filenames, opts) { }); _.each(_filenames, function (filename, i) { - results.push(util.compile(filename, { _noStrict: i != 0 })); + results.push(util.compile(filename, { _noStrict: +i !== 0 })); }); output(); diff --git a/bin/6to5/index.js b/bin/6to5/index.js index c4c34515a2..970dd331f2 100755 --- a/bin/6to5/index.js +++ b/bin/6to5/index.js @@ -2,8 +2,7 @@ var commander = require("commander"); var transform = require("../../lib/6to5/transform"); -var util2 = require("../../lib/6to5/util"); -var util = require("./util"); +var util = require("../../lib/6to5/util"); var fs = require("fs"); var _ = require("lodash"); @@ -13,8 +12,8 @@ commander.option("-f, --filename [filename]", "Filename to use when reading from commander.option("-w, --watch", "Recompile files on changes"); commander.option("-m, --modules [modules]", "Module formatter type to use [common]", "common"); -commander.option("-w, --whitelist [whitelist]", "Whitelist of transformers to ONLY use", util2.list); -commander.option("-b, --blacklist [blacklist]", "Blacklist of transformers to NOT use", util2.list); +commander.option("-w, --whitelist [whitelist]", "Whitelist of transformers to ONLY use", util.list); +commander.option("-b, --blacklist [blacklist]", "Blacklist of transformers to NOT use", util.list); commander.option("-o, --out-file [out]", "Compile all input files into a single file"); commander.option("-d, --out-dir [out]", "Compile an input directory of modules into an output directory");