From 182fe7b04e1810d85ad3f8a1824feed8317ffb17 Mon Sep 17 00:00:00 2001 From: Brian Ng Date: Fri, 23 Feb 2018 08:45:22 -0600 Subject: [PATCH] Add missing promise polyfill deps for preset-env's useBuiltIns: usage (#7400) --- .../babel-preset-env/src/built-in-definitions.js | 7 ++++++- .../promise-all/input.js | 4 ++++ .../promise-all/options.json | 14 ++++++++++++++ .../promise-all/output.js | 6 ++++++ .../promise-race/input.js | 4 ++++ .../promise-race/options.json | 14 ++++++++++++++ .../promise-race/output.js | 6 ++++++ 7 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/input.js create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/options.json create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/output.js create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/input.js create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/options.json create mode 100644 packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/output.js diff --git a/packages/babel-preset-env/src/built-in-definitions.js b/packages/babel-preset-env/src/built-in-definitions.js index f4bf559ab3..ec1d73756b 100644 --- a/packages/babel-preset-env/src/built-in-definitions.js +++ b/packages/babel-preset-env/src/built-in-definitions.js @@ -15,7 +15,7 @@ export const definitions = { Set: "es6.set", WeakMap: "es6.weak-map", WeakSet: "es6.weak-set", - Promise: "es6.promise", + Promise: ["es6.object.to-string", "es6.promise"], Symbol: "es6.symbol", }, @@ -114,6 +114,11 @@ export const definitions = { MAX_SAFE_INTEGER: "es6.number.max-safe-integer", }, + Promise: { + all: ["es6.string.iterator", "web.dom.iterable"], + race: ["es6.string.iterator", "web.dom.iterable"], + }, + Reflect: { apply: "es6.reflect.apply", construct: "es6.reflect.construct", diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/input.js b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/input.js new file mode 100644 index 0000000000..0fef928e16 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/input.js @@ -0,0 +1,4 @@ +var p = Promise.resolve(0); +Promise.all([p]).then(outcome => { + alert("OK"); +}); diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/options.json b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/options.json new file mode 100644 index 0000000000..eeb3ed89dd --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/options.json @@ -0,0 +1,14 @@ +{ + "presets": [ + [ + "../../../../lib", + { + "targets": { + "browsers": ["ie > 10"] + }, + "useBuiltIns": "usage", + "modules": false + } + ] + ] +} diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/output.js b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/output.js new file mode 100644 index 0000000000..3c6e6de8aa --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-all/output.js @@ -0,0 +1,6 @@ +import "core-js/modules/web.dom.iterable"; +import "core-js/modules/es6.promise"; +var p = Promise.resolve(0); +Promise.all([p]).then(function (outcome) { + alert("OK"); +}); diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/input.js b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/input.js new file mode 100644 index 0000000000..334252838b --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/input.js @@ -0,0 +1,4 @@ +var p = Promise.resolve(0); +Promise.race([p]).then(outcome => { + alert("OK"); +}); diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/options.json b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/options.json new file mode 100644 index 0000000000..eeb3ed89dd --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/options.json @@ -0,0 +1,14 @@ +{ + "presets": [ + [ + "../../../../lib", + { + "targets": { + "browsers": ["ie > 10"] + }, + "useBuiltIns": "usage", + "modules": false + } + ] + ] +} diff --git a/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/output.js b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/output.js new file mode 100644 index 0000000000..42d9a206b3 --- /dev/null +++ b/packages/babel-preset-env/test/fixtures/preset-options-add-used-built-ins/promise-race/output.js @@ -0,0 +1,6 @@ +import "core-js/modules/web.dom.iterable"; +import "core-js/modules/es6.promise"; +var p = Promise.resolve(0); +Promise.race([p]).then(function (outcome) { + alert("OK"); +});