cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Allow multiple __self/__source props with classic JSX runtime (#12475)

Browse Source
This commit is contained in:
Mateusz Burzyński 2020-12-10 18:17:20 +01:00 committed by GitHub
parent e8176de528
commit 1ef9e196d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/babel-helper-builder-react-jsx-experimental/src/index.js
View File

@ -862,7 +862,6 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
let props = [];
const objs = [];
const found = Object.create(null);
for (const attr of attribs) {
const name =
@ -870,10 +869,8 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
t.isJSXIdentifier(attr.name) &&
attr.name.name;
if (name === "__source" || name === "__self") {
if (found[name]) throw sourceSelfError(path, name);
found[name] = true;
if (!options.development) continue;
if (!options.development && (name === "__source" || name === "__self")) {
continue;
}
if (useSpread || !t.isJSXSpreadAttribute(attr)) {

0
packages/babel-plugin-transform-react-jsx-development/test/fixtures/linux/classic-runtime-with-source-self-plugins/input.js → packages/babel-plugin-transform-react-jsx-development/test/fixtures/linux/.classic-runtime-with-source-self-plugins/input.js vendored
View File

0
packages/babel-plugin-transform-react-jsx-development/test/fixtures/linux/classic-runtime-with-source-self-plugins/options.json → packages/babel-plugin-transform-react-jsx-development/test/fixtures/linux/.classic-runtime-with-source-self-plugins/options.json vendored
View File

0
packages/babel-plugin-transform-react-jsx-development/test/fixtures/windows/classic-runtime-with-source-self-plugins-windows/input.js → packages/babel-plugin-transform-react-jsx-development/test/fixtures/windows/.classic-runtime-with-source-self-plugins-windows/input.js vendored
View File

0
packages/babel-plugin-transform-react-jsx-development/test/fixtures/windows/classic-runtime-with-source-self-plugins-windows/options.json → packages/babel-plugin-transform-react-jsx-development/test/fixtures/windows/.classic-runtime-with-source-self-plugins-windows/options.json vendored
View File

1
packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/input.mjs vendored Normal file
View File

@ -0,0 +1 @@
<div/>

3
packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/my-preset.js vendored Normal file
View File

@ -0,0 +1,3 @@
module.exports = () => ({
presets: [["@babel/preset-react", { development: true }]],
});

4
packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/options.json vendored Normal file
View File

@ -0,0 +1,4 @@
{
"presets": [["@babel/preset-react", { "development": true }], "./my-preset"],
"os": ["linux", "darwin"]
}

18
packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/output.mjs vendored Normal file
View File

@ -0,0 +1,18 @@
var _jsxFileName = "<CWD>/packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/input.mjs",
_jsxFileName2 = "<CWD>/packages/babel-preset-react/test/fixtures/regression/runtime-classic-allow-multiple-source-self/input.mjs";
/*#__PURE__*/
React.createElement("div", {
__self: this,
__source: {
fileName: _jsxFileName,
lineNumber: 1,
columnNumber: 1
},
__self: this,
__source: {
fileName: _jsxFileName2,
lineNumber: 1,
columnNumber: 1
}
});