cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve error message when not providing a value for JSX key (#12983)

Browse Source 
* Improve error message when not providing a value for key

* Update packages/babel-plugin-transform-react-jsx/src/create-plugin.js

Show location of attribute instead of only the path

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>

* Change error message to be less aggressive

* Throw error when runtime is "classic"

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
This commit is contained in:
hajnalbendeguz
2021-03-16 13:02:08 +01:00
committed by GitHub
parent 6e1e00388b
commit 281acd6448
5 changed files with 55 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-plugin-transform-react-jsx/test/fixtures/react-automatic/should-disallow-valueless-key/input.js vendored Normal file
View File

@@ -0,0 +1,2 @@
var x = [<div key></div>];

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react-automatic/should-disallow-valueless-key/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Please provide an explicit key value. Using \"key\" as a shorthand for \"key={true}\" is not allowed."
}

2
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-disallow-valueless-key/input.js vendored Normal file
View File

@@ -0,0 +1,2 @@
var x = [<div key></div>];

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-disallow-valueless-key/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Please provide an explicit key value. Using \"key\" as a shorthand for \"key={true}\" is not allowed."
}