implement new and improved let scoping - fixes #91, fixes #102, fixes #124

test/fixtures/transformation/constants/block-statement/expected.js

@@ -1,6 +1,6 @@
 "use strict";
 
-for (var _i in arr) {
-  var _MULTIPLIER = 5;
-  console.log(arr[_i] * _MULTIPLIER);
-}
+for (var i in arr) {
+  var MULTIPLIER = 5;
+  console.log(arr[i] * MULTIPLIER);
+}

test/fixtures/transformation/constants/destructuring/expected.js

@@ -1,20 +1,20 @@
 "use strict";
 
 var _ref = [1, 2];
-var _a = _ref[0];
-var _b = _ref[1];
+var a = _ref[0];
+var b = _ref[1];
 var _ref2 = [3, 4];
-var _c = _ref2[0];
-var _d = _ref2[1];
+var c = _ref2[0];
+var d = _ref2[1];
 var _ref3 = {
   e: 5,
   f: 6
 };
-var _e = _ref3.e;
-var _f = _ref3.f;
+var e = _ref3.e;
+var f = _ref3.f;
 var _ref4 = {
   a: 7,
   b: 8
 };
-var _g = _ref4.a;
-var _h = _ref4.b;
+var g = _ref4.a;
+var h = _ref4.b;

test/fixtures/transformation/constants/program/expected.js

@@ -1,7 +1,7 @@
 "use strict";
 
-var _MULTIPLIER = 5;
+var MULTIPLIER = 5;
 
 for (var i in arr) {
-  console.log(arr[i] * _MULTIPLIER);
-}
+  console.log(arr[i] * MULTIPLIER);
+}

test/fixtures/transformation/for-of/let/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
 for (var _iterator = arr[Symbol.iterator](), _step; !(_step = _iterator.next()).done;) {
-  var _i = _step.value;
-}
+  var i = _step.value;
+}

test/fixtures/transformation/let-scoping/closure/actual.js

@@ -0,0 +1,9 @@
+(function() {
+  let foo = 'bar';
+
+  [true].forEach(function() {
+    foo = 'baz';
+  });
+
+  console.log(foo);
+});

test/fixtures/transformation/let-scoping/closure/expected.js

@@ -0,0 +1,11 @@
+"use strict";
+
+(function () {
+  var foo = "bar";
+
+  [true].forEach(function () {
+    foo = "baz";
+  });
+
+  console.log(foo);
+});

test/fixtures/transformation/let-scoping/deep-nested/exec.js

@@ -2,11 +2,11 @@ var a = 'var a';
 {
   var b = 'var b';
   {
-  var c = 'var c';
-  let d = 'let d';
-  assert.equal(d, 'let d');
+    var c = 'var c';
+    let d = 'let d';
+    assert.equal(d, 'let d');
   }
   assert.throws(function () {
-  d;
+    d;
   }, /d is not defined/);
 }

test/fixtures/transformation/let-scoping/for-in-initializers/exec.js

@@ -3,11 +3,11 @@ var result;
   let let_result = [];
   let let_array = ['one', 'two', 'three'];
   for (var index in let_array) {
-  let let_index = index;
-  let let_value = let_array[let_index];
-  let_result.push(function () {
-    return [let_index, let_value];
-  });
+    let let_index = index;
+    let let_value = let_array[let_index];
+    let_result.push(function () {
+      return [let_index, let_value];
+    });
   }
   result = let_result;
 }

test/fixtures/transformation/let-scoping/for-initializers/exec.js

@@ -3,10 +3,10 @@ var result;
   let let_x = 'let x';
   let let_l = [];
   for (var var_x = 1, var_y = 2, var_z = 3; var_x < 10; var_x ++) {
-  let l_x = var_x, l_y = var_y, l_z = var_z;
-  let_l.push(function () {
-    return [l_x, l_y, l_z];
-  });
+    let l_x = var_x, l_y = var_y, l_z = var_z;
+    let_l.push(function () {
+      return [l_x, l_y, l_z];
+    });
   }
   result = let_l;
 }

test/fixtures/transformation/let-scoping/function-declaration/actual.js

@@ -0,0 +1,9 @@
+domready(function () {
+  let a = 1;
+  const b = 1;
+  runIt();
+
+  function runIt() {
+    console.log(a + b);
+  }
+});

test/fixtures/transformation/let-scoping/function-declaration/expected.js

@@ -0,0 +1,11 @@
+"use strict";
+
+domready(function () {
+  var a = 1;
+  var b = 1;
+  runIt();
+
+  function runIt() {
+    console.log(a + b);
+  }
+});

test/fixtures/transformation/let-scoping/in-closure/exec.js

@@ -1,13 +1,13 @@
 function letInClosure(n) {
   var l = [];
   for (var i = 0; i < n; i ++) {
-  let let_i = i;
-  if (i % 3 == 0) {
-    continue;
-  }
-  l.push(function () {
-    return let_i;
-  });
+    let let_i = i;
+    if (i % 3 == 0) {
+      continue;
+    }
+    l.push(function () {
+      return let_i;
+    });
   }
   return l;
 }

test/fixtures/transformation/let-scoping/no-nested-function-declarations/actual.js

@@ -1,7 +0,0 @@
-var numbers = [1, 2, 3];
-
-for (let i in numbers) {
-  function foo() {
-    return i;
-  }
-}

test/fixtures/transformation/let-scoping/no-nested-function-declarations/options.json

@@ -1,3 +0,0 @@
-{
-  "throws": "`FunctionDeclaration`s that use `let` and `constant` references aren't allowed outside of the root scope"
-}

test/fixtures/transformation/let-scoping/no-renaming/actual.js

@@ -0,0 +1,6 @@
+function foo (n) {
+  let bar = n;
+  eval('console.log(bar)');
+}
+
+foo(42);

test/fixtures/transformation/let-scoping/no-renaming/expected.js

@@ -0,0 +1,9 @@
+"use strict";
+
+function foo(n) {
+  var bar = n;
+  eval("console.log(bar)");
+}
+
+foo(42);
+

test/fixtures/transformation/modules-amd/exports-variable/expected.js

@@ -8,12 +8,12 @@ define(["exports"], function (exports) {
   exports.foo2 = foo2;
   var foo3;
   exports.foo3 = foo3;
-  var _foo4 = 2;
-  exports.foo4 = _foo4;
-  var _foo5;
-  exports.foo5 = _foo5;
-  var _foo6 = 3;
-  exports.foo6 = _foo6;
+  var foo4 = 2;
+  exports.foo4 = foo4;
+  var foo5;
+  exports.foo5 = foo5;
+  var foo6 = 3;
+  exports.foo6 = foo6;
   function foo7() {}
 
   var foo8 = function foo8() {};

test/fixtures/transformation/modules-common/exports-variable/expected.js

@@ -7,12 +7,12 @@ var foo2 = function () {};
 exports.foo2 = foo2;
 var foo3;
 exports.foo3 = foo3;
-var _foo4 = 2;
-exports.foo4 = _foo4;
-var _foo5;
-exports.foo5 = _foo5;
-var _foo6 = 3;
-exports.foo6 = _foo6;
+var foo4 = 2;
+exports.foo4 = foo4;
+var foo5;
+exports.foo5 = foo5;
+var foo6 = 3;
+exports.foo6 = foo6;
 function foo7() {}
 
 var foo8 = function foo8() {};

test/fixtures/transformation/modules-umd/exports-variable/expected.js

@@ -14,12 +14,12 @@
   exports.foo2 = foo2;
   var foo3;
   exports.foo3 = foo3;
-  var _foo4 = 2;
-  exports.foo4 = _foo4;
-  var _foo5;
-  exports.foo5 = _foo5;
-  var _foo6 = 3;
-  exports.foo6 = _foo6;
+  var foo4 = 2;
+  exports.foo4 = foo4;
+  var foo5;
+  exports.foo5 = foo5;
+  var foo6 = 3;
+  exports.foo6 = foo6;
   function foo7() {}
 
   var foo8 = function foo8() {};