cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove parenthesizedArgument (#7981)

Browse Source 
The extra field parenthesizedArgument was never set to true. It was
always set to false and the code that read this was incorrectly
checking if extra was present.

Fixes #7957
This commit is contained in:
Erik Arvidsson 2018-05-29 13:58:21 -07:00 committed by Logan Smyth
parent 9add6d88f5
commit 2a8ebbe7ae
65 changed files with 14 additions and 254 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/babel-parser/src/parser/expression.js
View File

@ -287,9 +287,7 @@ export default class ExpressionParser extends LValParser {
if ( if (
operator === "**" && operator === "**" &&
left.type === "UnaryExpression" && left.type === "UnaryExpression" &&
left.extra && !(left.extra && left.extra.parenthesized)
!left.extra.parenthesizedArgument &&
!left.extra.parenthesized
) { ) {
this.raise( this.raise(
left.argument.start, left.argument.start,
@ -364,16 +362,8 @@ export default class ExpressionParser extends LValParser {
} }
this.next(); this.next();
const argType = this.state.type;
node.argument = this.parseMaybeUnary(); node.argument = this.parseMaybeUnary();
this.addExtra(
node,
"parenthesizedArgument",
argType === tt.parenL &&
(!node.argument.extra || !node.argument.extra.parenthesized),
);
if (refShorthandDefaultPos && refShorthandDefaultPos.start) { if (refShorthandDefaultPos && refShorthandDefaultPos.start) {
this.unexpected(refShorthandDefaultPos.start); this.unexpected(refShorthandDefaultPos.start);
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0000/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0001/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0002/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0003/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0004/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0005/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0006/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0007/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0008/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0009/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0010/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0011/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/expressions/esprima/expression-unary/migrated_0012/output.json
View File

@ -30,8 +30,5 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }

3
packages/babel-parser/test/fixtures/core/categorized/06-regex/output.json vendored
View File

@ -138,9 +138,6 @@
"body": [], "body": [],
"directives": [] "directives": []
} }
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"operator": "/", "operator": "/",

3
packages/babel-parser/test/fixtures/core/uncategorised/138/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/139/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/140/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/141/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/142/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/143/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/144/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/145/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/146/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/147/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/148/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/149/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/150/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/300/output.json vendored
View File

@ -122,9 +122,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/301/output.json vendored
View File

@ -122,9 +122,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/core/uncategorised/329/output.json vendored
View File

@ -88,9 +88,6 @@
} }
}, },
"properties": [] "properties": []
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"operator": "/", "operator": "/",

3
packages/babel-parser/test/fixtures/core/uncategorised/339/output.json vendored
View File

@ -106,9 +106,6 @@
}, },
"name": "x" "name": "x"
} }
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"operator": "/", "operator": "/",

9
packages/babel-parser/test/fixtures/es2015/for-in/nonstrict-initializer/output.json vendored
View File

@ -327,9 +327,6 @@
"identifierName": "effects" "identifierName": "effects"
}, },
"name": "effects" "name": "effects"
},
"extra": {
"parenthesizedArgument": false
} }
}, },
{ {
@ -367,9 +364,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
} }
], ],
@ -692,9 +686,6 @@
"identifierName": "iterations" "identifierName": "iterations"
}, },
"name": "iterations" "name": "iterations"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

6
packages/babel-parser/test/fixtures/es2015/modules/xml-comment-in-module/output.json vendored
View File

@ -123,13 +123,7 @@
"identifierName": "bar" "identifierName": "bar"
}, },
"name": "bar" "name": "bar"
},
"extra": {
"parenthesizedArgument": false
} }
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/es2015/yield/function-name-function-expression/output.json vendored
View File

@ -110,9 +110,6 @@
"body": [], "body": [],
"directives": [] "directives": []
} }
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/es2016/exponentiation-operator/2/output.json vendored
View File

@ -118,9 +118,6 @@
"parenthesized": true, "parenthesized": true,
"parenStart": 1 "parenStart": 1
} }
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/es2016/exponentiation-operator/7/output.json vendored
View File

@ -127,9 +127,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"extra": { "extra": {

3
packages/babel-parser/test/fixtures/es2016/exponentiation-operator/8/output.json vendored
View File

@ -127,9 +127,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
} }
}, },

1
packages/babel-parser/test/fixtures/es2016/exponentiation-operator/9/output.json vendored
View File

@ -94,7 +94,6 @@
"value": 5 "value": 5
}, },
"extra": { "extra": {
"parenthesizedArgument": false,
"parenthesized": true, "parenthesized": true,
"parenStart": 0 "parenStart": 0
} }

3
packages/babel-parser/test/fixtures/esprima/automatic-semicolon-insertion/migrated_0000/output.json vendored
View File

@ -122,9 +122,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/automatic-semicolon-insertion/migrated_0001/output.json vendored
View File

@ -122,9 +122,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0000/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0001/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0002/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0003/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "eval" "identifierName": "eval"
}, },
"name": "eval" "name": "eval"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0004/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0005/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "arguments" "identifierName": "arguments"
}, },
"name": "arguments" "name": "arguments"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0006/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0007/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0008/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0009/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0010/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0011/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/esprima/expression-unary/migrated_0012/output.json vendored
View File

@ -75,9 +75,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/experimental/class-private-methods/async-generator/output.json vendored
View File

@ -386,9 +386,6 @@
"name": "EOF" "name": "EOF"
}, },
"computed": false "computed": false
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"body": { "body": {

24
packages/babel-parser/test/fixtures/experimental/class-private-properties/nested/output.json vendored
View File

@ -494,9 +494,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -625,9 +622,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -1158,9 +1152,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -1289,9 +1280,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -1630,9 +1618,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -1971,9 +1956,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -2992,9 +2974,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -3333,9 +3312,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

12
packages/babel-parser/test/fixtures/experimental/class-private-properties/pbn-success/output.json vendored
View File

@ -494,9 +494,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -625,9 +622,6 @@
"identifierName": "y" "identifierName": "y"
}, },
"name": "y" "name": "y"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -966,9 +960,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }
@ -1307,9 +1298,6 @@
"identifierName": "value" "identifierName": "value"
}, },
"name": "value" "name": "value"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/experimental/throw-expression/comma/output.json vendored
View File

@ -142,9 +142,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
}, },
{ {

1
packages/babel-parser/test/fixtures/experimental/throw-expression/expression/output.json vendored
View File

@ -129,7 +129,6 @@
"value": 1 "value": 1
}, },
"extra": { "extra": {
"parenthesizedArgument": false,
"parenthesized": true, "parenthesized": true,
"parenStart": 20 "parenStart": 20
} }

3
packages/babel-parser/test/fixtures/experimental/throw-expression/logical/output.json vendored
View File

@ -158,9 +158,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/flow/predicates/2/output.json vendored
View File

@ -203,9 +203,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"operator": "===", "operator": "===",

3
packages/babel-parser/test/fixtures/flow/predicates/3/output.json vendored
View File

@ -202,9 +202,6 @@
"identifierName": "x" "identifierName": "x"
}, },
"name": "x" "name": "x"
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"operator": "===", "operator": "===",

6
packages/babel-parser/test/fixtures/flow/regression/issue-58/output.json vendored
View File

@ -5647,13 +5647,7 @@
"identifierName": "p" "identifierName": "p"
}, },
"name": "p" "name": "p"
},
"extra": {
"parenthesizedArgument": false
} }
},
"extra": {
"parenthesizedArgument": false
} }
}, },
"consequent": { "consequent": {

3
packages/babel-parser/test/fixtures/flow/type-annotations/negative-number-literal/output.json vendored
View File

@ -286,9 +286,6 @@
"raw": "1" "raw": "1"
}, },
"value": 1 "value": 1
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }

3
packages/babel-parser/test/fixtures/typescript/cast/null-assertion-false-positive/output.json vendored
View File

@ -107,9 +107,6 @@
"identifierName": "b" "identifierName": "b"
}, },
"name": "b" "name": "b"
},
"extra": {
"parenthesizedArgument": false
} }
} }
} }