DRY up plugin manager position definition

This commit is contained in:
Sebastian McKenzie 2015-04-30 18:13:33 +01:00
parent ea03f67505
commit 2c3d3d8105

View File

@ -18,6 +18,8 @@ export default class PluginManager {
return transformer; return transformer;
} }
static positions = ["before", "after"];
constructor({ file, transformers, before, after } = { transformers: {}, before: [], after: [] }) { constructor({ file, transformers, before, after } = { transformers: {}, before: [], after: [] }) {
this.transformers = transformers; this.transformers = transformers;
this.file = file; this.file = file;
@ -25,7 +27,7 @@ export default class PluginManager {
this.after = after; this.after = after;
} }
subnormaliseString(key, _position) { subnormaliseString(name, position) {
// this is a plugin in the form of "foobar" or "foobar:after" // this is a plugin in the form of "foobar" or "foobar:after"
// where the optional colon is the delimiter for plugin position in the transformer stack // where the optional colon is the delimiter for plugin position in the transformer stack
@ -80,7 +82,7 @@ export default class PluginManager {
position = position || "before"; position = position || "before";
// validate position // validate position
if (position !== "before" && position !== "after") { if (PluginManager.positions.indexOf(position) < 0) {
throw new TypeError(messages.get("pluginIllegalPosition", position, name)); throw new TypeError(messages.get("pluginIllegalPosition", position, name));
} }