cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

linting: disallow t.identifier("undefined") in plugins (#6096)

Browse Source 
* add new custom eslint rule, replace remaining t.identifier("undefined") with buildUndefinedNode(), update tests

* change no-undefined-identifier reporting descriptor
This commit is contained in:
Noah Lemen
2017-08-24 15:43:01 -04:00
committed by Justin Ridgewell
parent 4577bd1b7c
commit 2db0c3ad1d
41 changed files with 105 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js
View File

@@ -201,7 +201,7 @@ export default function() {
state.opts.allowTopLevelThis !== true &&
!path.findParent(path => THIS_BREAK_KEYS.indexOf(path.type) >= 0)
) {
path.replaceWith(t.identifier("undefined"));
path.replaceWith(path.scope.buildUndefinedNode());
}
},
@@ -568,7 +568,7 @@ export default function() {
maxHoistedExportsNodeAssignmentLength,
);
let hoistedExportsNode = t.identifier("undefined");
let hoistedExportsNode = scope.buildUndefinedNode();
nonHoistedExportNamesChunk.forEach(function(name) {
hoistedExportsNode = buildExportsAssignment(