cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Exclude super from being assign (#4642)

Browse Source 
Assigning of super is not allowed `var ref = super;` This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned.
This commit is contained in:
Daniel Tschinder
2016-10-04 03:04:26 +02:00
committed by Henry Zhu
parent ab3cff7cc3
commit 2dcee25d37
4 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/babel-helper-explode-assignable-expression/src/index.js
View File

@@ -3,7 +3,10 @@ import * as t from "babel-types";
function getObjRef(node, nodes, file, scope) {
let ref;
if (t.isIdentifier(node)) {
if (t.isSuper(node)) {
// Super cannot be directly assigned so lets return it directly
return node;
} else if (t.isIdentifier(node)) {
if (scope.hasBinding(node.name)) {
// this variable is declared in scope so we can be 100% sure
// that evaluating it multiple times wont trigger a getter
@@ -17,10 +20,11 @@ function getObjRef(node, nodes, file, scope) {
} else if (t.isMemberExpression(node)) {
ref = node.object;
if (t.isIdentifier(ref) && scope.hasBinding(ref.name)) {
if (t.isSuper(ref) || t.isIdentifier(ref) && scope.hasBinding(ref.name)) {
// the object reference that we need to save is locally declared
// so as per the previous comment we can be 100% sure evaluating
// it multiple times will be safe
// Super cannot be directly assigned so lets return it also
return ref;
}
} else {