cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ensure that invalid identifier JSX attribute keys are quoted when transforming to calls - fixes #2675

Browse Source
This commit is contained in:
Sebastian McKenzie 2015-10-30 17:16:47 +00:00
parent 5bda4d9744
commit 309a7556ff
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/babel-core/test/fixtures/transformation/react/should-quote-jsx-attributes/actual.js vendored Normal file
View File

@ -0,0 +1 @@
<button data-value='a value'>Button</button>;

5
packages/babel-core/test/fixtures/transformation/react/should-quote-jsx-attributes/expected.js vendored Normal file
View File

@ -0,0 +1,5 @@
React.createElement(
'button',
{ 'data-value': 'a value' },
'Button'
);

9
packages/babel-helper-builder-react-jsx/src/index.js
View File

@ -1,6 +1,5 @@
/* @flow */ /* @flow */
import isString from "lodash/lang/isString";
import esutils from "esutils"; import esutils from "esutils";
import * as t from "babel-types"; import * as t from "babel-types";
@ -66,11 +65,15 @@ export default function (opts) {
function convertAttribute(node) { function convertAttribute(node) {
let value = convertAttributeValue(node.value || t.booleanLiteral(true)); let value = convertAttributeValue(node.value || t.booleanLiteral(true));
if (t.isLiteral(value) && isString(value.value)) { if (t.isStringLiteral(value)) {
value.value = value.value.replace(/\n\s+/g, " "); value.value = value.value.replace(/\n\s+/g, " ");
} }
node.name.type = "Identifier"; if (t.isValidIdentifier(node.name.name)) {
node.name.type = "Identifier";
} else {
node.name = t.stringLiteral(node.name.name);
}
return t.inherits(t.objectProperty(node.name, value), node); return t.inherits(t.objectProperty(node.name, value), node);
} }