cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix invalid codegen for number member expr

Browse Source
This commit is contained in:
Amjad Masad
2015-12-15 17:46:42 -08:00
parent 59f5e7f218
commit 320cede9be
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/babel-generator/src/generators/expressions.js
View File

@@ -221,14 +221,8 @@ export function MemberExpression(node: Object) {
this.print(node.property, node); this.print(node.property, node);
this.push("]"); this.push("]");
} else { } else {
if (t.isLiteral(node.object) && !t.isTemplateLiteral(node.object)) { if (t.isNumericLiteral(node.object)) {
let val; let val = this.getPossibleRaw(node.object) || node.object.value;
if (this.format.minified) {
val = this._stringLiteral(node.object);
} else {
val = this.getPossibleRaw(node.object) || this._stringLiteral(node.object);
}
if (isInteger(+val) && !SCIENTIFIC_NOTATION.test(val) && !ZERO_DECIMAL_INTEGER.test(val) && !this.endsWith(".")) { if (isInteger(+val) && !SCIENTIFIC_NOTATION.test(val) && !ZERO_DECIMAL_INTEGER.test(val) && !this.endsWith(".")) {
this.push("."); this.push(".");
} }

5
packages/babel-generator/test/index.js
View File

@@ -16,6 +16,11 @@ suite("generation", function () {
assert.ok(t.VISITOR_KEYS[type], type + " should not exist"); assert.ok(t.VISITOR_KEYS[type], type + " should not exist");
}); });
}); });
test("valid code", function() {
// Should not generate `0.foo`
new Function(generate.default(t.memberExpression(t.numericLiteral(60702), t.identifier("foo"))).code);
});
}); });
var suites = require("babel-helper-fixtures").default(__dirname + "/fixtures"); var suites = require("babel-helper-fixtures").default(__dirname + "/fixtures");