cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Delete useless check for variable redeclaration (#14129)

Browse Source
This commit is contained in:
Arthur 2022-01-10 22:39:52 +08:00 committed by GitHub
parent 04f3f17556
commit 335622f75d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-traverse/src/scope/binding.ts
View File

@ -2,7 +2,7 @@ import type NodePath from "../path";
import type * as t from "@babel/types"; import type * as t from "@babel/types";
import type Scope from "./index"; import type Scope from "./index";
type BindingKind = export type BindingKind =
| "var" /* var declarator */ | "var" /* var declarator */
| "let" /* let declarator, class declaration id, catch clause parameters */ | "let" /* let declarator, class declaration id, catch clause parameters */
| "const" /* const declarator */ | "const" /* const declarator */

5
packages/babel-traverse/src/scope/index.ts
View File

@ -3,6 +3,7 @@ import type NodePath from "../path";
import traverse from "../index"; import traverse from "../index";
import type { TraverseOptions } from "../index"; import type { TraverseOptions } from "../index";
import Binding from "./binding"; import Binding from "./binding";
import type { BindingKind } from "./binding";
import globals from "globals"; import globals from "globals";
import { import {
NOT_LOCAL_BINDING, NOT_LOCAL_BINDING,
@ -569,7 +570,7 @@ export default class Scope {
checkBlockScopedCollisions( checkBlockScopedCollisions(
local: Binding, local: Binding,
kind: string, kind: BindingKind,
name: string, name: string,
id: any, id: any,
) { ) {
@ -587,7 +588,7 @@ export default class Scope {
local.kind === "const" || local.kind === "const" ||
local.kind === "module" || local.kind === "module" ||
// don't allow a local of param with a kind of let // don't allow a local of param with a kind of let
(local.kind === "param" && (kind === "let" || kind === "const")); (local.kind === "param" && kind === "const");
if (duplicate) { if (duplicate) {
throw this.hub.buildError( throw this.hub.buildError(