cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Trailing comma after rest - The final fix (#10491)

Browse Source 
* [parser] Track trailing commas in extras instead of state

* Update existing tests

* Update test262 whitelist

* Improve error message and location

* nit

* Use lookaheadCharCode
This commit is contained in:
Nicolò Ribaudo
2019-10-08 23:08:50 +02:00
committed by GitHub
parent c7add11fdc
commit 34937f13d5
46 changed files with 226 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/babel-parser/test/fixtures/comments/basic/array-expression-trailing-comma/output.json vendored
View File

@@ -373,7 +373,10 @@
}
]
}
]
],
"extra": {
"trailingComma": 140
}
}
}
],
@@ -494,7 +497,10 @@
}
]
}
]
],
"extra": {
"trailingComma": 200
}
}
}
],

3
packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma-shorthand/output.json vendored
View File

@@ -74,6 +74,9 @@
},
"name": "fn"
},
"extra": {
"trailingComma": 11
},
"arguments": [
{
"type": "Identifier",

3
packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma/output.json vendored
View File

@@ -74,6 +74,9 @@
},
"name": "fn"
},
"extra": {
"trailingComma": 7
},
"arguments": [
{
"type": "Identifier",

3
packages/babel-parser/test/fixtures/comments/basic/object-expression-trailing-comma/output.json vendored
View File

@@ -181,6 +181,9 @@
}
}
],
"extra": {
"trailingComma": 35
},
"trailingComments": [
{
"type": "CommentBlock",

5
packages/babel-parser/test/fixtures/comments/basic/object-property-trailing-comma/output.json vendored
View File

@@ -309,7 +309,10 @@
}
]
}
]
],
"extra": {
"trailingComma": 66
}
}
}
],

5
packages/babel-parser/test/fixtures/comments/regression/10230/output.json vendored
View File

@@ -163,7 +163,10 @@
}
]
}
]
],
"extra": {
"trailingComma": 13
}
}
},
"trailingComments": [

5
packages/babel-parser/test/fixtures/core/uncategorised/10/output.json vendored
View File

@@ -110,7 +110,10 @@
},
"value": 42
}
]
],
"extra": {
"trailingComma": 8
}
}
}
}

5
packages/babel-parser/test/fixtures/core/uncategorised/12/output.json vendored
View File

@@ -150,7 +150,10 @@
},
"value": 3
}
]
],
"extra": {
"trailingComma": 13
}
}
}
}

5
packages/babel-parser/test/fixtures/core/uncategorised/13/output.json vendored
View File

@@ -151,7 +151,10 @@
},
"value": 3
}
]
],
"extra": {
"trailingComma": 14
}
}
}
}

2
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-rest/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Rest element must be last element (1:5)"
"throws": "Unexpected trailing comma after rest element (1:5)"
}

1
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-spread-for-in/input.js vendored Normal file
View File

@@ -0,0 +1 @@
for ([...a,] in []);

3
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-spread-for-in/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Unexpected trailing comma after rest element (1:10)"
}

1
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-spread-nested/input.js vendored Normal file
View File

@@ -0,0 +1 @@
[[...a,]] = [];

3
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-spread-nested/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Unexpected trailing comma after rest element (1:6)"
}

5
packages/babel-parser/test/fixtures/es2015/array-rest-spread/comma-after-spread/output.json vendored
View File

@@ -90,7 +90,10 @@
"name": "a"
}
}
]
],
"extra": {
"trailingComma": 5
}
}
}
],

2
packages/babel-parser/test/fixtures/es2015/arrow-functions/comma-after-rest-param/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Rest element must be last element (1:8)"
"throws": "Unexpected trailing comma after rest element (1:8)"
}

5
packages/babel-parser/test/fixtures/es2015/uncategorised/322/output.json vendored
View File

@@ -91,7 +91,10 @@
"name": "x"
},
null
]
],
"extra": {
"trailingComma": 3
}
},
"right": {
"type": "NumericLiteral",

4
packages/babel-parser/test/fixtures/es2017/async-functions/params-invalid-rest-trailing-comma/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Rest element must be last element (1:11)"
}
"throws": "Unexpected trailing comma after rest element (1:11)"
}

3
packages/babel-parser/test/fixtures/es2017/trailing-function-commas/1/output.json vendored
View File

@@ -74,6 +74,9 @@
},
"name": "log"
},
"extra": {
"trailingComma": 13
},
"arguments": [
{
"type": "Identifier",

5
packages/babel-parser/test/fixtures/es2018/object-rest-spread/10/output.json vendored
View File

@@ -183,7 +183,10 @@
"shorthand": true
}
}
]
],
"extra": {
"trailingComma": 10
}
},
"init": {
"type": "Identifier",

1
packages/babel-parser/test/fixtures/es2018/object-rest-spread/6/output.json vendored
View File

@@ -289,6 +289,7 @@
}
],
"extra": {
"trailingComma": 21,
"parenthesized": true,
"parenStart": 0
}

2
packages/babel-parser/test/fixtures/es2018/object-rest-spread/8/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Rest element must be last element (1:16)"
"throws": "Unexpected trailing comma after rest element (1:16)"
}

1
packages/babel-parser/test/fixtures/es2018/object-rest-spread/comma-after-spread-for-in/input.js vendored Normal file
View File

@@ -0,0 +1 @@
for ({...a,} in []);

3
packages/babel-parser/test/fixtures/es2018/object-rest-spread/comma-after-spread-for-in/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Rest element must be last element (1:10)"
}

1
packages/babel-parser/test/fixtures/es2018/object-rest-spread/comma-after-spread-nested/input.js vendored Normal file
View File

@@ -0,0 +1 @@
[{...a,}] = [];

3
packages/babel-parser/test/fixtures/es2018/object-rest-spread/comma-after-spread-nested/options.json vendored Normal file
View File

@@ -0,0 +1,3 @@
{
"throws": "Rest element must be last element (1:6)"
}

1
packages/babel-parser/test/fixtures/es2018/object-rest-spread/comma-after-spread/output.json vendored
View File

@@ -92,6 +92,7 @@
}
],
"extra": {
"trailingComma": 6,
"parenthesized": true,
"parenStart": 0
}

5
packages/babel-parser/test/fixtures/esprima/es2015-array-binding-pattern/elision/output.json vendored
View File

@@ -78,7 +78,10 @@
"elements": [
null,
null
]
],
"extra": {
"trailingComma": 3
}
}
],
"body": {

5
packages/babel-parser/test/fixtures/esprima/es2015-destructuring-assignment-array-pattern/elision/output.json vendored
View File

@@ -75,7 +75,10 @@
"elements": [
null,
null
]
],
"extra": {
"trailingComma": 2
}
},
"right": {
"type": "NumericLiteral",

1
packages/babel-parser/test/fixtures/esprima/es2015-object-initialiser/proto-identifier-method/output.json vendored
View File

@@ -166,6 +166,7 @@
}
],
"extra": {
"trailingComma": 33,
"parenthesized": true,
"parenStart": 0
}

1
packages/babel-parser/test/fixtures/esprima/es2015-object-initialiser/proto-literal-method/output.json vendored
View File

@@ -169,6 +169,7 @@
}
],
"extra": {
"trailingComma": 35,
"parenthesized": true,
"parenStart": 0
}

5
packages/babel-parser/test/fixtures/esprima/es2015-object-pattern/elision/output.json vendored
View File

@@ -128,7 +128,10 @@
"shorthand": true
}
}
]
],
"extra": {
"trailingComma": 6
}
},
"init": {
"type": "NumericLiteral",

5
packages/babel-parser/test/fixtures/esprima/expression-primary-array/migrated_0003/output.json vendored
View File

@@ -110,7 +110,10 @@
},
"value": 42
}
]
],
"extra": {
"trailingComma": 8
}
}
}
}

5
packages/babel-parser/test/fixtures/esprima/expression-primary-array/migrated_0005/output.json vendored
View File

@@ -150,7 +150,10 @@
},
"value": 3
}
]
],
"extra": {
"trailingComma": 13
}
}
}
}

5
packages/babel-parser/test/fixtures/esprima/expression-primary-array/migrated_0006/output.json vendored
View File

@@ -151,7 +151,10 @@
},
"value": 3
}
]
],
"extra": {
"trailingComma": 14
}
}
}
}

2
packages/babel-parser/test/fixtures/experimental/dynamic-import/invalid-trailing-comma/options.json vendored
View File

@@ -1,3 +1,3 @@
{
"throws": "Trailing comma is disallowed inside import(...) arguments (1:13)"
"throws": "Trailing comma is disallowed inside import(...) arguments (1:12)"
}

5
packages/babel-parser/test/fixtures/flow/tuples/3/output.json vendored
View File

@@ -157,7 +157,10 @@
},
"value": 123
}
]
],
"extra": {
"trailingComma": 24
}
}
}
],

7
packages/babel-parser/test/fixtures/flow/type-parameter-declaration/object-method-type-param-jsx/output.json vendored
View File

@@ -187,7 +187,6 @@
"column": 23
}
},
"attributes": [],
"name": {
"type": "JSXIdentifier",
"start": 29,
@@ -204,6 +203,7 @@
},
"name": "Foo"
},
"attributes": [],
"selfClosing": true
},
"closingElement": null,
@@ -263,7 +263,10 @@
]
}
}
]
],
"extra": {
"trailingComma": 39
}
}
}
],

5
packages/babel-parser/test/fixtures/flow/type-parameter-declaration/object-reserved-word/output.json vendored
View File

@@ -450,7 +450,10 @@
]
}
}
]
],
"extra": {
"trailingComma": 77
}
}
}
],