cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Parse non-octals with leading zeros in non strict mode correctly (#9114)

Browse Source 
* Parse non-octals with leading zeros in non strict mode correctly

* Better error message
This commit is contained in:
Daniel Tschinder
2018-12-03 00:04:37 -08:00
committed by GitHub
parent 07eaa3c63f
commit 3932830535
16 changed files with 104 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/babel-parser/src/tokenizer/index.js
View File

@@ -971,14 +971,26 @@ export default class Tokenizer extends LocationParser {
readNumber(startsWithDot: boolean): void {
const start = this.state.pos;
let octal = this.input.charCodeAt(start) === charCodes.digit0;
let isFloat = false;
let isBigInt = false;
if (!startsWithDot && this.readInt(10) === null) {
this.raise(start, "Invalid number");
}
if (octal && this.state.pos == start + 1) octal = false; // number === 0
let octal =
this.state.pos - start >= 2 &&
this.input.charCodeAt(start) === charCodes.digit0;
if (octal) {
if (this.state.strict) {
this.raise(
start,
"Legacy octal literals are not allowed in strict mode",
);
}
if (/[89]/.test(this.input.slice(start, this.state.pos))) {
octal = false;
}
}
let next = this.input.charCodeAt(this.state.pos);
if (next === charCodes.dot && !octal) {
@@ -1022,18 +1034,7 @@ export default class Tokenizer extends LocationParser {
return;
}
let val;
if (isFloat) {
val = parseFloat(str);
} else if (!octal || str.length === 1) {
val = parseInt(str, 10);
} else if (this.state.strict) {
this.raise(start, "Invalid number");
} else if (/[89]/.test(str)) {
val = parseInt(str, 10);
} else {
val = parseInt(str, 8);
}
const val = octal ? parseInt(str, 8) : parseFloat(str);
this.finishToken(tt.num, val);
}