Parse non-octals with leading zeros in non strict mode correctly (#9114)

* Parse non-octals with leading zeros in non strict mode correctly

* Better error message

packages/babel-parser/src/tokenizer/index.js

@@ -971,14 +971,26 @@ export default class Tokenizer extends LocationParser {
 
   readNumber(startsWithDot: boolean): void {
     const start = this.state.pos;
-    let octal = this.input.charCodeAt(start) === charCodes.digit0;
     let isFloat = false;
     let isBigInt = false;
 
     if (!startsWithDot && this.readInt(10) === null) {
       this.raise(start, "Invalid number");
     }
-    if (octal && this.state.pos == start + 1) octal = false; // number === 0
+    let octal =
+      this.state.pos - start >= 2 &&
+      this.input.charCodeAt(start) === charCodes.digit0;
+    if (octal) {
+      if (this.state.strict) {
+        this.raise(
+          start,
+          "Legacy octal literals are not allowed in strict mode",
+        );
+      }
+      if (/[89]/.test(this.input.slice(start, this.state.pos))) {
+        octal = false;
+      }
+    }
 
     let next = this.input.charCodeAt(this.state.pos);
     if (next === charCodes.dot && !octal) {
@@ -1022,18 +1034,7 @@ export default class Tokenizer extends LocationParser {
       return;
     }
 
-    let val;
+    const val = octal ? parseInt(str, 8) : parseFloat(str);
-    if (isFloat) {
-      val = parseFloat(str);
-    } else if (!octal || str.length === 1) {
-      val = parseInt(str, 10);
-    } else if (this.state.strict) {
-      this.raise(start, "Invalid number");
-    } else if (/[89]/.test(str)) {
-      val = parseInt(str, 10);
-    } else {
-      val = parseInt(str, 8);
-    }
     this.finishToken(tt.num, val);
   }
 

packages/babel-parser/test/fixtures/core/regression/non-octal-float-strict-mode/input.js

@@ -0,0 +1 @@
+09.5

packages/babel-parser/test/fixtures/core/regression/non-octal-float-strict-mode/options.json

@@ -0,0 +1,4 @@
+{
+    "sourceType": "module",
+    "throws": "Legacy octal literals are not allowed in strict mode (1:0)"
+}

packages/babel-parser/test/fixtures/core/regression/non-octal-float/input.js

@@ -0,0 +1 @@
+09.5

packages/babel-parser/test/fixtures/core/regression/non-octal-float/output.json

@@ -0,0 +1,70 @@
+{
+  "type": "File",
+  "start": 0,
+  "end": 4,
+  "loc": {
+    "start": {
+      "line": 1,
+      "column": 0
+    },
+    "end": {
+      "line": 1,
+      "column": 4
+    }
+  },
+  "program": {
+    "type": "Program",
+    "start": 0,
+    "end": 4,
+    "loc": {
+      "start": {
+        "line": 1,
+        "column": 0
+      },
+      "end": {
+        "line": 1,
+        "column": 4
+      }
+    },
+    "sourceType": "script",
+    "interpreter": null,
+    "body": [
+      {
+        "type": "ExpressionStatement",
+        "start": 0,
+        "end": 4,
+        "loc": {
+          "start": {
+            "line": 1,
+            "column": 0
+          },
+          "end": {
+            "line": 1,
+            "column": 4
+          }
+        },
+        "expression": {
+          "type": "NumericLiteral",
+          "start": 0,
+          "end": 4,
+          "loc": {
+            "start": {
+              "line": 1,
+              "column": 0
+            },
+            "end": {
+              "line": 1,
+              "column": 4
+            }
+          },
+          "extra": {
+            "rawValue": 9.5,
+            "raw": "09.5"
+          },
+          "value": 9.5
+        }
+      }
+    ],
+    "directives": []
+  }
+}

packages/babel-parser/test/fixtures/core/regression/octal-float-fail/input.js

@@ -0,0 +1 @@
+07.5

packages/babel-parser/test/fixtures/core/regression/octal-float-fail/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "Unexpected token, expected \";\" (1:2)"
+}

packages/babel-parser/test/fixtures/core/uncategorised/500/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:33)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:33)"
 }

packages/babel-parser/test/fixtures/core/uncategorised/502/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:36)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:36)"
 }

packages/babel-parser/test/fixtures/core/uncategorised/522/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:65)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:65)"
 }

packages/babel-parser/test/fixtures/core/uncategorised/550/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (2:10)"
+  "throws": "Legacy octal literals are not allowed in strict mode (2:10)"
 }

packages/babel-parser/test/fixtures/core/uncategorised/552/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (2:10)"
+  "throws": "Legacy octal literals are not allowed in strict mode (2:10)"
 }

packages/babel-parser/test/fixtures/es2015/uncategorised/249/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:21)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:21)"
 }

packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0094/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:21)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:21)"
 }

packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0218/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:33)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:33)"
 }

packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0220/options.json

@@ -1,3 +1,3 @@
 {
-  "throws": "Invalid number (1:36)"
+  "throws": "Legacy octal literals are not allowed in strict mode (1:36)"
 }