cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

refactor: avoid unnecessary property access (#11918)

Browse Source 
* refactor: avoid unnecessary property access

* refactor: `else` is redundant because keyName is const
This commit is contained in:
Huáng Jùnliàng 2020-08-05 15:39:45 -04:00 committed by GitHub
parent acf2b144a4
commit 50b3262063
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/babel-parser/src/parser/expression.js
View File

@ -1737,7 +1737,7 @@ export default class ExpressionParser extends LValParser {
} }
const containsEsc = this.state.containsEsc; const containsEsc = this.state.containsEsc;
this.parsePropertyName(prop, /* isPrivateNameAllowed */ false); const key = this.parsePropertyName(prop, /* isPrivateNameAllowed */ false);
if ( if (
!isPattern && !isPattern &&
@ -1745,19 +1745,20 @@ export default class ExpressionParser extends LValParser {
!containsEsc && !containsEsc &&
this.maybeAsyncOrAccessorProp(prop) this.maybeAsyncOrAccessorProp(prop)
) { ) {
const keyName = key.name;
// https://tc39.es/ecma262/#prod-AsyncMethod // https://tc39.es/ecma262/#prod-AsyncMethod
// https://tc39.es/ecma262/#prod-AsyncGeneratorMethod // https://tc39.es/ecma262/#prod-AsyncGeneratorMethod
if (prop.key.name === "async" && !this.hasPrecedingLineBreak()) { if (keyName === "async" && !this.hasPrecedingLineBreak()) {
isAsync = true; isAsync = true;
isGenerator = this.eat(tt.star); isGenerator = this.eat(tt.star);
this.parsePropertyName(prop, /* isPrivateNameAllowed */ false); this.parsePropertyName(prop, /* isPrivateNameAllowed */ false);
} }
// get PropertyName[?Yield, ?Await] () { FunctionBody[~Yield, ~Await] } // get PropertyName[?Yield, ?Await] () { FunctionBody[~Yield, ~Await] }
// set PropertyName[?Yield, ?Await] ( PropertySetParameterList ) { FunctionBody[~Yield, ~Await] } // set PropertyName[?Yield, ?Await] ( PropertySetParameterList ) { FunctionBody[~Yield, ~Await] }
else if (prop.key.name === "get" || prop.key.name === "set") { if (keyName === "get" || keyName === "set") {
isAccessor = true; isAccessor = true;
isGenerator = this.eat(tt.star); // tt.star is allowed in `maybeAsyncOrAccessorProp`, we will throw in `parseObjectMethod` later isGenerator = this.eat(tt.star); // tt.star is allowed in `maybeAsyncOrAccessorProp`, we will throw in `parseObjectMethod` later
prop.kind = prop.key.name; prop.kind = keyName;
this.parsePropertyName(prop, /* isPrivateNameAllowed */ false); this.parsePropertyName(prop, /* isPrivateNameAllowed */ false);
} }
} }