cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[parser] Better error message for missing number exponent (#12072)

Browse Source 
* fix(babel-parser) better error message for missing number exponent after 'e'

* fix(babel-parser) requested changes

* msg

Co-authored-by: Brian Ng <bng412@gmail.com>
This commit is contained in:
iamfotx 2020-10-15 00:17:38 +05:00 committed by GitHub
parent f697e7995d
commit 59d97d9bca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-parser/src/parser/error-message.js
View File

@ -77,6 +77,8 @@ export const ErrorMessages = Object.freeze({
InvalidLhs: "Invalid left-hand side in %0",
InvalidLhsBinding: "Binding invalid left-hand side in %0",
InvalidNumber: "Invalid number",
InvalidOrMissingExponent:
"Floating-point numbers require a valid exponent after the 'e'",
InvalidOrUnexpectedToken: "Unexpected character '%0'",
InvalidParenthesizedAssignment: "Invalid parenthesized assignment pattern",
InvalidPrivateFieldResolution: "Private name #%0 is not defined",

4
packages/babel-parser/src/tokenizer/index.js
View File

@ -1149,7 +1149,9 @@ export default class Tokenizer extends ParserErrors {
if (next === charCodes.plusSign || next === charCodes.dash) {
++this.state.pos;
}
if (this.readInt(10) === null) this.raise(start, Errors.InvalidNumber);
if (this.readInt(10) === null) {
this.raise(start, Errors.InvalidOrMissingExponent);
}
isFloat = true;
hasExponent = true;
next = this.input.charCodeAt(this.state.pos);

2
packages/babel-parser/test/fixtures/core/uncategorised/349/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":2,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":2}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",

2
packages/babel-parser/test/fixtures/core/uncategorised/350/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":3,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":3}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",

2
packages/babel-parser/test/fixtures/core/uncategorised/351/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":3,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":3}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",

2
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0004/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":2,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":2}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",

2
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0005/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":3,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":3}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",

2
packages/babel-parser/test/fixtures/esprima/invalid-syntax/migrated_0006/output.json vendored
View File

@ -2,7 +2,7 @@
"type": "File",
"start":0,"end":3,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":3}},
"errors": [
"SyntaxError: Invalid number (1:0)"
"SyntaxError: Floating-point numbers require a valid exponent after the 'e' (1:0)"
],
"program": {
"type": "Program",