cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[babel-cli] Don't fail when chmod throws an error (#12846)

Browse Source 
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
This commit is contained in:
Michael Tsulaya 2021-02-22 21:21:52 +03:00 committed by GitHub
parent c294de3529
commit 5bec993b7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/babel-cli/src/babel/util.js
View File

@ -6,7 +6,11 @@ import path from "path";
import fs from "fs"; import fs from "fs";
export function chmod(src: string, dest: string): void { export function chmod(src: string, dest: string): void {
fs.chmodSync(dest, fs.statSync(src).mode); try {
fs.chmodSync(dest, fs.statSync(src).mode);
} catch (err) {
console.warn(`Cannot change permissions of ${dest}`);
}
} }
type ReaddirFilter = (filename: string) => boolean; type ReaddirFilter = (filename: string) => boolean;

13
packages/babel-cli/test/index.js
View File

@ -7,6 +7,7 @@ const escapeRegExp = require("lodash/escapeRegExp");
const merge = require("lodash/merge"); const merge = require("lodash/merge");
const path = require("path"); const path = require("path");
const fs = require("fs"); const fs = require("fs");
const { chmod } = require("../lib/babel/util");
const fixtureLoc = path.join(__dirname, "fixtures"); const fixtureLoc = path.join(__dirname, "fixtures");
const tmpLoc = path.join(__dirname, "tmp"); const tmpLoc = path.join(__dirname, "tmp");
@ -269,3 +270,15 @@ fs.readdirSync(fixtureLoc).forEach(function (binName) {
}); });
}); });
}); });
describe("util.js", () => {
describe("chmod", () => {
it("should warn the user if chmod fails", () => {
const spyConsoleWarn = jest.spyOn(console, "warn");
// should expect a string as first argument
chmod(100, "file.js");
expect(spyConsoleWarn).toHaveBeenCalledTimes(1);
spyConsoleWarn.mockRestore();
});
});
});