Fix scope check for 2nd+ lexical bindings (#9600)

packages/babel-parser/src/util/scope.js

@@ -117,8 +117,7 @@ export default class ScopeHandler {
         const scope = this.scopeStack[i];
         if (
           (scope.lexical.indexOf(name) > -1 &&
-            !(scope.flags & SCOPE_SIMPLE_CATCH) &&
-            scope.lexical[0] === name) ||
+            !(scope.flags & SCOPE_SIMPLE_CATCH && scope.lexical[0] === name)) ||
           (!this.treatFunctionsAsVarInScope(scope) &&
             scope.functions.indexOf(name) > -1)
         ) {

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex-nested/input.js

@@ -0,0 +1,5 @@
+{
+  let bar;
+  var foo = 1;
+  let foo = 1;
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex-nested/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "Identifier 'foo' has already been declared (4:6)"
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex/input.js

@@ -0,0 +1,3 @@
+let bar;
+var foo = 1;
+let foo = 1;

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-lex/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "Identifier 'foo' has already been declared (3:4)"
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var-nested/input.js

@@ -0,0 +1,5 @@
+{
+  let bar;
+  let foo = 1;
+  var foo = 1;
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var-nested/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "Identifier 'foo' has already been declared (4:6)"
+}

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var/input.js

@@ -0,0 +1,3 @@
+let bar;
+let foo = 1;
+var foo = 1;

packages/babel-parser/test/fixtures/core/scope/dupl-bind-2nd-lvl-var/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "Identifier 'foo' has already been declared (3:4)"
+}