cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed the deprecated jsx pragma detection code (#6145)

Browse Source 
* Removed the deprecated jsx pragma detection code and the concerned tests that included jsx-pragma

* Removed extra tests

* Restored packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-pragma-option/
This commit is contained in:
Astha Sharma
2017-08-23 00:59:06 +05:30
committed by Henry Zhu
parent 63baaa7148
commit 62c22c7b5d
15 changed files with 39 additions and 168 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
packages/babel-plugin-transform-react-jsx/src/index.js
View File

@@ -2,8 +2,6 @@ import jsx from "babel-plugin-syntax-jsx";
import helper from "babel-helper-builder-react-jsx";
export default function({ types: t }) {
const JSX_ANNOTATION_REGEX = /\*?\s*@jsx\s+([^\s]+)/;
const visitor = helper({
pre(state) {
const tagName = state.tagName;
@@ -21,23 +19,7 @@ export default function({ types: t }) {
});
visitor.Program = function(path, state) {
const { file } = state;
let id = state.opts.pragma || "React.createElement";
for (const comment of (file.ast.comments: Array<Object>)) {
const matches = JSX_ANNOTATION_REGEX.exec(comment.value);
if (matches) {
id = matches[1];
if (id === "React.DOM") {
throw file.buildCodeFrameError(
comment,
"The @jsx React.DOM pragma has been deprecated as of React 0.12",
);
} else {
break;
}
}
}
const id = state.opts.pragma || "React.createElement";
state.set("jsxIdentifier", () =>
id

8
packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-comment-if-jsx-pragma-option-set/actual.js vendored
View File

@@ -1,8 +0,0 @@
/** @jsx dom */
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

6
packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-comment-if-jsx-pragma-option-set/expected.js vendored
View File

@@ -1,6 +0,0 @@
/** @jsx dom */
dom(Foo, null);
var profile = dom("div", null, dom("img", {
src: "avatar.png",
className: "profile"
}), dom("h3", null, [user.firstName, user.lastName].join(" ")));

5
packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-comment-if-jsx-pragma-option-set/options.json vendored
View File

@@ -1,5 +0,0 @@
{
"plugins": [
["transform-react-jsx", {"pragma": "foo.bar"}]
]
}

8
packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-comment/actual.js vendored
View File

@@ -1,8 +0,0 @@
/** @jsx dom */
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

6
packages/babel-plugin-transform-react-jsx/test/fixtures/react/honor-custom-jsx-comment/expected.js vendored
View File

@@ -1,6 +0,0 @@
/** @jsx dom */
dom(Foo, null);
var profile = dom("div", null, dom("img", {
src: "avatar.png",
className: "profile"
}), dom("h3", null, [user.firstName, user.lastName].join(" ")));

10
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-multiline/actual.js vendored
View File

@@ -1,10 +0,0 @@
/**
* @jsx React.DOM
*/
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-multiline/options.json vendored
View File

@@ -1,3 +0,0 @@
{
"throws": "The @jsx React.DOM pragma has been deprecated as of React 0.12"
}

8
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-simple/actual.js vendored
View File

@@ -1,8 +0,0 @@
/* @jsx React.DOM */
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-simple/options.json vendored
View File

@@ -1,3 +0,0 @@
{
"throws": "The @jsx React.DOM pragma has been deprecated as of React 0.12"
}

8
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-singleline/actual.js vendored
View File

@@ -1,8 +0,0 @@
// @jsx React.DOM
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom-singleline/options.json vendored
View File

@@ -1,3 +0,0 @@
{
"throws": "The @jsx React.DOM pragma has been deprecated as of React 0.12"
}

8
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom/actual.js vendored
View File

@@ -1,8 +0,0 @@
/** @jsx React.DOM */
<Foo></Foo>;
var profile = <div>
<img src="avatar.png" className="profile" />
<h3>{[user.firstName, user.lastName].join(" ")}</h3>
</div>;

3
packages/babel-plugin-transform-react-jsx/test/fixtures/react/throw-if-custom-jsx-comment-sets-react-dom/options.json vendored
View File

@@ -1,3 +0,0 @@
{
"throws": "The @jsx React.DOM pragma has been deprecated as of React 0.12"
}