cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Preserve namespaced attributes when throwIfNamespace is false (#7173)

Browse Source 
Previously that part would throw since it expects a JSXIdentifier but it (logically) gets a JSXNamespacedName when using a namespaced attribute.
This commit is contained in:
mtpc 2018-01-09 06:24:02 +01:00 committed by Logan Smyth
parent 74682f33bc
commit 63157159ab
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/babel-helper-builder-react-jsx/src/index.js
View File

@ -92,7 +92,11 @@ You can turn on the 'throwIfNamespace' flag to bypass this warning.`,
if (t.isValidIdentifier(node.name.name)) { if (t.isValidIdentifier(node.name.name)) {
node.name.type = "Identifier"; node.name.type = "Identifier";
} else { } else {
node.name = t.stringLiteral(node.name.name); node.name = t.stringLiteral(
t.isJSXNamespacedName(node.name)
? node.name.namespace.name + ":" + node.name.name.name
: node.name.name,
);
} }
return t.inherits(t.objectProperty(node.name, value), node); return t.inherits(t.objectProperty(node.name, value), node);

2
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-support-xml-namespaces-if-flag/actual.js vendored
View File

@ -1 +1 @@
<f:image />; <f:image n:attr />;

4
packages/babel-plugin-transform-react-jsx/test/fixtures/react/should-support-xml-namespaces-if-flag/expected.js vendored
View File

@ -1 +1,3 @@
h("f:image", null); h("f:image", {
"n:attr": true
});