cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix issue where we didn't record seeing a property sometimes.

Browse Source
This commit is contained in:
Chris Cowan 2016-03-01 17:13:20 -08:00
parent 3227279d95
commit 63af3d1366
3 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/babel-plugin-transform-es2015-duplicate-keys/src/index.js
View File

@ -33,23 +33,20 @@ export default function() {
case "get":
if (alreadySeenData[name] || alreadySeenGetters[name]) {
isDuplicate = true;
} else {
alreadySeenGetters[name] = true;
}
alreadySeenGetters[name] = true;
break;
case "set":
if (alreadySeenData[name] || alreadySeenSetters[name]) {
isDuplicate = true;
} else {
alreadySeenSetters[name] = true;
}
alreadySeenSetters[name] = true;
break;
default:
if (alreadySeenData[name] || alreadySeenGetters[name] || alreadySeenSetters[name]) {
isDuplicate = true;
} else {
alreadySeenData[name] = true;
}
alreadySeenData[name] = true;
}
if (isDuplicate) {

8
packages/babel-plugin-transform-es2015-duplicate-keys/test/fixtures/duplicate-keys/getters-and-setters/actual.js vendored
View File

@ -6,5 +6,11 @@ var x = {
a: 3,
b: 4,
get b() {},
set b(x) {}
set b(x) {},
get c() {},
c: 5,
set c(x) {},
set d(x) {},
d: 6,
get d() {}
};

8
packages/babel-plugin-transform-es2015-duplicate-keys/test/fixtures/duplicate-keys/getters-and-setters/expected.js vendored
View File

@ -6,5 +6,11 @@ var x = {
["a"]: 3,
b: 4,
get ["b"]() {},
set ["b"](x) {}
set ["b"](x) {},
get c() {},
["c"]: 5,
set ["c"](x) {},
set d(x) {},
["d"]: 6,
get ["d"]() {}
};