cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add support for class private methods (#703)

Browse Source 
* Add support for class private methods

This commit adds parser support for the TC39 Stage 2 Private Methods
proposal.

This commit also changes "key" in ClassPrivateProperty from an
Identifier to a PrivateName, as well as disallowing #constructor as a
valid private field name.

* Add tests for string literal get/set/async

These should be treated as regular methods and not special get/set/async
behaviour.

* Add tests for class private methods

This also removes a test from the Test262 whitelist that failed before
the changes for private methods support and now passes.

* Modify class private prop tests for PrivateName

* Add class private prop tests for #constructor

* Fix existing ASI test case failure
This commit is contained in:
Karl Cheng
2017-09-07 08:09:12 +10:00
committed by Justin Ridgewell
parent b65b5a2f1c
commit 65bea96544
54 changed files with 3430 additions and 425 deletions
Download Patch File Download Diff File Expand all files Collapse all files

204
test/fixtures/experimental/class-private-methods/method/expected.json vendored Normal file
View File

@@ -0,0 +1,204 @@
{
"type": "File",
"start": 0,
"end": 64,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"program": {
"type": "Program",
"start": 0,
"end": 64,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"sourceType": "script",
"body": [
{
"type": "ClassDeclaration",
"start": 0,
"end": 64,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 5,
"column": 1
}
},
"id": {
"type": "Identifier",
"start": 6,
"end": 11,
"loc": {
"start": {
"line": 1,
"column": 6
},
"end": {
"line": 1,
"column": 11
},
"identifierName": "Hotel"
},
"name": "Hotel"
},
"superClass": null,
"body": {
"type": "ClassBody",
"start": 12,
"end": 64,
"loc": {
"start": {
"line": 1,
"column": 12
},
"end": {
"line": 5,
"column": 1
}
},
"body": [
{
"type": "ClassPrivateMethod",
"start": 16,
"end": 62,
"loc": {
"start": {
"line": 2,
"column": 2
},
"end": {
"line": 4,
"column": 3
}
},
"static": false,
"key": {
"type": "PrivateName",
"start": 17,
"end": 26,
"loc": {
"start": {
"line": 2,
"column": 3
},
"end": {
"line": 2,
"column": 12
}
},
"id": {
"type": "Identifier",
"start": 17,
"end": 26,
"loc": {
"start": {
"line": 2,
"column": 3
},
"end": {
"line": 2,
"column": 12
},
"identifierName": "getBanned"
},
"name": "getBanned"
}
},
"kind": "method",
"id": null,
"generator": false,
"expression": false,
"async": false,
"params": [],
"body": {
"type": "BlockStatement",
"start": 29,
"end": 62,
"loc": {
"start": {
"line": 2,
"column": 15
},
"end": {
"line": 4,
"column": 3
}
},
"body": [
{
"type": "ReturnStatement",
"start": 35,
"end": 58,
"loc": {
"start": {
"line": 3,
"column": 4
},
"end": {
"line": 3,
"column": 27
}
},
"argument": {
"type": "CallExpression",
"start": 42,
"end": 57,
"loc": {
"start": {
"line": 3,
"column": 11
},
"end": {
"line": 3,
"column": 26
}
},
"callee": {
"type": "Identifier",
"start": 42,
"end": 55,
"loc": {
"start": {
"line": 3,
"column": 11
},
"end": {
"line": 3,
"column": 24
},
"identifierName": "violentPeople"
},
"name": "violentPeople"
},
"arguments": []
}
}
],
"directives": []
}
}
]
}
}
],
"directives": []
}
}