cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

enable prefer const (#5113)

Browse Source
This commit is contained in:
Henry Zhu
2017-01-14 09:48:52 -05:00
committed by GitHub
parent 982850731e
commit 672adba9a1
177 changed files with 1862 additions and 1863 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
packages/babel-helper-function-name/src/index.js
View File

@@ -4,7 +4,7 @@ import getFunctionArity from "babel-helper-get-function-arity";
import template from "babel-template";
import * as t from "babel-types";
let buildPropertyMethodAssignmentWrapper = template(`
const buildPropertyMethodAssignmentWrapper = template(`
(function (FUNCTION_KEY) {
function FUNCTION_ID() {
return FUNCTION_KEY.apply(this, arguments);
@@ -18,7 +18,7 @@ let buildPropertyMethodAssignmentWrapper = template(`
})(FUNCTION)
`);
let buildGeneratorPropertyMethodAssignmentWrapper = template(`
const buildGeneratorPropertyMethodAssignmentWrapper = template(`
(function (FUNCTION_KEY) {
function* FUNCTION_ID() {
return yield* FUNCTION_KEY.apply(this, arguments);
@@ -32,14 +32,14 @@ let buildGeneratorPropertyMethodAssignmentWrapper = template(`
})(FUNCTION)
`);
let visitor = {
const visitor = {
"ReferencedIdentifier|BindingIdentifier"(path, state) {
// check if this node matches our function id
if (path.node.name !== state.name) return;
// check that we don't have a local variable declared as that removes the need
// for the wrapper
let localDeclar = path.scope.getBindingIdentifier(state.name);
const localDeclar = path.scope.getBindingIdentifier(state.name);
if (localDeclar !== state.outerDeclar) return;
state.selfReference = true;
@@ -59,7 +59,7 @@ function wrap(state, method, id, scope) {
// need to add a wrapper since we can't change the references
let build = buildPropertyMethodAssignmentWrapper;
if (method.generator) build = buildGeneratorPropertyMethodAssignmentWrapper;
let template = build({
const template = build({
FUNCTION: method,
FUNCTION_ID: id,
FUNCTION_KEY: scope.generateUidIdentifier(id.name)
@@ -68,7 +68,7 @@ function wrap(state, method, id, scope) {
// shim in dummy params to retain function arity, if you try to read the
// source then you'll get the original since it's proxied so it's all good
let params = template.callee.body.body[0].params;
const params = template.callee.body.body[0].params;
for (let i = 0, len = getFunctionArity(method); i < len; i++) {
params.push(scope.generateUidIdentifier("x"));
}
@@ -82,7 +82,7 @@ function wrap(state, method, id, scope) {
}
function visit(node, name, scope) {
let state = {
const state = {
selfAssignment: false,
selfReference: false,
outerDeclar: scope.getBindingIdentifier(name),
@@ -93,7 +93,7 @@ function visit(node, name, scope) {
// check to see if we have a local binding of the id we're setting inside of
// the function, this is important as there are caveats associated
let binding = scope.getOwnBinding(name);
const binding = scope.getOwnBinding(name);
if (binding) {
if (binding.kind === "param") {
@@ -139,7 +139,7 @@ export default function ({ node, parent, scope, id }) {
id = parent.id;
if (t.isIdentifier(id)) {
let binding = scope.parent.getBinding(id.name);
const binding = scope.parent.getBinding(id.name);
if (binding && binding.constant && scope.getBinding(id.name) === binding) {
// always going to reference this method
node.id = id;
@@ -171,6 +171,6 @@ export default function ({ node, parent, scope, id }) {
// a local binding.
id[t.NOT_LOCAL_BINDING] = true;
let state = visit(node, name, scope);
const state = visit(node, name, scope);
return wrap(state, node, id, scope) || node;
}