Fix parsing of private fields (#566)

The computed key is not part of the spec.
key for ClassProperties is an Expression
Do not parse computed and literal keys for PrivateClassProperties

test/fixtures/experimental/class-private-properties/asi-success/expected.json

@@ -89,7 +89,6 @@
                   "column": 4
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 15,
@@ -123,7 +122,6 @@
                   "column": 4
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 20,
@@ -149,4 +147,4 @@
     ],
     "directives": []
   }
-}
+}

test/fixtures/experimental/class-private-properties/failure-computed/actual.js

@@ -1,4 +1,4 @@
 class Foo {
   #p = x
-  [#m] () {}
+  #[m] = 1
 }

test/fixtures/experimental/class-private-properties/failure-computed/options.json

@@ -1,5 +1,5 @@
 {
-  "throws": "Unexpected token, expected ; (3:10)",
+  "throws": "Unexpected token (3:3)",
   "plugins": [
     "classProperties",
     "classPrivateProperties"

test/fixtures/experimental/class-private-properties/failure-method/actual.js

@@ -0,0 +1,4 @@
+class Foo {
+  #p = x
+  #m () {}
+}

test/fixtures/experimental/class-private-properties/failure-method/options.json

@@ -1,3 +1,4 @@
 {
+  "throws": "Unexpected token, expected ; (3:5)",
   "plugins": ["classProperties", "classPrivateProperties"]
 }

test/fixtures/experimental/class-private-properties/failure-numeric-literal/actual.js

@@ -0,0 +1,3 @@
+class Foo {
+  #2 = y
+}

test/fixtures/experimental/class-private-properties/failure-numeric-literal/options.json

@@ -0,0 +1,7 @@
+{
+  "throws": "Unexpected token (2:3)",
+  "plugins": [
+    "classProperties",
+    "classPrivateProperties"
+    ]
+}

test/fixtures/experimental/class-private-properties/failure-string-literal/actual.js

@@ -0,0 +1,3 @@
+class Foo {
+  #"p" = x
+}

test/fixtures/experimental/class-private-properties/failure-string-literal/options.json

@@ -0,0 +1,7 @@
+{
+  "throws": "Unexpected token (2:3)",
+  "plugins": [
+    "classProperties",
+    "classPrivateProperties"
+    ]
+}

test/fixtures/experimental/class-private-properties/inline/expected.json

@@ -89,7 +89,6 @@
                   "column": 13
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 11,
@@ -123,7 +122,6 @@
                   "column": 17
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 15,
@@ -207,7 +205,6 @@
                   "column": 17
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 32,
@@ -260,7 +257,6 @@
                   "column": 25
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 40,
@@ -305,4 +301,4 @@
     ],
     "directives": []
   }
-}
+}

test/fixtures/experimental/class-private-properties/pbn-success.1/actual.js

@@ -1,19 +0,0 @@
-class Point {
-    #x;
-    #y;
-
-    constructor(x = 0, y = 0) {
-        #x = +x;
-        #y = +y;
-    }
-
-    get x() { return this.#x }
-    set x(value) { this.#x = +value }
-
-    get y() { return this.#y }
-    set y(value) { this.#y = +value }
-
-    equals(p) { return this.#x === p.#x && this.#y === p.#y }
-
-    toString() { return `Point<${ this.#x },${ this.#y }>` }
-}

test/fixtures/experimental/class-private-properties/pbn-success/expected.json

@@ -89,7 +89,6 @@
                   "column": 7
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 19,
@@ -123,7 +122,6 @@
                   "column": 7
                 }
               },
-              "computed": false,
               "key": {
                 "type": "Identifier",
                 "start": 27,
@@ -1623,4 +1621,4 @@
     ],
     "directives": []
   }
-}
+}