cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clarify warning source about underspecified corejs option in preset-env. (#12402)

Browse Source 
* Clarify these warnings are for babel-preset-env.

* Fix lint.

* Fix specs.

* Fix merge conflict.

* PR feedback.
This commit is contained in:
Andrew Smith 2020-12-01 00:58:06 -08:00 committed by GitHub
parent 4b79ab4a90
commit 71f87874ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 44 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/babel-preset-env/src/normalize-options.js
View File

@ -160,7 +160,7 @@ export function normalizeCoreJSOption(
if (useBuiltIns && corejs === undefined) { if (useBuiltIns && corejs === undefined) {
rawVersion = 2; rawVersion = 2;
console.warn( console.warn(
"\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + "\nWARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a " +
"core-js version. Currently, we assume version 2.x when no version " + "core-js version. Currently, we assume version 2.x when no version " +
"is passed. Since this default version will likely change in future " + "is passed. Since this default version will likely change in future " +
"versions of Babel, we recommend explicitly setting the core-js version " + "versions of Babel, we recommend explicitly setting the core-js version " +
@ -170,7 +170,9 @@ export function normalizeCoreJSOption(
"`dependencies` section. If it doesn't, you need to run one of the " + "`dependencies` section. If it doesn't, you need to run one of the " +
"following commands:\n\n" + "following commands:\n\n" +
" npm install --save core-js@2 npm install --save core-js@3\n" + " npm install --save core-js@2 npm install --save core-js@3\n" +
" yarn add core-js@2 yarn add core-js@3\n", " yarn add core-js@2 yarn add core-js@3\n\n" +
"More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins\n" +
"More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs",
); );
} else if (typeof corejs === "object" && corejs !== null) { } else if (typeof corejs === "object" && corejs !== null) {
rawVersion = corejs.version; rawVersion = corejs.version;
@ -183,7 +185,7 @@ export function normalizeCoreJSOption(
if (!useBuiltIns && version) { if (!useBuiltIns && version) {
console.log( console.log(
"\nThe `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", "\nWARNING (@babel/preset-env): The `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n",
); );
} }

2
packages/babel-preset-env/test/fixtures/debug/corejs-without-usebuiltins/stdout.txt vendored
View File

@ -1,4 +1,4 @@
The `corejs` option only has an effect when the `useBuiltIns` option is not `false` WARNING (@babel/preset-env): The `corejs` option only has an effect when the `useBuiltIns` option is not `false`
@babel/preset-env: `DEBUG` option @babel/preset-env: `DEBUG` option

7
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-no-import/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

7
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-shippedProposals/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

7
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs-uglify/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

7
packages/babel-preset-env/test/fixtures/debug/entry-no-corejs/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

5
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-1/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

5
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-2/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

7
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-1/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs

7
packages/babel-preset-env/test/fixtures/debug/usage-no-corejs-none-2/stderr.txt vendored
View File

@ -1,6 +1,9 @@
WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option. WARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.
You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands: You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:
npm install --save core-js@2 npm install --save core-js@3 npm install --save core-js@2 npm install --save core-js@3
yarn add core-js@2 yarn add core-js@3 yarn add core-js@2 yarn add core-js@3
More info about useBuiltIns: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
More info about core-js: https://babeljs.io/docs/en/babel-preset-env#corejs