cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not quote JSX attribute keys for IdentifierName (#8045)

Browse Source 
Given the following

```js
a = <F new/>
```

We used to generate:

```js
a = React.createElement(F, {"new": true})
```

but now we generate

```js
a = React.createElement(F, {new: true})
```

If you need to quote these (ie for ES3 you can use
transform-property-literals)
This commit is contained in:
Erik Arvidsson
2018-05-27 09:48:18 -07:00
committed by Justin Ridgewell
parent d45ee5e025
commit 7846eaebaa
7 changed files with 28 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/babel-helper-builder-react-jsx/src/index.js
View File

@@ -89,14 +89,14 @@ You can turn on the 'throwIfNamespace' flag to bypass this warning.`,
}
}
if (t.isValidIdentifier(node.name.name)) {
if (t.isJSXNamespacedName(node.name)) {
node.name = t.stringLiteral(
node.name.namespace.name + ":" + node.name.name.name,
);
} else if (esutils.keyword.isIdentifierNameES6(node.name.name)) {
node.name.type = "Identifier";
} else {
node.name = t.stringLiteral(
t.isJSXNamespacedName(node.name)
? node.name.namespace.name + ":" + node.name.name.name
: node.name.name,
);
node.name = t.stringLiteral(node.name.name);
}
return t.inherits(t.objectProperty(node.name, value), node);