cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add supports for polyfill computed methods (#10398)

Browse Source
This commit is contained in:
Bin Xin
2019-09-06 07:35:03 +08:00
committed by Nicolò Ribaudo
parent 5c859b1117
commit 8769903284
12 changed files with 107 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
packages/babel-plugin-transform-runtime/src/index.js
View File

@@ -130,6 +130,14 @@ export default declare((api, options, dirname) => {
return methods[name].types.some(name => name === type);
}
function resolvePropertyName(path, computed) {
const { node } = path;
if (!computed) return node.name;
if (path.isStringLiteral()) return node.value;
const result = path.evaluate();
return result.value;
}
if (has(options, "useBuiltIns")) {
if (options.useBuiltIns) {
throw new Error(
@@ -297,8 +305,11 @@ export default declare((api, options, dirname) => {
if (!t.isMemberExpression(callee)) return;
const { object, property } = callee;
const propertyName = property.name;
const { object } = callee;
const propertyName = resolvePropertyName(
path.get("callee.property"),
callee.computed,
);
// transform calling instance methods like `something.includes()`
if (injectCoreJS3 && !hasStaticMapping(object.name, propertyName)) {
@@ -375,29 +386,33 @@ export default declare((api, options, dirname) => {
if (!path.isReferenced()) return;
const { node } = path;
const { object, property } = node;
const { object } = node;
if (!t.isReferenced(object, node)) return;
if (node.computed) {
if (injectCoreJS2) return;
// transform `something[Symbol.iterator]` to calling `getIteratorMethod(something)` helper
if (path.get("property").matchesPattern("Symbol.iterator")) {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/core-js/get-iterator-method`,
"getIteratorMethod",
),
[object],
// transform `something[Symbol.iterator]` to calling `getIteratorMethod(something)` helper
if (
!injectCoreJS2 &&
node.computed &&
path.get("property").matchesPattern("Symbol.iterator")
) {
path.replaceWith(
t.callExpression(
this.addDefaultImport(
`${moduleName}/core-js/get-iterator-method`,
"getIteratorMethod",
),
);
}
[object],
),
);
return;
}
const objectName = object.name;
const propertyName = property.name;
const propertyName = resolvePropertyName(
path.get("property"),
node.computed,
);
// doesn't reference the global
if (
path.scope.getBindingIdentifier(objectName) ||