cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix auto import error with whitespace JSXText (#11354)

Browse Source
This commit is contained in:
Luna Ruan 2020-04-01 15:29:27 -07:00 committed by GitHub
parent df819a060c
commit 94447135c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 44 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/babel-helper-builder-react-jsx-experimental/src/index.js
View File

@ -303,12 +303,8 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
"JSXElement|JSXFragment"(path) {
if (path.type === "JSXFragment") imports.add("Fragment");
const openingPath = path.get("openingElement");
const validChildren = openingPath.parent.children.filter(
child =>
!t.isJSXEmptyExpression(child) &&
!(t.isJSXText(child) && child.value.trim() === ""),
);
const validChildren = t.react.buildChildren(openingPath.parent);
let importName;
if (path.type === "JSXElement" && shouldUseCreateElement(path)) {
importName = "createElement";

5
packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/input.js vendored Normal file
View File

@ -0,0 +1,5 @@
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
}
}

10
packages/babel-plugin-transform-react-jsx/test/fixtures/nextReact/weird-symbols/output.mjs vendored Normal file
View File

@ -0,0 +1,10 @@
import { jsxs as _jsxs } from "react/jsx-runtime";
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return /*#__PURE__*/_jsxs(Text, {
children: ["\xA0", this.props.value, "\xA0"]
});
}
}

7
packages/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/input.js vendored Normal file
View File

@ -0,0 +1,7 @@
/** @jsxRuntime classic */
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
}
}

7
packages/babel-plugin-transform-react-jsx/test/fixtures/nextReactClassic/weird-symbols/output.js vendored Normal file
View File

@ -0,0 +1,7 @@
/** @jsxRuntime classic */
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return /*#__PURE__*/React.createElement(Text, null, "\xA0", this.props.value, "\xA0");
}
}

7
packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/input.js vendored Normal file
View File

@ -0,0 +1,7 @@
/** @jsxRuntime classic */
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return <Text>&nbsp;{this.props.value}&nbsp;</Text>;
}
}

7
packages/babel-plugin-transform-react-jsx/test/fixtures/react/weird-symbols/output.js vendored Normal file
View File

@ -0,0 +1,7 @@
/** @jsxRuntime classic */
class MobileHomeActivityTaskPriorityIcon extends React.PureComponent {
render() {
return /*#__PURE__*/React.createElement(Text, null, "\xA0", this.props.value, "\xA0");
}
}