cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #6159 from jridgewell/pr/3701

Browse Source 
Allow native Symbols as computed property names
This commit is contained in:
Henry Zhu
2017-08-28 12:50:10 -06:00
committed by GitHub
parent ac6eda2709 7795750862
commit 95dd16aeeb
11 changed files with 60 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/babel-helpers/src/helpers.js
View File

@@ -278,6 +278,20 @@ helpers.defineEnumerableProperties = template(`
if ("value" in desc) desc.writable = true;
Object.defineProperty(obj, key, desc);
}
// Symbols are not enumerated over by for-in loops. If native
// Symbols are available, fetch all of the descs object's own
// symbol properties and define them on our target object too.
if (Object.getOwnPropertySymbols) {
var objectSymbols = Object.getOwnPropertySymbols(descs);
for (var i = 0; i < objectSymbols.length; i++) {
var sym = objectSymbols[i];
var desc = descs[sym];
desc.configurable = desc.enumerable = true;
if ("value" in desc) desc.writable = true;
Object.defineProperty(obj, sym, desc);
}
}
return obj;
})
`);

3
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/loose/ignore-symbol/actual.js vendored
View File

@@ -1,3 +0,0 @@
var foo = {
[Symbol.iterator]: "foobar"
};

3
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/loose/ignore-symbol/expected.js vendored
View File

@@ -1,3 +0,0 @@
var _foo;
var foo = (_foo = {}, _foo[Symbol.iterator] = "foobar", _foo);

7
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/loose/symbol/actual.js vendored Normal file
View File

@@ -0,0 +1,7 @@
var k = Symbol();
var foo = {
[Symbol.iterator]: "foobar",
get [k]() {
return k;
}
};

10
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/loose/symbol/exec.js vendored Normal file
View File

@@ -0,0 +1,10 @@
var k = Symbol();
var foo = {
[Symbol.iterator]: "foobar",
get [k]() {
return k;
}
};
assert(foo[Symbol.iterator], "foobar")
assert(foo[k], k)

6
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/loose/symbol/expected.js vendored Normal file
View File

@@ -0,0 +1,6 @@
var _foo, _mutatorMap;
var k = Symbol();
var foo = (_foo = {}, _foo[Symbol.iterator] = "foobar", _mutatorMap = {}, _mutatorMap[k] = _mutatorMap[k] || {}, _mutatorMap[k].get = function () {
return k;
}, babelHelpers.defineEnumerableProperties(_foo, _mutatorMap), _foo);

3
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/spec/ignore-symbol/actual.js vendored
View File

@@ -1,3 +0,0 @@
var foo = {
[Symbol.iterator]: "foobar"
};

1
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/spec/ignore-symbol/expected.js vendored
View File

@@ -1 +0,0 @@
var foo = babelHelpers.defineProperty({}, Symbol.iterator, "foobar");

7
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/spec/symbol/actual.js vendored Normal file
View File

@@ -0,0 +1,7 @@
var k = Symbol();
var foo = {
[Symbol.iterator]: "foobar",
get [k]() {
return k;
}
};

10
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/spec/symbol/exec.js vendored Normal file
View File

@@ -0,0 +1,10 @@
var k = Symbol();
var foo = {
[Symbol.iterator]: "foobar",
get [k]() {
return k;
}
};
assert(foo[Symbol.iterator], "foobar")
assert(foo[k], k)

6
packages/babel-plugin-transform-es2015-computed-properties/test/fixtures/spec/symbol/expected.js vendored Normal file
View File

@@ -0,0 +1,6 @@
var _foo, _mutatorMap;
var k = Symbol();
var foo = (_foo = {}, babelHelpers.defineProperty(_foo, Symbol.iterator, "foobar"), _mutatorMap = {}, _mutatorMap[k] = _mutatorMap[k] || {}, _mutatorMap[k].get = function () {
return k;
}, babelHelpers.defineEnumerableProperties(_foo, _mutatorMap), _foo);