cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do not remove "estree": null in ESLint tests

Browse Source
This commit is contained in:
Nicolò Ribaudo 2020-05-09 22:12:28 +02:00
parent c3a5bf1ff5
commit aeb51f463c
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
eslint/babel-eslint-parser/test/index.js
View File

@ -15,30 +15,27 @@ const PROPS_TO_REMOVE = [
"variance", "variance",
"typeArguments", "typeArguments",
]; ];
// We can remove needing to drop "exported" if null once this lands:
// https://github.com/acornjs/acorn/pull/889
const PROPS_TO_REMOVE_IF_NULL = ["exported"];
function deeplyRemoveProperties(obj, props, propsIfNull) { function deeplyRemoveProperties(obj, props) {
for (const [k, v] of Object.entries(obj)) { for (const [k, v] of Object.entries(obj)) {
if (typeof v === "object") { if (typeof v === "object") {
if (Array.isArray(v)) { if (Array.isArray(v)) {
for (const el of v) { for (const el of v) {
if (el != null) { if (el != null) {
deeplyRemoveProperties(el, props, propsIfNull); deeplyRemoveProperties(el, props);
} }
} }
} }
if (props.includes(k) || (propsIfNull.includes(k) && v === null)) { if (props.includes(k)) {
delete obj[k]; delete obj[k];
} else if (v != null) { } else if (v != null) {
deeplyRemoveProperties(v, props, propsIfNull); deeplyRemoveProperties(v, props);
} }
continue; continue;
} }
if (props.includes(k) || (propsIfNull.includes(k) && v === null)) { if (props.includes(k)) {
delete obj[k]; delete obj[k];
} }
} }
@ -72,7 +69,7 @@ describe("Babel and Espree", () => {
eslintScopeManager: true, eslintScopeManager: true,
babelOptions: BABEL_OPTIONS, babelOptions: BABEL_OPTIONS,
}).ast; }).ast;
deeplyRemoveProperties(babelAST, PROPS_TO_REMOVE, PROPS_TO_REMOVE_IF_NULL); deeplyRemoveProperties(babelAST, PROPS_TO_REMOVE);
expect(babelAST).toEqual(espreeAST); expect(babelAST).toEqual(espreeAST);
} }