cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

No unneeded empty arrays in transform spread (#6763)

Browse Source 
* No unneeded empty arrays in transform spread

Since Array.prototype.concat creates a new array from inputs, there's
no need to call it from a new empty array ([].concat()).

* [fixup] simplify detection of new array
This commit is contained in:
Anatoli Papirovski
2017-11-09 14:51:56 -05:00
committed by Henry Zhu
parent 617d35245f
commit aefbb1380e
7 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/babel-plugin-transform-spread/test/fixtures/spread/arguments-array/expected.js vendored
View File

@@ -1,5 +1,5 @@
function foo() {
return bar([].concat(Array.prototype.slice.call(arguments)));
return bar(Array.prototype.slice.call(arguments));
}
function bar(one, two, three) {

2
packages/babel-plugin-transform-spread/test/fixtures/spread/array-literal-first/expected.js vendored
View File

@@ -1 +1 @@
var lyrics = [].concat(babelHelpers.toConsumableArray(parts), ["head", "and", "toes"]);
var lyrics = babelHelpers.toConsumableArray(parts).concat(["head", "and", "toes"]);

2
packages/babel-plugin-transform-spread/test/fixtures/spread/known-rest/expected.js vendored
View File

@@ -3,5 +3,5 @@ function foo() {
bar[_key] = arguments[_key];
}
return [].concat(bar);
return bar.concat();
}

2
packages/babel-plugin-transform-spread/test/fixtures/spread/single/expected.js vendored
View File

@@ -1 +1 @@
[].concat(babelHelpers.toConsumableArray(foo));
babelHelpers.toConsumableArray(foo);