cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Separate finding peer deps from monkeypatching (babel/babel-eslint#460)

Browse Source
This commit is contained in:
Andres Suarez 2017-03-30 13:49:51 -04:00
parent 9a558bd942
commit b8a3af8cd6
1 changed files with 33 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
eslint/babel-eslint-parser/index.js
View File

@ -10,21 +10,10 @@ var codeFrame = require("babel-code-frame");
var hasPatched = false; var hasPatched = false;
var eslintOptions = {}; var eslintOptions = {};
function createModule(filename) { function getModules() {
var mod = new Module(filename);
mod.filename = filename;
mod.paths = Module._nodeModulePaths(path.dirname(filename));
return mod;
}
function monkeypatch() {
if (hasPatched) return;
hasPatched = true;
var eslintLoc;
try { try {
// avoid importing a local copy of eslint, try to find a peer dependency // avoid importing a local copy of eslint, try to find a peer dependency
eslintLoc = Module._resolveFilename("eslint", module.parent); var eslintLoc = Module._resolveFilename("eslint", module.parent);
} catch (err) { } catch (err) {
try { try {
// avoids breaking in jest where module.parent is undefined // avoids breaking in jest where module.parent is undefined
@ -35,18 +24,35 @@ function monkeypatch() {
} }
// get modules relative to what eslint will load // get modules relative to what eslint will load
var eslintMod = createModule(eslintLoc); var eslintMod = new Module(eslintLoc);
// ESLint v1.9.0 uses estraverse directly to work around https://github.com/npm/npm/issues/9663 eslintMod.filename = eslintLoc;
eslintMod.paths = Module._nodeModulePaths(path.dirname(eslintLoc));
var Definition = eslintMod.require("escope/lib/definition").Definition;
var escope = eslintMod.require("escope");
var estraverse = eslintMod.require("estraverse"); var estraverse = eslintMod.require("estraverse");
var referencer = eslintMod.require("escope/lib/referencer");
if (referencer.__esModule) referencer = referencer.default;
return {
Definition,
escope,
estraverse,
referencer,
};
}
function monkeypatch(modules) {
var Definition = modules.Definition;
var escope = modules.escope;
var estraverse = modules.estraverse;
var referencer = modules.referencer;
Object.assign(estraverse.VisitorKeys, t.VISITOR_KEYS); Object.assign(estraverse.VisitorKeys, t.VISITOR_KEYS);
estraverse.VisitorKeys.MethodDefinition.push("decorators"); estraverse.VisitorKeys.MethodDefinition.push("decorators");
estraverse.VisitorKeys.Property.push("decorators"); estraverse.VisitorKeys.Property.push("decorators");
// monkeypatch escope
var escopeLoc = Module._resolveFilename("escope", eslintMod);
var escopeMod = createModule(escopeLoc);
var escope = require(escopeLoc);
var analyze = escope.analyze; var analyze = escope.analyze;
escope.analyze = function (ast, opts) { escope.analyze = function (ast, opts) {
opts.ecmaVersion = eslintOptions.ecmaVersion; opts.ecmaVersion = eslintOptions.ecmaVersion;
@ -59,28 +65,6 @@ function monkeypatch() {
return results; return results;
}; };
// monkeypatch escope/referencer
var referencerLoc;
try {
referencerLoc = Module._resolveFilename("./referencer", escopeMod);
} catch (err) {
throw new ReferenceError("couldn't resolve escope/referencer");
}
var referencerMod = createModule(referencerLoc);
var referencer = require(referencerLoc);
if (referencer.__esModule) {
referencer = referencer.default;
}
// reference Definition
var definitionLoc;
try {
definitionLoc = Module._resolveFilename("./definition", referencerMod);
} catch (err) {
throw new ReferenceError("couldn't resolve escope/definition");
}
var Definition = require(definitionLoc).Definition;
// if there are decorators, then visit each // if there are decorators, then visit each
function visitDecorators(node) { function visitDecorators(node) {
if (!node.decorators) { if (!node.decorators) {
@ -368,12 +352,15 @@ exports.parse = function (code, options) {
delete eslintOptions.globalReturn; delete eslintOptions.globalReturn;
} }
if (!hasPatched) {
hasPatched = true;
try { try {
monkeypatch(); monkeypatch(getModules());
} catch (err) { } catch (err) {
console.error(err.stack); console.error(err.stack);
process.exit(1); process.exit(1);
} }
}
return exports.parseNoPatch(code, options); return exports.parseNoPatch(code, options);
}; };