add support for circular references and hoist all variable declarations

lib/6to5/transformation/modules/system.js

@@ -15,8 +15,13 @@ function SystemFormatter(file) {
 
 util.inherits(SystemFormatter, AMDFormatter);
 
-SystemFormatter.prototype._exportsWildcard = function (objectIdentifier) {
-  var leftIdentifier = t.identifier("i");
+SystemFormatter.prototype._addImportSource = function (node, exportNode) {
+  node._importSource = exportNode.source && exportNode.source.value;
+  return node;
+};
+
+SystemFormatter.prototype._exportsWildcard = function (objectIdentifier, node) {
+  var leftIdentifier = this.file.generateUidIdentifier("key");
   var valIdentifier  = t.memberExpression(objectIdentifier, leftIdentifier, true);
 
   var left = t.variableDeclaration("var", [
@@ -29,11 +34,12 @@ SystemFormatter.prototype._exportsWildcard = function (objectIdentifier) {
     this.buildExportCall(leftIdentifier, valIdentifier)
   ]);
 
-  return t.forInStatement(left, right, block);
+  return this._addImportSource(t.forInStatement(left, right, block), node);
 };
 
-SystemFormatter.prototype._exportsAssign = function (id, init) {
-  return this.buildExportCall(t.literal(id.name), init, true);
+SystemFormatter.prototype._exportsAssign = function (id, init, node) {
+  var call = this.buildExportCall(t.literal(id.name), init, true);
+  return this._addImportSource(call, node);
 };
 
 SystemFormatter.prototype.remapExportAssignment = function (node) {
@@ -49,28 +55,53 @@ SystemFormatter.prototype.buildExportCall = function (id, init, isStatement) {
   }
 };
 
-SystemFormatter.prototype.buildRunnerSetters = function () {
-  return t.arrayExpression(_.map(this.ids, function (uid) {
-    var moduleIdentifier = t.identifier("m");
+SystemFormatter.prototype.importSpecifier = function (specifier, node, nodes) {
+  AMDFormatter.prototype.importSpecifier.apply(this, arguments);
+  this._addImportSource(_.last(nodes), node);
+};
 
-    return t.functionExpression(null, [moduleIdentifier], t.blockStatement([
-      t.assignmentExpression("=", uid, moduleIdentifier)
-    ]));
+SystemFormatter.prototype.buildRunnerSetters = function (block, hoistDeclarators) {
+  return t.arrayExpression(_.map(this.ids, function (uid, source) {
+    var nodes = [];
+
+    traverse(block, {
+      enter: function (node) {
+        if (node._importSource === source) {
+          if (t.isVariableDeclaration(node)) {
+            _.each(node.declarations, function (declar) {
+              hoistDeclarators.push(t.variableDeclarator(declar.id));
+              nodes.push(t.expressionStatement(
+                t.assignmentExpression("=", declar.id, declar.init)
+              ));
+            });
+          } else {
+            nodes.push(node);
+          }
+
+          this.remove();
+        }
+      }
+    });
+
+    return t.functionExpression(null, [uid], t.blockStatement(nodes));
   }));
 };
 
 SystemFormatter.prototype.transform = function (ast) {
   var program = ast.program;
 
+  var hoistDeclarators = [];
   var moduleName = this.getModuleName();
   var moduleNameLiteral = t.literal(moduleName);
 
+  var block = t.blockStatement(program.body);
+
   var runner = util.template("system", {
     MODULE_NAME: moduleNameLiteral,
     MODULE_DEPENDENCIES: t.arrayExpression(this.buildDependencyLiterals()),
     EXPORT_IDENTIFIER: this.exportIdentifier,
-    SETTERS: this.buildRunnerSetters(),
-    EXECUTE: t.functionExpression(null, [], t.blockStatement(program.body))
+    SETTERS: this.buildRunnerSetters(block, hoistDeclarators),
+    EXECUTE: t.functionExpression(null, [], block)
   }, true);
 
   var handlerBody = runner.expression.arguments[2].body.body;
@@ -78,8 +109,55 @@ SystemFormatter.prototype.transform = function (ast) {
 
   var returnStatement = handlerBody.pop();
 
+  // hoist up all variable declarations
+  traverse(block, {
+    enter: function (node, parent, scope) {
+      if (t.isFunction(node)) {
+        // nothing inside is accessible
+        return this.stop();
+      }
+
+      if (t.isVariableDeclaration(node)) {
+        if (node.kind !== "var" && !t.isProgram(parent)) { // let, const
+          // can't be accessed
+          return;
+        }
+
+        var nodes = [];
+
+        _.each(node.declarations, function (declar) {
+          hoistDeclarators.push(t.variableDeclarator(declar.id));
+          if (declar.init) {
+            // no initializer so we can just hoist it as-is
+            var assign = t.expressionStatement(t.assignmentExpression("=", declar.id, declar.init));
+            nodes.push(assign);
+          }
+        });
+
+        // for (var i in test)
+        // for (var i = 0;;)
+        if (t.isFor(parent)) {
+          if (parent.left === node) {
+            return node.declarations[0].id;
+          }
+
+          if (parent.init === node) {
+            return t.toSequenceExpression(nodes, scope);
+          }
+        }
+
+        return nodes;
+      }
+    }
+  });
+  if (hoistDeclarators.length) {
+    var hoistDeclar = t.variableDeclaration("var", hoistDeclarators);
+    hoistDeclar._blockHoist = true;
+    handlerBody.unshift(hoistDeclar);
+  }
+
   // hoist up function declarations for circular references
-  traverse(program, {
+  traverse(block, {
     enter: function (node) {
       if (t.isFunction(node)) this.stop();
 
@@ -90,12 +168,6 @@ SystemFormatter.prototype.transform = function (ast) {
     }
   });
 
-  if (!_.isEmpty(this.ids)) {
-    handlerBody.push(t.variableDeclaration("var", _.map(this.ids, function (uid) {
-      return t.variableDeclarator(uid);
-    })));
-  }
-
   handlerBody.push(returnStatement);
 
   program.body = [runner];