From 199a61213118e8d0f58c8affbe44fd99abe69fc1 Mon Sep 17 00:00:00 2001 From: Sam Pepose Date: Wed, 22 Jun 2016 20:33:43 -0700 Subject: [PATCH 1/2] Fixed incorrect printing of array of nullable flow type --- packages/babel-generator/src/generators/flow.js | 6 +----- .../test/fixtures/flow/type-annotations/actual.js | 1 + .../test/fixtures/flow/type-annotations/expected.js | 1 + 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/babel-generator/src/generators/flow.js b/packages/babel-generator/src/generators/flow.js index b93435ccf5..eb4845ce1c 100644 --- a/packages/babel-generator/src/generators/flow.js +++ b/packages/babel-generator/src/generators/flow.js @@ -236,11 +236,7 @@ export function TypeParameter(node: Object) { export function TypeParameterInstantiation(node: Object) { this.token("<"); - this.printList(node.params, node, { - iterator: (node: Object) => { - this.print(node.typeAnnotation, node); - } - }); + this.printList(node.params, node, {}); this.token(">"); } diff --git a/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js b/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js index 4797cf488e..6e19091cf1 100644 --- a/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js +++ b/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js @@ -100,3 +100,4 @@ export type { foo }; export type { foo } from "bar"; export interface foo { p: number }; export interface foo { p: T }; +var a: ?Array diff --git a/packages/babel-generator/test/fixtures/flow/type-annotations/expected.js b/packages/babel-generator/test/fixtures/flow/type-annotations/expected.js index 01e4dde409..dd087046a5 100644 --- a/packages/babel-generator/test/fixtures/flow/type-annotations/expected.js +++ b/packages/babel-generator/test/fixtures/flow/type-annotations/expected.js @@ -104,3 +104,4 @@ export type { foo }; export type { foo } from "bar"; export interface foo { p: number }; export interface foo { p: T }; +var a: ?Array; From 7d83147e1603473a4d896721147e74875493f3f7 Mon Sep 17 00:00:00 2001 From: Sam Pepose Date: Wed, 22 Jun 2016 21:21:53 -0700 Subject: [PATCH 2/2] Added semicolon --- .../test/fixtures/flow/type-annotations/actual.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js b/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js index 6e19091cf1..7410326dea 100644 --- a/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js +++ b/packages/babel-generator/test/fixtures/flow/type-annotations/actual.js @@ -100,4 +100,4 @@ export type { foo }; export type { foo } from "bar"; export interface foo { p: number }; export interface foo { p: T }; -var a: ?Array +var a: ?Array;