cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix default exported classes without a name (#4518)

Browse Source 
* fix default exported classes without a name

This correctly requeues class without name so the es3 transform can
transform the default keyword.

* Replace phabricator issue number with github
This commit is contained in:
Daniel Tschinder
2016-09-18 04:50:54 +02:00
committed by Henry Zhu
parent 590ad4d24f
commit cbbc1c7333
13 changed files with 65 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/babel-plugin-transform-es2015-modules-commonjs/src/index.js
View File

@@ -267,13 +267,18 @@ export default function () {
]);
} else {
path.replaceWith(buildExportsAssignment(defNode, t.toExpression(declaration.node)));
// Manualy re-queue `export default class {}` expressions so that the ES3 transform
// has an opportunity to convert them. Ideally this would happen automatically from the
// replaceWith above. See #4140 for more info.
path.parentPath.requeue(path.get("expression.left"));
}
} else {
path.replaceWith(buildExportsAssignment(t.identifier("default"), declaration.node));
// Manualy re-queue `export default foo;` expressions so that the ES3 transform
// has an opportunity to convert them. Ideally this would happen automatically from the
// replaceWith above. See T7166 for more info.
// replaceWith above. See #4140 for more info.
path.parentPath.requeue(path.get("expression.left"));
}
exportDefaultFound = true;

1
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-class/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
export default class {}

6
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-class/expected.js vendored Normal file
View File

@@ -0,0 +1,6 @@
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports["default"] = class {};

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-class/options.json vendored Normal file
View File

@@ -0,0 +1,7 @@
{
"plugins": [
"transform-es2015-modules-commonjs",
"transform-es3-member-expression-literals",
"transform-es3-property-literals"
]
}

1
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-function/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
export default function () {}

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-function/expected.js vendored Normal file
View File

@@ -0,0 +1,7 @@
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports["default"] = function () {};

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-function/options.json vendored Normal file
View File

@@ -0,0 +1,7 @@
{
"plugins": [
"transform-es2015-modules-commonjs",
"transform-es3-member-expression-literals",
"transform-es3-property-literals"
]
}

1
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-class/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
export default class Foo {}

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-class/expected.js vendored Normal file
View File

@@ -0,0 +1,7 @@
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
class Foo {}
exports["default"] = Foo;

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-class/options.json vendored Normal file
View File

@@ -0,0 +1,7 @@
{
"plugins": [
"transform-es2015-modules-commonjs",
"transform-es3-member-expression-literals",
"transform-es3-property-literals"
]
}

1
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-function/actual.js vendored Normal file
View File

@@ -0,0 +1 @@
export default function bat () {}

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-function/expected.js vendored Normal file
View File

@@ -0,0 +1,7 @@
"use strict";
Object.defineProperty(exports, "__esModule", {
value: true
});
exports["default"] = bat;
function bat() {}

7
packages/babel-plugin-transform-es2015-modules-commonjs/test/fixtures/regression/es3-compatibility-named-function/options.json vendored Normal file
View File

@@ -0,0 +1,7 @@
{
"plugins": [
"transform-es2015-modules-commonjs",
"transform-es3-member-expression-literals",
"transform-es3-property-literals"
]
}