From d60802bf732d0ec55543c36b958229f38a9d7a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Wed, 18 Mar 2020 20:55:38 -0400 Subject: [PATCH] fix: object-rest-spread should not transform array rest (#11282) --- packages/babel-plugin-proposal-object-rest-spread/src/index.js | 2 +- .../test/fixtures/object-rest/export/input.mjs | 2 +- .../test/fixtures/object-rest/export/output.mjs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/babel-plugin-proposal-object-rest-spread/src/index.js b/packages/babel-plugin-proposal-object-rest-spread/src/index.js index 7f0d2525fb..4fcd3c1be6 100644 --- a/packages/babel-plugin-proposal-object-rest-spread/src/index.js +++ b/packages/babel-plugin-proposal-object-rest-spread/src/index.js @@ -329,7 +329,7 @@ export default declare((api, opts) => { const hasRest = declaration .get("declarations") - .some(path => hasRestElement(path.get("id"))); + .some(path => hasObjectPatternRestElement(path.get("id"))); if (!hasRest) return; const specifiers = []; diff --git a/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/input.mjs b/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/input.mjs index 5f0d8f6067..47c63cdcdd 100644 --- a/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/input.mjs +++ b/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/input.mjs @@ -2,4 +2,4 @@ export var { b, ...c } = asdf2; // Skip export var { bb, cc } = ads; -export var [ dd, ee ] = ads; +export var [ dd, ee, ...ff ] = ads; diff --git a/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/output.mjs b/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/output.mjs index fec0e7836e..428fb62c86 100644 --- a/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/output.mjs +++ b/packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-rest/export/output.mjs @@ -9,4 +9,4 @@ export var { bb, cc } = ads; -export var [dd, ee] = ads; +export var [dd, ee, ...ff] = ads;