fix: parser strictMode option (#13548)

This commit is contained in:
overlookmotel 2021-07-20 15:42:04 +01:00 committed by GitHub
parent 2c6db56696
commit dd942f92af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 64 additions and 1 deletions

View File

@ -33,7 +33,11 @@ export default class State {
init(options: Options): void {
this.strict =
options.strictMode === false ? false : options.sourceType === "module";
options.strictMode === false
? false
: options.strictMode === true
? true
: options.sourceType === "module";
this.curLine = options.startLine;
this.startLoc = this.endLoc = this.curPosition();

View File

@ -0,0 +1,59 @@
import { parse } from "../lib";
describe("options", () => {
describe("strictMode", () => {
const CODE = "function f(x, x) {}";
function expectToSucceed(opts) {
expect(parse(CODE, opts).program.body[0]).toMatchObject({
type: "FunctionDeclaration",
id: { type: "Identifier", name: "f" },
generator: false,
async: false,
params: [
{ type: "Identifier", name: "x" },
{ type: "Identifier", name: "x" },
],
body: {
type: "BlockStatement",
body: [],
directives: [],
},
});
}
function expectToFail(opts) {
expect(() => parse(CODE, opts)).toThrow(
new SyntaxError("Argument name clash. (1:14)"),
);
}
describe("sourceType module", () => {
it("default parses as strict mode", () => {
expectToFail({ sourceType: "module" });
});
it("false parses as sloppy mode", () => {
expectToSucceed({ sourceType: "module", strictMode: false });
});
it("true parses as strict mode", () => {
expectToFail({ sourceType: "module", strictMode: true });
});
});
describe("sourceType script", () => {
it("default parses as sloppy mode", () => {
expectToSucceed({ sourceType: "script" });
});
it("false parses as sloppy mode", () => {
expectToSucceed({ sourceType: "script", strictMode: false });
});
it("true parses as strict mode", () => {
expectToFail({ sourceType: "script", strictMode: true });
});
});
});
});