From ee397ff1074184a78fc78bc599cc2e4af66e61c8 Mon Sep 17 00:00:00 2001 From: Thiago Arrais Date: Mon, 12 Aug 2019 12:32:31 -0300 Subject: [PATCH] Adds note about two approval policy to PR template (#10313) * Adds note about two approval policy to PR template * Adds qualifier to approval policy Because, although two approvals is the general case, some PRs maybe merged with more or fewer approvals [skip ci] --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e5a78bd654..a45e7ae92c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,8 @@ Before making a PR, please read our contributing guidelines https://github.com/babel/babel/blob/master/CONTRIBUTING.md +Please note that the Babel Team requires two approvals before merging most PRs. + For issue references: Add a comma-separated list of a [closing word](https://help.github.com/articles/closing-issues-via-commit-messages/) followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly) If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website