cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Dedupe code when calling buildOptimizedSequenceExpression (#13535)

Browse Source
This commit is contained in:
Mickey Rose 2021-07-09 15:37:41 +02:00 committed by GitHub
parent 234316161f
commit f639eee2f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/babel-plugin-proposal-pipeline-operator/src/buildOptimizedSequenceExpression.js
View File

@ -1,12 +1,17 @@
import { types as t } from "@babel/core";
// tries to optimize sequence expressions in the format
// (a = b, ((c) => d + e)(a))
// (a = b, (c => c + e)(a))
// to
// (a = b, a + e)
const buildOptimizedSequenceExpression = ({ assign, call, path }) => {
const { left: placeholderNode, right: pipelineLeft } = assign;
const buildOptimizedSequenceExpression = ({ call, path, placeholder }) => {
const { callee: calledExpression } = call;
const pipelineLeft = path.node.left;
const assign = t.assignmentExpression(
"=",
t.cloneNode(placeholder),
pipelineLeft,
);
let optimizeArrow =
t.isArrowFunctionExpression(calledExpression) &&
@ -30,7 +35,7 @@ const buildOptimizedSequenceExpression = ({ assign, call, path }) => {
call.callee = evalSequence;
path.scope.push({ id: t.cloneNode(placeholderNode) });
path.scope.push({ id: t.cloneNode(placeholder) });
return t.sequenceExpression([assign, call]);
}
@ -40,10 +45,10 @@ const buildOptimizedSequenceExpression = ({ assign, call, path }) => {
return t.sequenceExpression([pipelineLeft, calledExpression.body]);
}
path.scope.push({ id: t.cloneNode(placeholderNode) });
path.scope.push({ id: t.cloneNode(placeholder) });
if (param) {
path.get("right").scope.rename(param.name, placeholderNode.name);
path.get("right").scope.rename(param.name, placeholder.name);
return t.sequenceExpression([assign, calledExpression.body]);
}

2
packages/babel-plugin-proposal-pipeline-operator/src/fsharpVisitor.js
View File

@ -14,7 +14,7 @@ const fsharpVisitor = {
? t.awaitExpression(t.cloneNode(placeholder))
: t.callExpression(right, [t.cloneNode(placeholder)]);
const sequence = buildOptimizedSequenceExpression({
assign: t.assignmentExpression("=", t.cloneNode(placeholder), left),
placeholder,
call,
path,
});

2
packages/babel-plugin-proposal-pipeline-operator/src/minimalVisitor.js
View File

@ -12,7 +12,7 @@ const minimalVisitor = {
const call = t.callExpression(right, [t.cloneNode(placeholder)]);
path.replaceWith(
buildOptimizedSequenceExpression({
assign: t.assignmentExpression("=", t.cloneNode(placeholder), left),
placeholder,
call,
path,
}),