cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix: lost leading comment after named import (#10901)

Browse Source 
* create test for 10892

* update expected output

* fixed #10892

* add colon to restart build

* remove colon as it makes tests fail
This commit is contained in:
Barthélémy Ledoux 2019-12-22 03:22:28 -06:00 committed by Nicolò Ribaudo
parent 416ce35638
commit f651f22f96
4 changed files with 219 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/babel-parser/src/parser/comments.js
View File

@ -174,11 +174,9 @@ export default class CommentsParser extends BaseParser {
(this.state.commentPreviousNode.type === "ExportSpecifier" && (this.state.commentPreviousNode.type === "ExportSpecifier" &&
node.type !== "ExportSpecifier")) node.type !== "ExportSpecifier"))
) { ) {
this.adjustCommentsAfterTrailingComma( this.adjustCommentsAfterTrailingComma(node, [
node, this.state.commentPreviousNode,
[this.state.commentPreviousNode], ]);
true,
);
} }
if (lastChild) { if (lastChild) {

7
packages/babel-parser/test/fixtures/comments/regression/10892/input.js vendored Normal file
View File

@ -0,0 +1,7 @@
import { foo } from "bar"
/**
* lost comment
*/
export default {
}

3
packages/babel-parser/test/fixtures/comments/regression/10892/options.json vendored Normal file
View File

@ -0,0 +1,3 @@
{
"sourceType": "module"
}

206
packages/babel-parser/test/fixtures/comments/regression/10892/output.json vendored Normal file
View File

@ -0,0 +1,206 @@
{
"type": "File",
"start": 0,
"end": 69,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 7,
"column": 1
}
},
"program": {
"type": "Program",
"start": 0,
"end": 69,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 7,
"column": 1
}
},
"sourceType": "module",
"interpreter": null,
"body": [
{
"type": "ImportDeclaration",
"start": 0,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 0
},
"end": {
"line": 1,
"column": 25
}
},
"specifiers": [
{
"type": "ImportSpecifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
}
},
"imported": {
"type": "Identifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "foo"
},
"name": "foo"
},
"local": {
"type": "Identifier",
"start": 9,
"end": 12,
"loc": {
"start": {
"line": 1,
"column": 9
},
"end": {
"line": 1,
"column": 12
},
"identifierName": "foo"
},
"name": "foo"
}
}
],
"source": {
"type": "StringLiteral",
"start": 20,
"end": 25,
"loc": {
"start": {
"line": 1,
"column": 20
},
"end": {
"line": 1,
"column": 25
}
},
"extra": {
"rawValue": "bar",
"raw": "\"bar\""
},
"value": "bar"
},
"trailingComments": [
{
"type": "CommentBlock",
"value": "*\n * lost comment\n ",
"start": 27,
"end": 50,
"loc": {
"start": {
"line": 3,
"column": 0
},
"end": {
"line": 5,
"column": 3
}
}
}
]
},
{
"type": "ExportDefaultDeclaration",
"start": 51,
"end": 69,
"loc": {
"start": {
"line": 6,
"column": 0
},
"end": {
"line": 7,
"column": 1
}
},
"declaration": {
"type": "ObjectExpression",
"start": 66,
"end": 69,
"loc": {
"start": {
"line": 6,
"column": 15
},
"end": {
"line": 7,
"column": 1
}
},
"properties": []
},
"leadingComments": [
{
"type": "CommentBlock",
"value": "*\n * lost comment\n ",
"start": 27,
"end": 50,
"loc": {
"start": {
"line": 3,
"column": 0
},
"end": {
"line": 5,
"column": 3
}
}
}
]
}
],
"directives": []
},
"comments": [
{
"type": "CommentBlock",
"value": "*\n * lost comment\n ",
"start": 27,
"end": 50,
"loc": {
"start": {
"line": 3,
"column": 0
},
"end": {
"line": 5,
"column": 3
}
}
}
]
}