From f6ff14624f20f78c0ec8314635fe2f641a5a0bfe Mon Sep 17 00:00:00 2001 From: Amjad Masad Date: Wed, 16 Mar 2016 17:42:18 -0700 Subject: [PATCH] localize side-effectful test --- packages/babel-core/test/api.js | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/packages/babel-core/test/api.js b/packages/babel-core/test/api.js index f00636ebd2..2c75c9e753 100644 --- a/packages/babel-core/test/api.js +++ b/packages/babel-core/test/api.js @@ -432,46 +432,54 @@ suite("api", function () { var oldBabelEnv = process.env.BABEL_ENV; var oldNodeEnv = process.env.NODE_ENV; - before(function () { + + // This this a global side effect and we need to make sure it's localized + // to every test below. + function before() { delete process.env.BABEL_ENV; delete process.env.NODE_ENV; - }); + } - after(function () { + + afterEach(function () { process.env.BABEL_ENV = oldBabelEnv; process.env.NODE_ENV = oldNodeEnv; }); test("default", function () { - return transformAsync("foo;", { + before(); + + var result = babel.transform("foo;", { env: { development: { code: false } } - }).then(function (result) { - assert.equal(result.code, undefined); }); + + assert.equal(result.code, undefined); }); test("BABEL_ENV", function () { + before(); + process.env.BABEL_ENV = "foo"; - return transformAsync("foo;", { + var result = babel.transform("foo;", { env: { foo: { code: false } } - }).then(function (result) { - assert.equal(result.code, undefined); }); + assert.equal(result.code, undefined); }); test("NODE_ENV", function () { + before(); + process.env.NODE_ENV = "foo"; - return transformAsync("foo;", { + var result = babel.transform("foo;", { env: { foo: { code: false } } - }).then(function (result) { - assert.equal(result.code, undefined); }); + assert.equal(result.code, undefined); }); });