[babel 8] Remove useSpread and useBuiltIns jsx options (#12593)

* [babel 8] Remove `useSpread` and `useBuiltIns` jsx options

backport of 8cc8696851fa4bf02d7f6ae591404626d1ca32a3

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Brian Ng <bng412@gmail.com>

* Update fixtures (Windows)

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Babel Bot <babel-bot@users.noreply.github.com>

packages/babel-plugin-transform-react-jsx/test/fixtures/react/adds-appropriate-newlines-when-using-spread-attribute-babel-7/input.js

@@ -0,0 +1,3 @@
+<Component
+  {...props}
+  sound="moo" />

packages/babel-plugin-transform-react-jsx/test/fixtures/react/adds-appropriate-newlines-when-using-spread-attribute-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/adds-appropriate-newlines-when-using-spread-attribute-babel-7/output.js

@@ -0,0 +1,4 @@
+/*#__PURE__*/
+React.createElement(Component, babelHelpers.extends({}, props, {
+  sound: "moo"
+}));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/adds-appropriate-newlines-when-using-spread-attribute/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/adds-appropriate-newlines-when-using-spread-attribute/output.js

@@ -1,4 +1,4 @@
 /*#__PURE__*/
-React.createElement(Component, babelHelpers.extends({}, props, {
+React.createElement(Component, { ...props,
   sound: "moo"
-}));
+});

packages/babel-plugin-transform-react-jsx/test/fixtures/react/assignment-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/assignment-babel-7/output.js

@@ -0,0 +1,3 @@
+var div = /*#__PURE__*/React.createElement(Component, babelHelpers.extends({}, props, {
+  foo: "bar"
+}));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/assignment/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/assignment/output.js

@@ -1,3 +1,3 @@
-var div = /*#__PURE__*/React.createElement(Component, babelHelpers.extends({}, props, {
+var div = /*#__PURE__*/React.createElement(Component, { ...props,
   foo: "bar"
-}));
+});

packages/babel-plugin-transform-react-jsx/test/fixtures/react/avoids-spread-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/does-not-add-source-self-babel-7/input.mjs

@@ -0,0 +1,10 @@
+var x = (
+  <>
+  <div>
+      <div key="1" />
+      <div key="2" meow="wolf" />
+      <div key="3" />
+      <div {...props} key="4" />
+  </div>
+  </>
+);

packages/babel-plugin-transform-react-jsx/test/fixtures/react/does-not-add-source-self-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/does-not-add-source-self-babel-7/output.mjs

@@ -0,0 +1,10 @@
+var x = /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/React.createElement("div", null, /*#__PURE__*/React.createElement("div", {
+  key: "1"
+}), /*#__PURE__*/React.createElement("div", {
+  key: "2",
+  meow: "wolf"
+}), /*#__PURE__*/React.createElement("div", {
+  key: "3"
+}), /*#__PURE__*/React.createElement("div", babelHelpers.extends({}, props, {
+  key: "4"
+}))));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/does-not-add-source-self/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/does-not-add-source-self/output.mjs

@@ -5,6 +5,6 @@ var x = /*#__PURE__*/React.createElement(React.Fragment, null, /*#__PURE__*/Reac
   meow: "wolf"
 }), /*#__PURE__*/React.createElement("div", {
   key: "3"
-}), /*#__PURE__*/React.createElement("div", babelHelpers.extends({}, props, {
+}), /*#__PURE__*/React.createElement("div", { ...props,
   key: "4"
-}))));
+})));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-first-spread-attributes-babel-7/input.js

@@ -0,0 +1,2 @@
+<Component { ... x } y
+={2 } z />

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-first-spread-attributes-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-first-spread-attributes-babel-7/output.js

@@ -0,0 +1,5 @@
+/*#__PURE__*/
+React.createElement(Component, babelHelpers.extends({}, x, {
+  y: 2,
+  z: true
+}));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-first-spread-attributes/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-first-spread-attributes/output.js

@@ -1,5 +1,5 @@
 /*#__PURE__*/
-React.createElement(Component, babelHelpers.extends({}, x, {
+React.createElement(Component, { ...x,
   y: 2,
   z: true
-}));
+});

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-last-spread-attributes-babel-7/input.js

@@ -0,0 +1 @@
+<Component y={2} z { ... x } />

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-last-spread-attributes-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-last-spread-attributes-babel-7/output.js

@@ -0,0 +1,5 @@
+/*#__PURE__*/
+React.createElement(Component, babelHelpers.extends({
+  y: 2,
+  z: true
+}, x));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-last-spread-attributes/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-last-spread-attributes/output.js

@@ -1,5 +1,6 @@
 /*#__PURE__*/
-React.createElement(Component, babelHelpers.extends({
+React.createElement(Component, {
   y: 2,
-  z: true
-}, x));
+  z: true,
+  ...x
+});

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-middle-spread-attributes-babel-7/input.js

@@ -0,0 +1 @@
+<Component y={2} { ... x } z />

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-middle-spread-attributes-babel-7/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": false
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-middle-spread-attributes-babel-7/output.js

@@ -0,0 +1,6 @@
+/*#__PURE__*/
+React.createElement(Component, babelHelpers.extends({
+  y: 2
+}, x, {
+  z: true
+}));

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-middle-spread-attributes/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/react/wraps-props-in-react-spread-for-middle-spread-attributes/output.js

@@ -1,6 +1,6 @@
 /*#__PURE__*/
-React.createElement(Component, babelHelpers.extends({
-  y: 2
-}, x, {
+React.createElement(Component, {
+  y: 2,
+  ...x,
   z: true
-}));
+});

packages/babel-plugin-transform-react-jsx/test/fixtures/removed-options/invalid-use-builtins-false/options.json

@@ -0,0 +1,5 @@
+{
+  "BABEL_8_BREAKING": true,
+  "plugins": [["transform-react-jsx", { "useBuiltIns": false }]],
+  "throws": "@babel/plugin-transform-react-jsx: Since \"useBuiltIns\" is removed in Babel 8, you can remove it from the config."
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/removed-options/invalid-use-builtins-true/options.json

@@ -0,0 +1,5 @@
+{
+  "BABEL_8_BREAKING": true,
+  "plugins": [["transform-react-jsx", { "useBuiltIns": true }]],
+  "throws": "@babel/plugin-transform-react-jsx: Since \"useBuiltIns\" is removed in Babel 8, you can remove it from the config."
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/removed-options/invalid-use-spread-false/options.json

@@ -0,0 +1,5 @@
+{
+  "BABEL_8_BREAKING": true,
+  "plugins": [["transform-react-jsx", { "useSpread": false }]],
+  "throws": "transform-react-jsx: Since Babel 8, an inline object with spread elements is always used, and the \"useSpread\" option is no longer available. Please remove it from your config."
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/removed-options/invalid-use-spread-true/options.json

@@ -0,0 +1,5 @@
+{
+  "BABEL_8_BREAKING": true,
+  "plugins": [["transform-react-jsx", { "useSpread": true }]],
+  "throws": "transform-react-jsx: Since Babel 8, an inline object with spread elements is always used, and the \"useSpread\" option is no longer available. Please remove it from your config."
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/options.json

@@ -0,0 +1,3 @@
+{
+  "BABEL_8_BREAKING": true
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/transform-to-babel-extend/input.js

@@ -0,0 +1 @@
+var div = <Component {...props} foo="bar" />

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/transform-to-babel-extend/options.json

@@ -0,0 +1,6 @@
+{
+  "plugins": ["transform-react-jsx", ["proposal-object-rest-spread", {
+    "loose": true,
+    "useBuiltIns": false
+  }], "external-helpers"]
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/transform-to-babel-extend/output.js

@@ -0,0 +1,3 @@
+var div = /*#__PURE__*/React.createElement(Component, babelHelpers.extends({}, props, {
+  foo: "bar"
+}));

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/transform-to-object-assign/input.js

@@ -0,0 +1 @@
+var div = <Component {...props} foo="bar" />

packages/babel-plugin-transform-react-jsx/test/fixtures/spread-transform/transform-to-object-assign/options.json

@@ -0,0 +1,6 @@
+{
+  "plugins": ["transform-react-jsx", ["proposal-object-rest-spread", {
+    "loose": true,
+    "useBuiltIns": true
+  }]]
+}

packages/babel-plugin-transform-react-jsx/test/fixtures/useBuiltIns/assignment-invalid-option/options.json

@@ -1,4 +0,0 @@
-{
-  "plugins": [["transform-react-jsx", { "useBuiltIns": "invalidOption" }]],
-  "throws": "transform-react-jsx currently only accepts a boolean option for useBuiltIns (defaults to false)"
-}

packages/babel-plugin-transform-react-jsx/test/fixtures/useBuiltIns/options.json

@@ -1,3 +0,0 @@
-{
-  "plugins": [["transform-react-jsx", { "useBuiltIns": true }]]
-}

packages/babel-plugin-transform-react-jsx/test/fixtures/useSpread/assignment-invalid-option/options.json

@@ -1,4 +0,0 @@
-{
-  "plugins": [["transform-react-jsx", { "useSpread": 0 }]],
-  "throws": "transform-react-jsx currently only accepts a boolean option for useSpread (defaults to false)"
-}

packages/babel-plugin-transform-react-jsx/test/fixtures/useSpread/assignment-use-builtin/options.json

@@ -1,6 +0,0 @@
-{
-  "plugins": [
-    ["transform-react-jsx", { "useSpread": true, "useBuiltIns": true }]
-  ],
-  "throws": "transform-react-jsx currently only accepts useBuiltIns or useSpread but not both"
-}

packages/babel-plugin-transform-react-jsx/test/fixtures/useSpread/assignment/output.js

@@ -1,3 +0,0 @@
-var div = /*#__PURE__*/React.createElement(Component, { ...props,
-  foo: "bar"
-});

packages/babel-plugin-transform-react-jsx/test/fixtures/useSpread/options.json

@@ -1,3 +0,0 @@
-{
-  "plugins": [["transform-react-jsx", { "useSpread": true }]]
-}