Justin Ridgewell
852348d700
Fix default parameter - rest parameter edge case ( #3572 )
...
When the rest parameter shared the same name as a default identifier
for a param, the loop would be hoisted outside the function!
```js
var a = 1;
for (var _len = arguments.length, a = Array(_len > 1 ? _len - 1 : 0),
_key = 1; _key < _len; _key++) {
a[_key - 1] = arguments[_key];
}
function foo2() {
var b = arguments.length <= 0 || arguments[0] === undefined ? a :
arguments[0];
assert.equal(b, 1);
}
foo2(undefined, 2);
```
And if you tried to reference any index or `#length`, it’d blow up and
refuse to transpile.
2016-12-16 10:53:52 -05:00
Brian Ng
dfe896dd54
Avoid unnecessary +0 in transform-es2015-parameters ( #4738 )
2016-10-17 17:09:55 +02:00
Moti Zilberman
0366d1ad19
Handle side effects correctly in rest params index expressions ( #4348 ) ( #4674 )
2016-10-05 21:59:41 +02:00
Daniel Tschinder
16716ea3de
Fix rest parameters with flow type casting ( #4636 )
...
Do not skip TypeCastExpressions when finding referenced identifiers as the
type cast contains valid non flow code that we need to visit.
2016-10-01 12:58:14 -04:00
Justin Ridgewell
823ffbd87c
Fix error in rest parameter length optimization ( #3573 )
...
If there aren’t enough arguments to get to the offset index, we would
return an negative length.
2016-07-12 21:12:45 -04:00
Jay Phelps
330071e59d
also visit ClassProperty's for rest param deopt check, fixes #T7311 ( #3481 )
2016-05-13 17:18:14 -04:00
Jesse McCarthy
49e30f49bc
Fix rest optimization errors.
2016-02-25 18:42:52 -05:00
Victor Felder
183fbab967
Fix some rest optimization errors.
...
Commit message edited by @jmm.
2016-02-25 17:11:19 -05:00
Jesse McCarthy
3b8c5b7620
Merge pull request #3249 from jmm/rest-assign-el
...
Fix assignment to rest param element AST error.
Fix T6932.
2016-02-19 08:47:17 -05:00
Sebastian McKenzie
5b89849f43
Switch to klint, fix some lint rules
2016-02-14 23:25:14 +00:00
Jesse McCarthy
19937573a6
Fix assignment to rest param element.
2016-01-14 13:21:47 -05:00
Jesse McCarthy
b17965ab8b
Improve comments.
2016-01-13 17:24:06 -05:00
Jesse McCarthy
059d7123db
Remove unnecessary else.
2016-01-13 17:24:06 -05:00
Jesse McCarthy
e4044062c3
Remove unnecessary length check & nesting.
2016-01-13 17:24:06 -05:00
Jesse McCarthy
4c69f1cda5
Replace func expr with arrow.
2016-01-13 17:24:06 -05:00
Jesse McCarthy
afd98ebd2a
Remove unnecessary literal return value.
2016-01-13 17:24:06 -05:00
Jesse McCarthy
bcfa58a6a2
Remove unnecessary intermediate var.
2016-01-13 17:24:06 -05:00
Amjad Masad
59ea034df2
Support expressions in rest arg access
...
The current implementation assumes a numeric literal although it just
checks the base type.
2016-01-06 17:07:05 -08:00
Fabio M. Costa
699868ed2a
[fix][babel-plugin-transform-es2015-parameters] arguments.length optimization bugfix
2015-12-28 21:56:49 -08:00
Victor Felder
5d414a2323
Handle case where optimisation concist of only replacing rest param id with args
2015-12-18 17:43:00 +01:00
Victor Felder
6cc0538d2f
Safely transform all usages of rest arguments
2015-12-18 11:30:48 +01:00
Victor Felder
2dea8b2352
Safely transform multiple rest arguments
2015-12-18 11:30:48 +01:00
Victor Felder
3dfb4eb8c6
Simplify rest transformation
2015-12-18 11:30:48 +01:00
Fabio M. Costa
3868d36e31
[babel-plugin-transform-es2015-parameters] more oportunities for optimisations
2015-12-17 10:50:56 -08:00
Victor Felder
9a97d92217
T2965: Patterns as rest parameter operands are not valid, therefore this relic should go
2015-11-19 13:50:12 +01:00
Victor Felder
a510e7325b
Factor out optimiseCandidate to reduce nesting & complexity
2015-11-19 13:47:07 +01:00
Victor Felder
306b5db1ef
Have es2015 rest transform safely use arguments
2015-11-19 12:47:55 +01:00
Sebastian McKenzie
e62a00df50
rename NumberLiteral to NumericLiteral and RegexLiteral to RegExpLiteral
2015-11-03 01:19:35 +00:00
Sebastian McKenzie
ae7d5367f1
6.0.0
...
I'm extremely stupid and didn't commit as I go. To anyone reading this
I'm extremely sorry. A lot of these changes are very broad and I plan on
releasing Babel 6.0.0 today live on stage at Ember Camp London so I'm
afraid I couldn't wait. If you're ever in London I'll buy you a beer
(or assorted beverage!) to make up for it, also I'll kiss your feet and
give you a back massage, maybe.
2015-10-29 17:51:24 +00:00
