Compare commits

..

14 Commits

Author SHA1 Message Date
4fd9f6e6a2 Fixed semver coercing 2019-11-14 23:00:40 +01:00
08550a076c Attempt to fix babel's assertVersion(7) from not seeing our 7.#.#.csx-.. as valid version of babel 7 2019-11-12 01:02:54 +01:00
d50037be8f Fixing peerDependencies 2019-11-11 23:46:12 +01:00
fd2c2f61bb Fix @babel/core to use csx-version of helpers 2019-11-11 20:28:35 +01:00
0e5c224ff1 Resolving to csx won't work, thus this... (and let's hope it doesnt fuckup things once it reaches npm) 2019-11-11 19:17:58 +01:00
b0b6a92b90 Trying with local package-references 2019-11-11 19:08:20 +01:00
a5c141ea85 Updated the makefile to match the lerna command currently used to publish packages 2019-11-11 19:02:43 +01:00
e488c32244 Nearly there, pointing dependencies of @babel/helpers to the CSX version 2019-11-11 19:01:53 +01:00
0febc4f55f Attempt #n+1 to figure out what lerna's "lerna ERR! Only absolute URLs are supported" is about (and it not outputing a lerna-debug.out like it says it would...) 2019-11-11 16:50:00 +01:00
5415a390a9 Fixed a test-error that mysteriously popped up 2019-11-11 15:10:30 +01:00
7dd772001d Working around odd backslash issue with corejs2 iterableToArray-helper 2019-11-11 14:35:07 +01:00
d314e28457 Fixed tests 2019-11-11 14:18:26 +01:00
b248b3f4e9 Adding the prepublish step to the custom publish-cerxes makefile-target 2019-11-11 11:37:07 +01:00
c8c6ff7c4c Implemented a fix to initializers+class-properties 2019-11-11 11:33:32 +01:00
1665 changed files with 12676 additions and 47874 deletions

View File

@ -1,5 +1,4 @@
version: 2.1 version: 2
aliases: aliases:
- &restore-node-modules-cache - &restore-node-modules-cache
keys: keys:
@ -40,57 +39,50 @@ aliases:
- &artifact_test262_xunit - &artifact_test262_xunit
path: ~/test-results path: ~/test-results
- &artifact_test262_diff_tap jobs:
path: ~/diff.tap test:
working_directory: ~/babel
executors:
node-executor:
docker: docker:
- image: circleci/node:13 - image: circleci/node:13
working_directory: ~/babel
# e2e-vue-cli test requires chromium
node-browsers-executor:
docker:
- image: circleci/node:13-browsers
working_directory: ~/babel
jobs:
build-standalone:
executor: node-executor
steps: steps:
- checkout - checkout
- restore_cache: *restore-yarn-cache - restore-cache: *restore-yarn-cache
- restore_cache: *restore-node-modules-cache - restore-cache: *restore-node-modules-cache
- run: yarn --version
- run: make test-ci-coverage
# Builds babel-standalone with the regular Babel config # Builds babel-standalone with the regular Babel config
- run: IS_PUBLISH=true make build
# test-ci-coverage doesn't test babel-standalone, as trying to gather coverage # test-ci-coverage doesn't test babel-standalone, as trying to gather coverage
- run: IS_PUBLISH=true make -j build-standalone-ci
# data for a JS file that's several megabytes large is bound to fail. Here, # data for a JS file that's several megabytes large is bound to fail. Here,
# we just run the babel-standalone test separately. # we just run the babel-standalone test separately.
- run: yarn jest "\-standalone/test" - run: ./node_modules/.bin/jest packages/babel-standalone/test/
- run: ./node_modules/.bin/jest packages/babel-preset-env-standalone/test/
- store_artifacts: *artifact_babel - store_artifacts: *artifact_babel
- store_artifacts: *artifact_babel_min - store_artifacts: *artifact_babel_min
- store_artifacts: *artifact_env - store_artifacts: *artifact_env
- store_artifacts: *artifact_env_min - store_artifacts: *artifact_env_min
- save_cache: *save-node-modules-cache - save_cache: *save-node-modules-cache
- save_cache: *save-yarn-cache - save_cache: *save-yarn-cache
test262: test262:
executor: node-executor working_directory: ~/babel
docker:
- image: circleci/node:12
steps: steps:
- checkout - checkout
- run: - restore-cache: *restore-yarn-cache
name: Sync with latest master branch (only on PRs) - restore-cache: *restore-node-modules-cache
command: |
if [ -n "$CIRCLE_PULL_REQUEST" ]
then
git fetch origin refs/pull/$CIRCLE_PR_NUMBER/merge
git checkout -qf FETCH_HEAD
fi
- restore_cache: *restore-yarn-cache
- restore_cache: *restore-node-modules-cache
- run: - run:
name: Build Babel name: Build Babel
command: BABEL_ENV=test make bootstrap command: BABEL_ENV=test make bootstrap
- run:
name: Link Babel
command: |
cd packages
for package in */; do
cd $package
yarn link
cd ..
done
- run: - run:
name: Setup Test Runner name: Setup Test Runner
command: | command: |
@ -98,111 +90,32 @@ jobs:
cd babel-test262-runner cd babel-test262-runner
yarn yarn
yarn add tap-mocha-reporter --dev yarn add tap-mocha-reporter --dev
curl -L https://github.com/stedolan/jq/releases/download/jq-1.5/jq-linux64 > jq
chmod +x ./jq
for package in ../packages/*/package.json; do
yarn link $(./jq -j ".name" $package)
done
node lib/download-node node lib/download-node
- run:
name: Download master branch Test262 artifact
command: node lib/download-master-artifact ~/master.tap
<<: *test262_workdir
- run: - run:
name: Run Test262 name: Run Test262
command: BABEL_PATH=.. node lib/run-tests I_AM_SURE | tee ~/test262.tap command: node lib/run-tests I_AM_SURE | tee ~/test262.tap
<<: *test262_workdir <<: *test262_workdir
- store_artifacts: *artifact_test262_tap - store_artifacts: *artifact_test262_tap
- run: - run:
name: Output Test262 results name: Output test262 results
command: | command: |
cat ~/test262.tap | $(npm bin)/tap-mocha-reporter spec || true cat ~/test262.tap | $(npm bin)/tap-mocha-reporter spec || true
<<: *test262_workdir <<: *test262_workdir
- run:
name: Compare previous master branch & current job results
command: |
mkdir -p ~/test-results/test262
node lib/compare-results ~/master.tap ~/test262.tap | tee ~/diff.tap
<<: *test262_workdir
- store_artifacts: *artifact_test262_diff_tap
- run:
name: Output comparision results and report to CircleCI
command: |
mkdir -p ~/test-results/test262
cat ~/diff.tap | $(npm bin)/tap-merge | $(npm bin)/tap-mocha-reporter xunit | tee ~/test-results/test262/results.xml
<<: *test262_workdir
- store_test_results: *artifact_test262_xunit
- save_cache: *save-node-modules-cache
- save_cache: *save-yarn-cache
publish-verdaccio:
executor: node-executor
steps:
- checkout
- run: yarn install
- run: ./scripts/integration-tests/publish-local.sh
- persist_to_workspace:
root: /tmp/verdaccio-workspace
paths:
- storage
- htpasswd
e2e-babel:
executor: node-executor
steps:
- checkout
- attach_workspace:
at: /tmp/verdaccio-workspace
- run: ./scripts/integration-tests/e2e-babel.sh
e2e-create-react-app:
executor: node-executor
steps:
- checkout
- attach_workspace:
at: /tmp/verdaccio-workspace
- run: ./scripts/integration-tests/e2e-create-react-app.sh
e2e-vue-cli:
executor: node-browsers-executor
steps:
- checkout
- attach_workspace:
at: /tmp/verdaccio-workspace
- run: ./scripts/integration-tests/e2e-vue-cli.sh
workflows: workflows:
version: 2 version: 2
build-standalone: test:
jobs: jobs:
- build-standalone - test
test262-master: master:
jobs: jobs:
- test262: - test262:
filters: filters:
branches: branches:
only: only:
- master - master
test262:
jobs:
- approve-test262-run:
type: approval
filters:
branches:
ignore:
- master
- test262:
requires:
- approve-test262-run
filters:
branches:
ignore:
- master
e2e:
jobs:
- publish-verdaccio
- e2e-babel:
requires:
- publish-verdaccio
- e2e-create-react-app:
requires:
- publish-verdaccio
- e2e-vue-cli:
requires:
- publish-verdaccio

View File

@ -1,5 +0,0 @@
{
"installCommand": "bootstrap",
"buildCommand": false,
"sandboxes": ["kypop"]
}

View File

@ -17,15 +17,10 @@ codemods/*/lib
codemods/*/dist codemods/*/dist
codemods/*/test/fixtures codemods/*/test/fixtures
codemods/*/test/tmp codemods/*/test/tmp
packages/babel-preset-env/data/[^(plugin-features|shipped-proposals).js] packages/babel-preset-env/data
packages/babel-preset-env/test/debug-fixtures packages/babel-preset-env/test/debug-fixtures
packages/babel-preset-env-standalone/babel-preset-env.js packages/babel-preset-env-standalone/babel-preset-env.js
packages/babel-preset-env-standalone/babel-preset-env.min.js packages/babel-preset-env-standalone/babel-preset-env.min.js
packages/babel-standalone/babel.js packages/babel-standalone/babel.js
packages/babel-standalone/babel.min.js packages/babel-standalone/babel.min.js
packages/babel-parser/test/expressions packages/babel-parser/test/expressions
eslint/*/lib
eslint/*/node_modules
eslint/*/test
eslint/*/tests

View File

@ -1,48 +0,0 @@
module.exports = {
root: true,
plugins: ["prettier", "@babel/development", "import"],
extends: "babel",
rules: {
"prettier/prettier": "error",
// TODO: remove after babel-eslint-config-internal is fully integrated into this repository.
"max-len": "off",
},
env: {
node: true,
},
overrides: [
{
files: [
"packages/*/src/**/*.js",
"codemods/*/src/**/*.js",
"eslint/*/src/**/*.js",
],
rules: {
"@babel/development/no-undefined-identifier": "error",
"@babel/development/no-deprecated-clone": "error",
"import/no-extraneous-dependencies": "error",
"guard-for-in": "error",
},
},
{
files: [
"packages/*/test/**/*.js",
"codemods/*/test/**/*.js",
"eslint/*/test/**/*.js",
"packages/babel-helper-transform-fixture-test-runner/src/helpers.js",
"test/**/*.js",
],
env: {
jest: true,
},
},
{
files: ["packages/babel-plugin-*/src/index.js"],
excludedFiles: ["packages/babel-plugin-transform-regenerator/**/*.js"],
rules: {
"@babel/development/plugin-name": "error",
eqeqeq: ["error", "always", { null: "ignore" }],
},
},
],
};

41
.eslintrc.json Normal file
View File

@ -0,0 +1,41 @@
{
"root": true,
"plugins": ["prettier", "@babel/development", "import"],
"extends": "babel",
"rules": {
"prettier/prettier": "error"
},
"env": {
"node": true
},
"overrides": [
{
"files": ["packages/*/src/**/*.js", "codemods/*/src/**/*.js"],
"rules": {
"@babel/development/no-undefined-identifier": "error",
"@babel/development/no-deprecated-clone": "error",
"import/no-extraneous-dependencies": "error",
"guard-for-in": "error"
}
},
{
"files": [
"packages/*/test/**/*.js",
"codemods/*/test/**/*.js",
"packages/babel-helper-transform-fixture-test-runner/src/helpers.js",
"test/**/*.js"
],
"env": {
"jest": true
}
},
{
"files": ["packages/babel-plugin-*/src/index.js"],
"excludedFiles": ["packages/babel-plugin-transform-regenerator/**/*.js"],
"rules": {
"@babel/development/plugin-name": "error",
"eqeqeq": ["error", "always", { "null": "ignore" }]
}
}
]
}

View File

@ -9,14 +9,6 @@ assignees: ''
## Bug Report ## Bug Report
<!-- Check this if you would like to implement a PR, we are more than happy to help you go through the process !-->
- [ ] I would like to work on a fix!
<!--
@babel/eslint-parser:
If you are having issues with JSX you might want to check out eslint-plugin-react. If there's an issue with new experimental syntax you might need check if it's supported by @babel/eslint-plugin.
-->
**Current Behavior** **Current Behavior**
A clear and concise description of the behavior. A clear and concise description of the behavior.
@ -30,8 +22,7 @@ var your => (code) => here;
**Expected behavior/code** **Expected behavior/code**
A clear and concise description of what you expected to happen (or code). A clear and concise description of what you expected to happen (or code).
**Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command, .eslintrc)** **Babel Configuration (.babelrc, package.json, cli command)**
- Filename: `babel.config.js`
```js ```js
{ {
@ -40,10 +31,6 @@ A clear and concise description of what you expected to happen (or code).
``` ```
**Environment** **Environment**
<!--- Tip: Instead of filling out the questions below, you can run `npx envinfo --preset babel` and paste the result below ``` -->
```
```
- Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34] - Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34]
- Node/npm version: [e.g. Node 8/npm 5] - Node/npm version: [e.g. Node 8/npm 5]
- OS: [e.g. OSX 10.13.4, Windows 10] - OS: [e.g. OSX 10.13.4, Windows 10]
@ -51,7 +38,7 @@ A clear and concise description of what you expected to happen (or code).
- How you are using Babel: [e.g. `cli`, `register`, `loader`] - How you are using Babel: [e.g. `cli`, `register`, `loader`]
**Possible Solution** **Possible Solution**
<!--- If you have suggestions on a fix for the bug --> <!--- Only if you have suggestions on a fix for the bug -->
**Additional context/Screenshots** **Additional context/Screenshots**
Add any other context about the problem here. If applicable, add screenshots to help explain. Add any other context about the problem here. If applicable, add screenshots to help explain.

View File

@ -9,9 +9,6 @@ assignees: ''
## Feature Request ## Feature Request
<!-- Check this if you would like to implement a PR, we are more than happy to help you go through the process !-->
- [ ] I would like to work on this feature!
**Is your feature request related to a problem? Please describe.** **Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I have an issue when [...] A clear and concise description of what the problem is. Ex. I have an issue when [...]

View File

@ -10,9 +10,6 @@ assignees: ''
# v7 Regression # v7 Regression
<!-- Check this if you would like to implement a PR, we are more than happy to help you go through the process !-->
- [ ] I would like to work on a fix!
> First check out: https://babeljs.io/docs/en/v7-migration > First check out: https://babeljs.io/docs/en/v7-migration
> Also a partial upgrade tool: https://github.com/babel/babel-upgrade > Also a partial upgrade tool: https://github.com/babel/babel-upgrade
@ -29,10 +26,7 @@ A clear and concise description of what the regression is.
var your => (code) => here; var your => (code) => here;
``` ```
**Expected behavior/code** **Babel Configuration (.babelrc, package.json, cli command)**
A clear and concise description of what you expected to happen (or code).
**Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command)**
```js ```js
{ {
@ -40,11 +34,10 @@ A clear and concise description of what you expected to happen (or code).
} }
``` ```
**Environment** **Expected behavior/code**
<!--- Tip: Instead of filling out the questions below, you can run `npx envinfo --preset babel` and paste the result below ``` --> A clear and concise description of what you expected to happen (or code).
```
``` **Environment**
- Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34] - Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34]
- Node/npm version: [e.g. Node 8/npm 5] - Node/npm version: [e.g. Node 8/npm 5]
- OS: [e.g. OSX 10.13.4, Windows 10] - OS: [e.g. OSX 10.13.4, Windows 10]

View File

@ -1,29 +0,0 @@
name: Report Coverage
on: [push, pull_request]
jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [13.x]
steps:
- name: Checkout code
uses: actions/checkout@v1
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- name: Environment log
id: env
run: |
yarn --version
- name: Generate coverage report
run: |
yarn --version
make -j test-ci-coverage
- name: Upload coverage report
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}

11
.gitignore vendored
View File

@ -20,8 +20,6 @@ dist
package-lock.json package-lock.json
!/.github/actions/*/package-lock.json !/.github/actions/*/package-lock.json
/packages/babel-compat-data/build
/packages/babel-runtime/helpers/*.js /packages/babel-runtime/helpers/*.js
!/packages/babel-runtime/helpers/toArray.js !/packages/babel-runtime/helpers/toArray.js
!/packages/babel-runtime/helpers/iterableToArray.js !/packages/babel-runtime/helpers/iterableToArray.js
@ -37,7 +35,7 @@ package-lock.json
!/packages/babel-runtime-corejs2/helpers/temporalRef.js !/packages/babel-runtime-corejs2/helpers/temporalRef.js
/packages/babel-runtime-corejs2/helpers/esm/*.js /packages/babel-runtime-corejs2/helpers/esm/*.js
!/packages/babel-runtime-corejs2/helpers/esm/toArray.js !/packages/babel-runtime-corejs2/helpers/esm/toArray.js
!/packages/babel-runtime-corejs2/helpers/esm/iterableToArray.js /packages/babel-runtime-corejs2/helpers/esm/iterableToArray.js
!/packages/babel-runtime-corejs2/helpers/esm/temporalRef.js !/packages/babel-runtime-corejs2/helpers/esm/temporalRef.js
/packages/babel-runtime-corejs2/core-js/**/*.js /packages/babel-runtime-corejs2/core-js/**/*.js
!/packages/babel-runtime-corejs2/core-js/map.js !/packages/babel-runtime-corejs2/core-js/map.js
@ -54,18 +52,11 @@ package-lock.json
.nyc_output .nyc_output
/babel.sublime-workspace /babel.sublime-workspace
packages/babel-standalone/babel.js packages/babel-standalone/babel.js
packages/babel-standalone/babel.js.map
packages/babel-standalone/babel.min.js packages/babel-standalone/babel.min.js
packages/babel-preset-env-standalone/babel-preset-env.js packages/babel-preset-env-standalone/babel-preset-env.js
packages/babel-preset-env-standalone/babel-preset-env.js.map
packages/babel-preset-env-standalone/babel-preset-env.min.js packages/babel-preset-env-standalone/babel-preset-env.min.js
/codemods/*/lib /codemods/*/lib
/codemods/*/node_modules /codemods/*/node_modules
/packages/babel-parser/build /packages/babel-parser/build
.idea/ .idea/
/.changelog /.changelog
/eslint/*/lib
/eslint/*/node_modules
/eslint/*/LICENSE
!/packages/babel-eslint-plugin/LICENSE

View File

@ -1,7 +1,5 @@
package.json package.json
packages/babel-preset-env/data packages/babel-preset-env/data
packages/babel-compat-data/data
packages/babel-compat-data/scripts/data/overlapping-plugins.js
packages/*/test/fixtures/**/input.* packages/*/test/fixtures/**/input.*
packages/*/test/fixtures/**/exec.* packages/*/test/fixtures/**/exec.*
packages/*/test/fixtures/**/output.* packages/*/test/fixtures/**/output.*

View File

@ -13,12 +13,10 @@
"**/codemods/*/src/**/*.js", "**/codemods/*/src/**/*.js",
"**/codemods/*/test/**/*.js", "**/codemods/*/test/**/*.js",
"**/packages/*/src/**/*.js", "**/packages/*/src/**/*.js",
"**/packages/*/test/**/*.js", "**/packages/*/test/**/*.js"
"**/eslint/*/src/**/*.js",
"**/eslint/*/test/**/*.js"
], ],
"parser": "babylon",
"options": { "options": {
"parser": "babel",
"trailingComma": "all" "trailingComma": "all"
} }
}] }]

View File

@ -20,7 +20,6 @@ script:
- if [ "$JOB" = "test" ]; then make -j test-ci; fi - if [ "$JOB" = "test" ]; then make -j test-ci; fi
- if [ "$JOB" = "lint" ]; then make -j code-quality-ci; fi - if [ "$JOB" = "lint" ]; then make -j code-quality-ci; fi
- if [ "$JOB" = "babel-parser-flow-tests" ]; then make -j test-flow-ci; fi - if [ "$JOB" = "babel-parser-flow-tests" ]; then make -j test-flow-ci; fi
- if [ "$JOB" = "babel-parser-typescript-tests" ]; then make -j test-typescript-ci; fi
- if [ "$JOB" = "babel-parser-test262-tests" ]; then make -j test-test262-ci; fi - if [ "$JOB" = "babel-parser-test262-tests" ]; then make -j test-test262-ci; fi
matrix: matrix:
@ -37,18 +36,12 @@ matrix:
- JOB=test - JOB=test
# https://travis-ci.community/t/build-doesnt-finish-after-completing-tests/288/9 # https://travis-ci.community/t/build-doesnt-finish-after-completing-tests/288/9
- YARN_GPG=no - YARN_GPG=no
cache:
yarn: true
directories:
- $HOME/AppData/Local/Temp/chocolatey
# Continue node_js matrix # Continue node_js matrix
- node_js: "6" - node_js: "6"
- node_js: "10" - node_js: "10"
- node_js: "8" - node_js: "8"
- node_js: "node" - node_js: "node"
env: JOB=babel-parser-flow-tests env: JOB=babel-parser-flow-tests
- node_js: "node"
env: JOB=babel-parser-typescript-tests
- node_js: "node" - node_js: "node"
env: JOB=babel-parser-test262-tests env: JOB=babel-parser-test262-tests

File diff suppressed because one or more lines are too long

View File

@ -1,4 +1,4 @@
--- ----
<p align="center" class="toc"> <p align="center" class="toc">
<strong><a href="#setup">Setup</a></strong> <strong><a href="#setup">Setup</a></strong>
@ -12,7 +12,8 @@
<strong><a href="#internals">Internals</a></strong> <strong><a href="#internals">Internals</a></strong>
</p> </p>
--- ----
# Contributing # Contributing
@ -48,12 +49,8 @@ Installation instructions can be found here: https://yarnpkg.com/en/docs/install
### Setup ### Setup
Fork the `babel` repository to your GitHub Account.
Then, run:
```sh ```sh
$ git clone https://github.com/<your-github-username>/babel $ git clone https://github.com/babel/babel
$ cd babel $ cd babel
$ make bootstrap $ make bootstrap
``` ```
@ -161,12 +158,12 @@ $ ./scripts/test-cov.sh
In case you're not able to reproduce an error on CI locally, it may be due to In case you're not able to reproduce an error on CI locally, it may be due to
- Node Version: Travis CI runs the tests against all major node versions. If your tests use JavaScript features unsupported by lower versions of node, then use [minNodeVersion option](#writing-tests) in options.json. - Node Version: Travis CI runs the tests against all major node versions. If your tests use JavaScript features unsupported by lower versions of node, then use [minNodeVersion option](#writing-tests) in options.json.
- Timeout: Check the CI log and if the only errors are timeout errors and you are sure that it's not related to the changes you made, ask someone in the slack channel to trigger rebuild on the CI build and it might be resolved - Timeout: Check the CI log and if the only errors are timeout errors and you are sure that it's not related to the changes you made, ask someone in the slack channel to trigger rebuild on the CI build and it might be resolved
In case you're locally getting errors which are not on the CI, it may be due to In case you're locally getting errors which are not on the CI, it may be due to
- Updates in Dependencies: Make sure you run `make bootstrap` before you run `make build` or `make watch` before you run the tests. - Updates in Dependencies: Make sure you run `make bootstrap` before you run `make build` or `make watch` before you run the tests.
### Writing tests ### Writing tests
@ -180,7 +177,6 @@ For example, in [`@babel/plugin-transform-exponentiation-operator/test`](https:/
- There is an `index.js` file. It imports our [test helper](https://github.com/babel/babel/tree/master/packages/babel-helper-plugin-test-runner). (You don't have to worry about this). - There is an `index.js` file. It imports our [test helper](https://github.com/babel/babel/tree/master/packages/babel-helper-plugin-test-runner). (You don't have to worry about this).
- There can be multiple folders under [`/fixtures`](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures) - There can be multiple folders under [`/fixtures`](https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures)
- There is an [`options.json`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/options.json) file whose function is similar to a `.babelrc` file, allowing you to pass in the plugins and settings you need for your tests. - There is an [`options.json`](https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-exponentiation-operator/test/fixtures/exponentian-operator/options.json) file whose function is similar to a `.babelrc` file, allowing you to pass in the plugins and settings you need for your tests.
- For this test, we only need the relevant plugin, so it's just `{ "plugins": ["@babel/plugin-transform-exponentiation-operator"] }`. - For this test, we only need the relevant plugin, so it's just `{ "plugins": ["@babel/plugin-transform-exponentiation-operator"] }`.
- If necessary, you can have an `options.json` with different options in each subfolder. - If necessary, you can have an `options.json` with different options in each subfolder.
@ -204,7 +200,6 @@ and the expected output after transforming it with your `options.json` in `outpu
// output.js // output.js
Math.pow(2, 2); Math.pow(2, 2);
``` ```
In an `exec.js` test, we run or check that the code actually does what it's supposed to do rather than just check the static output. In an `exec.js` test, we run or check that the code actually does what it's supposed to do rather than just check the static output.
```js ```js
@ -240,9 +235,9 @@ Inside the `packages/babel-parser/test/fixtures` folder are categories/groupings
etc.). To add a test, create a folder under one of these groupings (or create a new one) with a etc.). To add a test, create a folder under one of these groupings (or create a new one) with a
descriptive name, and add the following: descriptive name, and add the following:
- Create an `input.js` file that contains the code you want the babel parser to parse. * Create an `input.js` file that contains the code you want the babel parser to parse.
- Add an `output.json` file with the expected parser output. For added convenience, if there is no `output.json` present, the test runner will generate one for you. * Add an `output.json` file with the expected parser output. For added convenience, if there is no `output.json` present, the test runner will generate one for you.
After writing tests for @babel/parser, just build it by running: After writing tests for @babel/parser, just build it by running:
@ -322,7 +317,6 @@ Note that the code shown in Chrome DevTools is compiled code and therefore diffe
- Start working about the Babel transform itself! - Start working about the Babel transform itself!
## Internals ## Internals
- AST spec ([babel-parser/ast/spec.md](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md)) - AST spec ([babel-parser/ast/spec.md](https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md))
- Versioning ([doc/design/versioning.md](https://github.com/babel/babel/blob/master/doc/design/versioning.md)) - Versioning ([doc/design/versioning.md](https://github.com/babel/babel/blob/master/doc/design/versioning.md))
- Monorepo ([doc/design/monorepo.md](https://github.com/babel/babel/blob/master/doc/design/monorepo.md)) - Monorepo ([doc/design/monorepo.md](https://github.com/babel/babel/blob/master/doc/design/monorepo.md))

View File

@ -10,19 +10,14 @@ const fancyLog = require("fancy-log");
const filter = require("gulp-filter"); const filter = require("gulp-filter");
const gulp = require("gulp"); const gulp = require("gulp");
const path = require("path"); const path = require("path");
const webpack = require("webpack");
const rollup = require("rollup"); const rollup = require("rollup");
const rollupAlias = require("@rollup/plugin-alias");
const rollupBabel = require("rollup-plugin-babel"); const rollupBabel = require("rollup-plugin-babel");
const rollupBabelSource = require("./scripts/rollup-plugin-babel-source");
const rollupCommonJs = require("rollup-plugin-commonjs");
const rollupJson = require("@rollup/plugin-json");
const rollupNodeBuiltins = require("rollup-plugin-node-builtins");
const rollupNodeGlobals = require("rollup-plugin-node-globals");
const rollupNodeResolve = require("rollup-plugin-node-resolve"); const rollupNodeResolve = require("rollup-plugin-node-resolve");
const rollupReplace = require("rollup-plugin-replace"); const rollupReplace = require("rollup-plugin-replace");
const { terser: rollupTerser } = require("rollup-plugin-terser"); const { registerStandalonePackageTask } = require("./scripts/gulp-tasks");
const defaultSourcesGlob = "./@(codemods|packages|eslint)/*/src/**/*.js"; const defaultSourcesGlob = "./@(codemods|packages)/*/src/**/*.js";
function swapSrcWithLib(srcPath) { function swapSrcWithLib(srcPath) {
const parts = srcPath.split(path.sep); const parts = srcPath.split(path.sep);
@ -80,209 +75,42 @@ function buildBabel(exclude, sourcesGlob = defaultSourcesGlob) {
.pipe(gulp.dest(base)); .pipe(gulp.dest(base));
} }
let babelVersion = require("./packages/babel-core/package.json").version;
function buildRollup(packages) { function buildRollup(packages) {
const sourcemap = process.env.NODE_ENV === "production";
const minify = !!process.env.IS_PUBLISH;
return Promise.all( return Promise.all(
packages.map( packages.map(pkg => {
({ src, format, dest, name, filename, version = babelVersion }) => { const input = getIndexFromPackage(pkg);
const extraPlugins = [];
let inputExternal = undefined,
outputGlobals = undefined,
nodeResolveBrowser = false,
babelEnvName = "rollup";
switch (src) {
case "packages/babel-standalone":
nodeResolveBrowser = true;
babelEnvName = "standalone";
if (minify) {
extraPlugins.push(
rollupTerser({
include: /^.+\.min\.js$/,
})
);
}
break;
case "packages/babel-preset-env-standalone":
nodeResolveBrowser = true;
babelEnvName = "standalone";
if (minify) {
extraPlugins.push(
rollupTerser({
include: /^.+\.min\.js$/,
})
);
}
inputExternal = ["@babel/standalone"];
outputGlobals = {
"@babel/standalone": "Babel",
};
extraPlugins.push(
rollupAlias({
entries: [
{
find: "./available-plugins",
replacement: require.resolve(
path.join(__dirname, src, "./src/available-plugins")
),
},
{
find: "caniuse-lite/data/regions",
replacement: require.resolve(
path.join(__dirname, src, "./src/caniuse-lite-regions")
),
},
],
})
);
break;
}
// If this build is part of a pull request, include the pull request number in
// the version number.
if (process.env.CIRCLE_PR_NUMBER) {
const prVersion = "+pr." + process.env.CIRCLE_PR_NUMBER;
babelVersion += prVersion;
version += prVersion;
}
const input = getIndexFromPackage(src);
fancyLog(`Compiling '${chalk.cyan(input)}' with rollup ...`); fancyLog(`Compiling '${chalk.cyan(input)}' with rollup ...`);
return rollup return rollup
.rollup({ .rollup({
input, input,
external: inputExternal,
plugins: [ plugins: [
...extraPlugins,
rollupBabelSource(),
rollupReplace({ rollupReplace({
"process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV), "process.env.NODE_ENV": JSON.stringify(process.env.NODE_ENV),
BABEL_VERSION: JSON.stringify(babelVersion),
VERSION: JSON.stringify(version),
}), }),
rollupBabel({ rollupBabel({
envName: babelEnvName, envName: "babel-parser",
babelrc: false,
extends: "./babel.config.js",
}), }),
rollupNodeResolve({ rollupNodeResolve(),
browser: nodeResolveBrowser,
preferBuiltins: true,
//todo: When Yarn workspaces is enabled, remove `dedupe` option
dedupe(importee) {
return (
importee.startsWith("lodash/") ||
[
"babel-plugin-dynamic-import-node/utils",
"esutils",
"semver",
"source-map",
].includes(importee)
);
},
}),
rollupCommonJs({
include: [
/node_modules/,
"packages/babel-runtime/regenerator/**",
"packages/babel-preset-env/data/*.js",
// Rollup doesn't read export maps, so it loads the cjs fallback
"packages/babel-compat-data/*.js",
],
namedExports: {
"babel-plugin-dynamic-import-node/utils.js": [
"createDynamicImportTransform",
"getImportSource",
],
"@babel/standalone": ["availablePlugins", "registerPlugin"],
},
}),
rollupJson(),
rollupNodeBuiltins(),
rollupNodeGlobals({ sourceMap: sourcemap }),
], ],
}) })
.then(bundle => { .then(bundle => {
const outputFile = path.resolve(src, dest, filename || "index.js");
return bundle
.write({
file: outputFile,
format,
name,
globals: outputGlobals,
sourcemap: sourcemap,
})
.then(() => {
if (!process.env.IS_PUBLISH) {
fancyLog(
chalk.yellow(
`Skipped minification of '${chalk.cyan(
path.relative(path.join(__dirname, ".."), outputFile)
)}' because not publishing`
)
);
return undefined;
}
fancyLog(
`Minifying '${chalk.cyan(
path.relative(path.join(__dirname, ".."), outputFile)
)}'...`
);
return bundle.write({ return bundle.write({
file: outputFile.replace(/\.js$/, ".min.js"), file: path.join(pkg, "lib/index.js"),
format, format: "cjs",
name, name: "babel-parser",
globals: outputGlobals, sourcemap: process.env.NODE_ENV !== "production",
sourcemap: sourcemap,
}); });
}); });
}); })
}
)
); );
} }
const libBundles = [ const bundles = ["packages/babel-parser"];
{
src: "packages/babel-parser",
format: "cjs",
dest: "lib",
version: require("./packages/babel-parser/package").version,
},
];
const standaloneBundle = [ gulp.task("build-rollup", () => buildRollup(bundles));
{ gulp.task("build-babel", () => buildBabel(/* exclude */ bundles));
src: "packages/babel-standalone",
format: "umd",
name: "Babel",
filename: "babel.js",
dest: "",
version: require("./packages/babel-core/package").version,
},
];
const presetEnvStandaloneBundle = [
{
src: "packages/babel-preset-env-standalone",
format: "umd",
name: "BabelPresetEnv",
filename: "babel-preset-env.js",
dest: "",
version: require("./packages/babel-preset-env/package").version,
},
];
gulp.task("build-rollup", () => buildRollup(libBundles));
gulp.task("build-babel-standalone", () => buildRollup(standaloneBundle));
gulp.task("build-babel-preset-env-standalone", () =>
buildRollup(presetEnvStandaloneBundle)
);
gulp.task("build-babel", () => buildBabel(/* exclude */ libBundles));
gulp.task("build-babel-types", () => gulp.task("build-babel-types", () =>
buildBabel(/* exclude */ libBundles, "packages/babel-types/src/**/*.js") buildBabel(/* exclude */ bundles, "packages/babel-types/src/**/*.js")
); );
gulp.task("build", gulp.parallel("build-rollup", "build-babel")); gulp.task("build", gulp.parallel("build-rollup", "build-babel"));
@ -300,3 +128,41 @@ gulp.task(
); );
}) })
); );
registerStandalonePackageTask(
gulp,
"babel",
"Babel",
path.join(__dirname, "packages"),
require("./packages/babel-standalone/package.json").version
);
const presetEnvWebpackPlugins = [
new webpack.NormalModuleReplacementPlugin(
/\.\/available-plugins/,
require.resolve(
path.join(
__dirname,
"./packages/babel-preset-env-standalone/src/available-plugins"
)
)
),
new webpack.NormalModuleReplacementPlugin(
/caniuse-lite\/data\/regions\/.+/,
require.resolve(
path.join(
__dirname,
"./packages/babel-preset-env-standalone/src/caniuse-lite-regions"
)
)
),
];
registerStandalonePackageTask(
gulp,
"babel-preset-env",
"babelPresetEnv",
path.join(__dirname, "packages"),
require("./packages/babel-preset-env-standalone/package.json").version,
presetEnvWebpackPlugins
);

View File

@ -1,19 +1,10 @@
FLOW_COMMIT = a1f9a4c709dcebb27a5084acf47755fbae699c25 FLOW_COMMIT = 09669846b7a7ca5a6c23c12d56bb3bebdafd67e9
TEST262_COMMIT = 28b4fcca4b1b1d278dfe0cc0e69c7d9d59b31aab TEST262_COMMIT = 8688c4ab79059c3097098605e69f1ee5eda6c409
TYPESCRIPT_COMMIT = 5fc917be2e4dd64c8e9504d36615cd7fbfdd4cd3
FORCE_PUBLISH = "@babel/runtime,@babel/runtime-corejs2,@babel/runtime-corejs3,@babel/standalone,@babel/preset-env-standalone"
# Fix color output until TravisCI fixes https://github.com/travis-ci/travis-ci/issues/7967 # Fix color output until TravisCI fixes https://github.com/travis-ci/travis-ci/issues/7967
export FORCE_COLOR = true export FORCE_COLOR = true
SOURCES = packages codemods eslint SOURCES = packages codemods
COMMA := ,
EMPTY :=
SPACE := $(EMPTY) $(EMPTY)
COMMA_SEPARATED_SOURCES = $(subst $(SPACE),$(COMMA),$(SOURCES))
.PHONY: build build-dist watch lint fix clean test-clean test-only test test-ci publish bootstrap .PHONY: build build-dist watch lint fix clean test-clean test-only test test-ci publish bootstrap
@ -112,7 +103,7 @@ lint-js:
yarn eslint scripts $(SOURCES) '*.js' --format=codeframe yarn eslint scripts $(SOURCES) '*.js' --format=codeframe
lint-ts: lint-ts:
scripts/lint-ts-typings.sh scripts/tests/typescript/lint.sh
fix: fix-json fix-js fix: fix-json fix-js
@ -120,7 +111,7 @@ fix-js:
yarn eslint scripts $(SOURCES) '*.js' --format=codeframe --fix yarn eslint scripts $(SOURCES) '*.js' --format=codeframe --fix
fix-json: fix-json:
yarn prettier "{$(COMMA_SEPARATED_SOURCES)}/*/test/fixtures/**/options.json" --write --loglevel warn yarn prettier "{packages,codemod}/*/test/fixtures/**/options.json" --write --loglevel warn
clean: test-clean clean: test-clean
rm -f .npmrc rm -f .npmrc
@ -136,8 +127,7 @@ test-clean:
# Does not work on Windows; use "yarn jest" instead # Does not work on Windows; use "yarn jest" instead
test-only: test-only:
BABEL_ENV=test ./scripts/test.sh BABEL_ENV=test ./scripts/test.sh
YARN jest $(MAKE) test-clean
#$(MAKE) test-clean
test: lint test-only test: lint test-only
@ -161,43 +151,28 @@ bootstrap-flow:
cd build/flow && git checkout $(FLOW_COMMIT) cd build/flow && git checkout $(FLOW_COMMIT)
test-flow: test-flow:
node scripts/parser-tests/flow node scripts/tests/flow/run_babel_parser_flow_tests.js
test-flow-ci: build-bundle-ci bootstrap-flow test-flow-ci: build-bundle-ci bootstrap-flow
$(MAKE) test-flow $(MAKE) test-flow
test-flow-update-whitelist: test-flow-update-whitelist:
node scripts/parser-tests/flow --update-whitelist node scripts/tests/flow/run_babel_parser_flow_tests.js --update-whitelist
bootstrap-typescript:
rm -rf ./build/typescript
mkdir -p ./build
git clone --branch=master --single-branch --shallow-since=2019-09-01 https://github.com/microsoft/TypeScript.git ./build/typescript
cd build/typescript && git checkout $(TYPESCRIPT_COMMIT)
test-typescript:
node scripts/parser-tests/typescript
test-typescript-ci: build-bundle-ci bootstrap-typescript
$(MAKE) test-typescript
test-typescript-update-whitelist:
node scripts/parser-tests/typescript --update-whitelist
bootstrap-test262: bootstrap-test262:
rm -rf build/test262 rm -rf build/test262
mkdir -p build mkdir -p build
git clone --branch=master --single-branch --shallow-since=2019-12-01 https://github.com/tc39/test262.git build/test262 git clone --branch=master --single-branch --shallow-since=2019-09-01 https://github.com/tc39/test262.git build/test262
cd build/test262 && git checkout $(TEST262_COMMIT) cd build/test262 && git checkout $(TEST262_COMMIT)
test-test262: test-test262:
node scripts/parser-tests/test262 node scripts/tests/test262/run_babel_parser_test262.js
test-test262-ci: build-bundle-ci bootstrap-test262 test-test262-ci: build-bundle-ci bootstrap-test262
$(MAKE) test-test262 $(MAKE) test-test262
test-test262-update-whitelist: test-test262-update-whitelist:
node scripts/parser-tests/test262 --update-whitelist node scripts/tests/test262/run_babel_parser_test262.js --update-whitelist
# Does not work on Windows # Does not work on Windows
clone-license: clone-license:
@ -210,17 +185,14 @@ prepublish-build: clean-lib clean-runtime-helpers
prepublish: prepublish:
$(MAKE) bootstrap-only $(MAKE) bootstrap-only
$(MAKE) prepublish-build $(MAKE) prepublish-build
#$(MAKE) test #fuck your tests babel... $(MAKE) test
new-version: new-version:
git pull --rebase git pull --rebase
yarn lerna version --force-publish=$(FORCE_PUBLISH) yarn lerna version --force-publish="@babel/runtime,@babel/runtime-corejs2,@babel/runtime-corejs3,@babel/standalone,@babel/preset-env-standalone"
version-cerxes:
yarn lerna version prerelease --allow-branch initializers-fix --preid csx
publish-cerxes: prepublish publish-cerxes: prepublish
yarn lerna publish --registry="https://npm.cerxes.net" --force-publish --allow-branch initializer-fix-v7.8.3 --dist-tag csx --skip-git --exact yarn lerna publish --registry="https://npm.cerxes.net" --force-publish --allow-branch initializers-fix --canary --preid csx --dist-tag csx
# NOTE: Run make new-version first # NOTE: Run make new-version first
publish: prepublish publish: prepublish
@ -238,43 +210,24 @@ endif
rm -f .npmrc rm -f .npmrc
$(MAKE) clean $(MAKE) clean
publish-test:
ifneq ("$(I_AM_USING_VERDACCIO)", "I_AM_SURE")
echo "You probably don't know what you are doing"
exit 1
endif
$(MAKE) prepublish-build
yarn lerna version patch --force-publish=$(FORCE_PUBLISH) --no-push --yes --tag-version-prefix="version-e2e-test-"
yarn lerna publish from-git --registry http://localhost:4873 --yes --tag-version-prefix="version-e2e-test-"
$(MAKE) clean
publish-eslint:
$(call set-json-field, ./eslint/$(PKG)/package.json, private, false)
cd eslint/$(PKG); yarn publish
$(call set-json-field, ./eslint/$(PKG)/package.json, private, true)
bootstrap-only: lerna-bootstrap bootstrap-only: lerna-bootstrap
yarn-install: clean-all yarn-install: clean-all
yarn --ignore-engines yarn --ignore-engines
lerna-bootstrap: yarn-install lerna-bootstrap: yarn-install
# todo: remove `-- -- --ignore-engines` in Babel 8 yarn lerna bootstrap
yarn lerna bootstrap -- -- --ignore-engines
bootstrap: bootstrap-only bootstrap: bootstrap-only
$(MAKE) build $(MAKE) build
clean-lib: clean-lib:
# TODO: Don't delete eslint/*/lib when they use src
$(foreach source, $(SOURCES), \ $(foreach source, $(SOURCES), \
$(if $(filter-out $(source), eslint), \ $(call clean-source-lib, $(source)))
$(call clean-source-lib, $(source))))
clean-runtime-helpers: clean-runtime-helpers:
rm -f packages/babel-runtime/helpers/**/*.js rm -rf packages/babel-runtime/helpers
rm -f packages/babel-runtime-corejs2/helpers/**/*.js rm -rf packages/babel-runtime-corejs2/helpers
rm -f packages/babel-runtime-corejs3/helpers/**/*.js
rm -rf packages/babel-runtime-corejs2/core-js rm -rf packages/babel-runtime-corejs2/core-js
clean-all: clean-all:
@ -287,12 +240,6 @@ clean-all:
$(MAKE) clean $(MAKE) clean
update-env-corejs-fixture:
rm -rf packages/babel-preset-env/node_modules/core-js-compat
$(YARN) lerna bootstrap
$(MAKE) build-bundle
OVERWRITE=true $(YARN) jest packages/babel-preset-env
define clean-source-lib define clean-source-lib
rm -rf $(1)/*/lib rm -rf $(1)/*/lib
@ -305,16 +252,8 @@ define clean-source-test
endef endef
define clean-source-all define clean-source-all
# TODO: Don't delete eslint/*/lib when they use src rm -rf $(1)/*/lib
$(if $(filter-out $1, eslint), $(call clean-source-lib, $1))
rm -rf $(1)/*/node_modules rm -rf $(1)/*/node_modules
rm -rf $(1)/*/package-lock.json rm -rf $(1)/*/package-lock.json
endef endef
define set-json-field
node -e "\
require('fs').writeFileSync('$1'.trim(), \
JSON.stringify({ ...require('$1'.trim()), $2: $3 }, null, 2) + '\\n' \
)"
endef

View File

@ -4,10 +4,17 @@
</a> </a>
</p> </p>
<p align="center">
<span style="color:darkred">
<b><i>WARNING</i> This is a fork of babel to test a fix for initializer-variables with class-properties (proposals-stuff)</b>
</span>
</p>
<p align="center"> <p align="center">
The compiler for writing next generation JavaScript. The compiler for writing next generation JavaScript.
</p> </p>
<p align="center"> <p align="center">
<a href="https://www.npmjs.com/package/@babel/core"><img alt="v7 npm Downloads" src="https://img.shields.io/npm/dm/@babel/core.svg?maxAge=43200&label=v7%20downloads"></a> <a href="https://www.npmjs.com/package/@babel/core"><img alt="v7 npm Downloads" src="https://img.shields.io/npm/dm/@babel/core.svg?maxAge=43200&label=v7%20downloads"></a>
<a href="https://www.npmjs.com/package/babel-core"><img alt="v6 npm Downloads" src="https://img.shields.io/npm/dm/babel-core.svg?maxAge=43200&label=v6%20downloads"></a> <a href="https://www.npmjs.com/package/babel-core"><img alt="v6 npm Downloads" src="https://img.shields.io/npm/dm/babel-core.svg?maxAge=43200&label=v6%20downloads"></a>
@ -108,7 +115,7 @@ Some resources:
- Our [CONTRIBUTING.md](CONTRIBUTING.md) to get started with setting up the repo. - Our [CONTRIBUTING.md](CONTRIBUTING.md) to get started with setting up the repo.
- Our discussions/notes/roadmap: [babel/notes](https://github.com/babel/notes) - Our discussions/notes/roadmap: [babel/notes](https://github.com/babel/notes)
- Our progress on TC39 proposals: [babel/proposals](https://github.com/babel/proposals) - Our progress on TC39 proposals: [babel/proposals](https://github.com/babel/proposals)
- Our blog which contains release posts and explanations: [/blog](https://babeljs.io/blog) - Our blog which contains release posts and explainations: [/blog](https://babeljs.io/blog)
- Our videos page with talks about open source and Babel: [/videos](https://babeljs.io/videos) - Our videos page with talks about open source and Babel: [/videos](https://babeljs.io/videos)
- Our [podcast](https://podcast.babeljs.io) - Our [podcast](https://podcast.babeljs.io)

View File

@ -14,38 +14,22 @@ module.exports = function(api) {
let convertESM = true; let convertESM = true;
let ignoreLib = true; let ignoreLib = true;
let includeRegeneratorRuntime = false; let includeRuntime = false;
let transformRuntimeOptions;
const nodeVersion = "6.9"; const nodeVersion = "6.9";
// The vast majority of our src files are modules, but we use
// unambiguous to keep things simple until we get around to renaming
// the modules to be more easily distinguished from CommonJS
const unambiguousSources = [
"packages/*/src",
"packages/*/test",
"codemods/*/src",
"codemods/*/test",
"eslint/*/src",
"eslint/*/test",
];
switch (env) { switch (env) {
// Configs used during bundling builds. // Configs used during bundling builds.
case "standalone": case "babel-parser":
includeRegeneratorRuntime = true;
unambiguousSources.push("packages/babel-runtime/regenerator");
case "rollup":
convertESM = false; convertESM = false;
ignoreLib = false; ignoreLib = false;
// rollup-commonjs will converts node_modules to ESM envOpts.targets = {
unambiguousSources.push( node: nodeVersion,
"**/node_modules", };
"packages/babel-preset-env/data", break;
"packages/babel-compat-data" case "standalone":
); convertESM = false;
if (env === "rollup") envOpts.targets = { node: nodeVersion }; ignoreLib = false;
includeRuntime = true;
break; break;
case "production": case "production":
// Config during builds before publish. // Config during builds before publish.
@ -66,16 +50,6 @@ module.exports = function(api) {
break; break;
} }
if (includeRegeneratorRuntime) {
const babelRuntimePkgPath = require.resolve("@babel/runtime/package.json");
transformRuntimeOptions = {
helpers: false, // Helpers are handled by rollup when needed
regenerator: true,
version: require(babelRuntimePkgPath).version,
};
}
const config = { const config = {
// Our dependencies are all standard CommonJS, along with all sorts of // Our dependencies are all standard CommonJS, along with all sorts of
// other random files in Babel's codebase, so we use script as the default, // other random files in Babel's codebase, so we use script as the default,
@ -103,14 +77,10 @@ module.exports = function(api) {
"@babel/proposal-object-rest-spread", "@babel/proposal-object-rest-spread",
{ useBuiltIns: true, loose: true }, { useBuiltIns: true, loose: true },
], ],
["@babel/plugin-proposal-optional-chaining", { loose: true }], "@babel/plugin-proposal-optional-chaining",
["@babel/plugin-proposal-nullish-coalescing-operator", { loose: true }], "@babel/plugin-proposal-nullish-coalescing-operator",
convertESM ? "@babel/transform-modules-commonjs" : null, convertESM ? "@babel/transform-modules-commonjs" : null,
// Until Jest supports native mjs, we must simulate it 🤷
env === "test" || env === "development"
? "@babel/plugin-proposal-dynamic-import"
: null,
].filter(Boolean), ].filter(Boolean),
overrides: [ overrides: [
{ {
@ -134,12 +104,28 @@ module.exports = function(api) {
presets: [["@babel/env", envOptsNoTargets]], presets: [["@babel/env", envOptsNoTargets]],
}, },
{ {
test: unambiguousSources, // The vast majority of our src files are modules, but we use
// unambiguous to keep things simple until we get around to renaming
// the modules to be more easily distinguished from CommonJS
test: [
"packages/*/src",
"packages/*/test",
"codemods/*/src",
"codemods/*/test",
],
sourceType: "unambiguous", sourceType: "unambiguous",
}, },
includeRegeneratorRuntime && { {
exclude: /regenerator-runtime/, // The runtime transform shouldn't process its own runtime or core-js.
plugins: [["@babel/transform-runtime", transformRuntimeOptions]], exclude: [
"packages/babel-runtime",
/[\\/]node_modules[\\/](?:@babel\/runtime|babel-runtime|core-js)[\\/]/,
],
plugins: [
includeRuntime
? ["@babel/transform-runtime", { version: "7.4.4" }]
: null,
].filter(Boolean),
}, },
].filter(Boolean), ].filter(Boolean),
}; };

View File

@ -5,7 +5,7 @@ coverage:
status: status:
project: project:
default: default:
target: "90%" target: "80%"
patch: patch:
enabled: false enabled: false
ignore: ignore:

View File

@ -1,6 +1,6 @@
{ {
"name": "@babel/plugin-codemod-object-assign-to-object-spread", "name": "@babel/plugin-codemod-object-assign-to-object-spread",
"version": "7.7.4", "version": "7.0.0",
"description": "Transforms Object.assign into object spread syntax", "description": "Transforms Object.assign into object spread syntax",
"repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-object-assign-to-object-spread", "repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-object-assign-to-object-spread",
"license": "MIT", "license": "MIT",
@ -13,13 +13,16 @@
"@babel/plugin" "@babel/plugin"
], ],
"dependencies": { "dependencies": {
"@babel/plugin-syntax-object-rest-spread": "^7.7.4" "@babel/plugin-syntax-object-rest-spread": "^7.0.0"
}, },
"peerDependencies": { "peerDependencies": {
"@babel/core": "^7.0.0-0 || csx" "@babel/core": "^7.0.0-0 || csx"
}, },
"devDependencies": { "devDependencies": {
"@babel/core": "^7.7.4", "@babel/core": "^7.0.0",
"@babel/helper-plugin-test-runner": "^7.7.4" "@babel/helper-plugin-test-runner": "^7.0.0"
},
"publishConfig": {
"access": "public"
} }
} }

View File

@ -1,6 +1,6 @@
{ {
"name": "@babel/plugin-codemod-optional-catch-binding", "name": "@babel/plugin-codemod-optional-catch-binding",
"version": "7.7.4", "version": "7.0.0",
"description": "Remove unused catch bindings", "description": "Remove unused catch bindings",
"repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-remove-unused-catch-binding", "repository": "https://github.com/babel/babel/tree/master/codemods/babel-plugin-codemod-remove-unused-catch-binding",
"license": "MIT", "license": "MIT",
@ -13,13 +13,13 @@
"@babel/plugin" "@babel/plugin"
], ],
"dependencies": { "dependencies": {
"@babel/plugin-syntax-optional-catch-binding": "^7.7.4" "@babel/plugin-syntax-optional-catch-binding": "^7.0.0"
}, },
"peerDependencies": { "peerDependencies": {
"@babel/core": "^7.0.0-0 || csx" "@babel/core": "^7.0.0-0 || csx"
}, },
"devDependencies": { "devDependencies": {
"@babel/core": "^7.7.4", "@babel/core": "^7.0.0",
"@babel/helper-plugin-test-runner": "^7.7.4" "@babel/helper-plugin-test-runner": "^7.0.0"
} }
} }

View File

@ -1,3 +1,3 @@
{ {
"plugins": ["../../../../lib"] "plugins": ["../../../../lib"]
} }

View File

@ -1,4 +0,0 @@
src
test
.*
*.log

View File

@ -1,4 +0,0 @@
## @babel/eslint-config-internal
---
ESLint config for the Babel codebase (originally taken from `eslint-config-kittens`)

View File

@ -1,49 +0,0 @@
"use strict";
module.exports = {
parser: "babel-eslint",
extends: "eslint:recommended",
plugins: ["flowtype"],
parserOptions: {
ecmaVersion: 2020,
sourceType: "module",
},
globals: {
// Flow
Iterator: true,
$Keys: true,
},
env: {
node: true,
es2020: true,
browser: true,
},
rules: {
camelcase: "off",
"consistent-return": "off",
curly: ["error", "multi-line"],
"linebreak-style": ["error", "unix"],
"new-cap": "off",
"no-case-declarations": "error",
"no-cond-assign": "off",
"no-confusing-arrow": "error",
"no-console": "off",
"no-constant-condition": "off",
"no-empty": "off",
"no-fallthrough": "off",
"no-inner-declarations": "off",
"no-labels": "off",
"no-loop-func": "off",
"no-process-exit": "off",
"no-return-assign": "off",
"no-shadow": "off",
"no-underscore-dangle": "off",
"no-unreachable": "off",
"no-use-before-define": "off",
"no-var": "error",
"prefer-const": "error",
strict: "off",
"flowtype/define-flow-type": "warn",
"flowtype/use-flow-type": "warn",
},
};

View File

@ -1,15 +0,0 @@
{
"name": "@babel/eslint-config-internal",
"version": "7.8.3-csx.2",
"description": "The Babel Team's ESLint configuration. Since it's internal, it might not respect semver.",
"author": "Sebastian McKenzie <sebmck@gmail.com>",
"homepage": "https://babeljs.io/",
"license": "MIT",
"private": true,
"repository": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-config-internal",
"main": "lib/index.js",
"peerDependencies": {
"babel-eslint": "^10.0.0 || ^11.0.0-0",
"eslint-plugin-flowtype": "^3.0.0"
}
}

View File

@ -1,4 +0,0 @@
src
test
.*
*.log

View File

@ -1,124 +0,0 @@
# @babel/eslint-parser [![npm](https://img.shields.io/npm/v/@babel/eslint-parser.svg)](https://www.npmjs.com/package/@babel/eslint-parser) [![travis](https://img.shields.io/travis/babel/@babel/eslint-parser/master.svg)](https://travis-ci.org/babel/@babel/eslint-parser) [![npm-downloads](https://img.shields.io/npm/dm/@babel/eslint-parser.svg)](https://www.npmjs.com/package/@babel/eslint-parser)
**@babel/eslint-parser** allows you to lint **ALL** valid Babel code with the fantastic
[ESLint](https://github.com/eslint/eslint).
## When should I use @babel/eslint-parser?
ESLint's default parser and core rules [only support the latest final ECMAScript standard](https://github.com/eslint/eslint/blob/a675c89573836adaf108a932696b061946abf1e6/README.md#what-about-experimental-features) and do not support experimental (such as new features) and non-standard (such as Flow or TypeScript types) syntax provided by Babel. @babel/eslint-parser is a parser that allows ESLint to run on source code that is transformed by Babel.
**Note:** You only need to use @babel/parser-eslint if you are using Babel to transform your code. If this is not the case, please use the relevant parser for your chosen flavor of ECMAScript (note that the default parser supports all non-experimental syntax as well as JSX).
## How does it work?
ESLint allows for the use of [custom parsers](https://eslint.org/docs/developer-guide/working-with-custom-parsers). When using this plugin, your code is parsed by Babel's parser (using the configuration specified in your [Babel configuration file](https://babeljs.io/docs/en/configuration)) and the resulting AST is
transformed into an [ESTree](https://github.com/estree/estree)-compliant structure that ESLint can understand. All location info such as line numbers,
columns is also retained so you can track down errors with ease.
**Note:** ESLint's core rules do not support experimental syntax and may therefore not work as expected when using `@babel/eslint-parser`. Please use the companion [`@babel/eslint-plugin`](https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin) plugin for core rules that you have issues with.
## Usage
### Installation
```sh
$ npm install eslint @babel/core @babel/eslint-parser --save-dev
# or
$ yarn add eslint @babel/core @babel/eslint-parser -D
```
**Note:** @babel/eslint-parser requires `@babel/core@>=7.2.0` and a valid Babel configuration file to run. If you do not have this already set up, please see the [Babel Usage Guide](https://babeljs.io/docs/en/usage).
### Setup
To use @babel/eslint-parser, `"@babel/eslint-parser"` must be specified as the `parser` in your ESLint configuration file (see [here](https://eslint.org/docs/user-guide/configuring#specifying-parser) for more detailed information).
**.eslintrc.js**
```js
module.exports = {
parser: "@babel/eslint-parser",
};
```
With the parser set, your configuration can be configured as described in the [Configuring ESLint](https://eslint.org/docs/user-guide/configuring) documentation.
**Note:** The `parserOptions` described in the [official documentation](https://eslint.org/docs/user-guide/configuring#specifying-parser-options) are for the default parser and are not necessarily supported by @babel/eslint-parser. Please see the section directly below for supported `parserOptions`.
### Additional parser configuration
Additional configuration options can be set in your ESLint configuration under the `parserOptions` key. Please note that the `ecmaFeatures` config property may still be required for ESLint to work properly with features not in ECMAScript 5 by default.
- `requireConfigFile` (default `true`) can be set to `false` to allow @babel/eslint-parser to run on files that do not have a Babel configuration associated with them. This can be useful for linting files that are not transformed by Babel (such as tooling configuration files), though we recommend using the default parser via [glob-based configuration](https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns). Note: @babel/eslint-parser will not parse any experimental syntax when no configuration file is found.
- `sourceType` can be set to `"module"`(default) or `"script"` if your code isn't using ECMAScript modules.
- `allowImportExportEverywhere` (default `false`) can be set to `true` to allow import and export declarations to appear anywhere a statement is allowed if your build environment supports that. Otherwise import and export declarations can only appear at a program's top level.
- `ecmaFeatures.globalReturn` (default `false`) allow return statements in the global scope when used with `sourceType: "script"`.
- `babelOptions` passes through Babel's configuration [loading](https://babeljs.io/docs/en/options#config-loading-options) and [merging](https://babeljs.io/docs/en/options#config-merging-options) options (for instance, in case of a monorepo). When not defined, @babel/eslint-parser will use Babel's default configuration file resolution logic.
**.eslintrc.js**
```js
module.exports = {
parser: "@babel/eslint-parser",
parserOptions: {
sourceType: "module",
allowImportExportEverywhere: false,
ecmaFeatures: {
globalReturn: false,
},
babelOptions: {
configFile: "path/to/config.js",
},
},
};
```
**.eslintrc.js using glob-based configuration**
This configuration would use the default parser for all files except for those found by the `"files/transformed/by/babel/*.js"` glob.
```js
module.exports = {
rules: {
indent: "error"
},
overrides: [
{
files: ["files/transformed/by/babel/*.js"],
parser: "@babel/eslint-parser",
}
]
};
```
### Run
```sh
$ ./node_modules/.bin/eslint yourfile.js
```
## Known issues
Flow:
> Check out [eslint-plugin-flowtype](https://github.com/gajus/eslint-plugin-flowtype): An `eslint` plugin that makes flow type annotations global variables and marks declarations as used. Solves the problem of false positives with `no-undef` and `no-unused-vars`.
- `no-undef` for global flow types: `ReactElement`, `ReactClass` [#130](https://github.com/babel/@babel/eslint-parser/issues/130#issuecomment-111215076)
- Workaround: define types as globals in `.eslintrc` or define types and import them `import type ReactElement from './types'`
- `no-unused-vars/no-undef` with Flow declarations (`declare module A {}`) [#132](https://github.com/babel/@babel/eslint-parser/issues/132#issuecomment-112815926)
Modules/strict mode
- `no-unused-vars: ["error", { vars: local }]` [#136](https://github.com/babel/@babel/eslint-parser/issues/136)
Please check out [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) for React/JSX issues.
- `no-unused-vars` with jsx
Please check out [eslint-plugin-babel](https://github.com/babel/eslint-plugin-babel) for other issues.
## Questions and support
If you have an issue, please first check if it can be reproduced with the default parser and with the latest versions of `eslint` and `@babel/eslint-parser`. If it is not reproducible with the default parser, it is most likely an issue with `@babel/eslint-parser`.
For questions and support please visit the [`#discussion`](https://babeljs.slack.com/messages/discussion/) Babel Slack channel (sign up [here](https://github.com/babel/notes/issues/38)) or the ESLint [Gitter](https://gitter.im/eslint/eslint).

View File

@ -1,37 +0,0 @@
{
"name": "@babel/eslint-parser",
"version": "7.8.3-csx.2",
"description": "ESLint parser that allows for linting of experimental syntax transformed by Babel",
"author": "Sebastian McKenzie <sebmck@gmail.com>",
"license": "MIT",
"private": true,
"repository": {
"type": "git",
"url": "https://github.com/babel/babel.git",
"directory": "eslint/babel-eslint-parser"
},
"bugs": {
"url": "https://github.com/babel/babel/issues"
},
"homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-parser",
"engines": {
"node": ">=10.9"
},
"main": "lib/index.js",
"peerDependencies": {
"@babel/core": ">=7.2.0",
"eslint": ">=6.0.0"
},
"dependencies": {
"eslint-scope": "5.0.0",
"eslint-visitor-keys": "^1.1.0",
"semver": "^6.3.0"
},
"devDependencies": {
"@babel/core": "^7.2.0",
"@babel/eslint-shared-fixtures": "7.8.3-csx.2",
"dedent": "^0.7.0",
"eslint": "^6.0.1",
"espree": "^6.0.0"
}
}

View File

@ -1,344 +0,0 @@
import { types as t } from "@babel/core";
import escope from "eslint-scope";
import { Definition } from "eslint-scope/lib/definition";
import OriginalPatternVisitor from "eslint-scope/lib/pattern-visitor";
import OriginalReferencer from "eslint-scope/lib/referencer";
import { getKeys as fallback } from "eslint-visitor-keys";
import childVisitorKeys from "./visitor-keys";
const flowFlippedAliasKeys = t.FLIPPED_ALIAS_KEYS.Flow.concat([
"ArrayPattern",
"ClassDeclaration",
"ClassExpression",
"FunctionDeclaration",
"FunctionExpression",
"Identifier",
"ObjectPattern",
"RestElement",
]);
const visitorKeysMap = Object.entries(t.VISITOR_KEYS).reduce(
(acc, [key, value]) => {
if (!flowFlippedAliasKeys.includes(value)) {
acc[key] = value;
}
return acc;
},
{},
);
const propertyTypes = {
// loops
callProperties: { type: "loop", values: ["value"] },
indexers: { type: "loop", values: ["key", "value"] },
properties: { type: "loop", values: ["argument", "value"] },
types: { type: "loop" },
params: { type: "loop" },
// single property
argument: { type: "single" },
elementType: { type: "single" },
qualification: { type: "single" },
rest: { type: "single" },
returnType: { type: "single" },
// others
typeAnnotation: { type: "typeAnnotation" },
typeParameters: { type: "typeParameters" },
id: { type: "id" },
};
class PatternVisitor extends OriginalPatternVisitor {
ArrayPattern(node) {
node.elements.forEach(this.visit, this);
}
ObjectPattern(node) {
node.properties.forEach(this.visit, this);
}
}
class Referencer extends OriginalReferencer {
// inherits.
visitPattern(node, options, callback) {
if (!node) {
return;
}
// Visit type annotations.
this._checkIdentifierOrVisit(node.typeAnnotation);
if (t.isAssignmentPattern(node)) {
this._checkIdentifierOrVisit(node.left.typeAnnotation);
}
// Overwrite `super.visitPattern(node, options, callback)` in order to not visit `ArrayPattern#typeAnnotation` and `ObjectPattern#typeAnnotation`.
if (typeof options === "function") {
callback = options;
options = { processRightHandNodes: false };
}
const visitor = new PatternVisitor(this.options, node, callback);
visitor.visit(node);
// Process the right hand nodes recursively.
if (options.processRightHandNodes) {
visitor.rightHandNodes.forEach(this.visit, this);
}
}
// inherits.
visitClass(node) {
// Decorators.
this._visitArray(node.decorators);
// Flow type parameters.
const typeParamScope = this._nestTypeParamScope(node);
// Flow super types.
this._visitTypeAnnotation(node.implements);
this._visitTypeAnnotation(
node.superTypeParameters && node.superTypeParameters.params,
);
// Basic.
super.visitClass(node);
// Close the type parameter scope.
if (typeParamScope) {
this.close(node);
}
}
// inherits.
visitFunction(node) {
const typeParamScope = this._nestTypeParamScope(node);
// Flow return types.
this._checkIdentifierOrVisit(node.returnType);
// Basic.
super.visitFunction(node);
// Close the type parameter scope.
if (typeParamScope) {
this.close(node);
}
}
// inherits.
visitProperty(node) {
if (node.value?.type === "TypeCastExpression") {
this._visitTypeAnnotation(node.value);
}
this._visitArray(node.decorators);
super.visitProperty(node);
}
InterfaceDeclaration(node) {
this._createScopeVariable(node, node.id);
const typeParamScope = this._nestTypeParamScope(node);
// TODO: Handle mixins
this._visitArray(node.extends);
this.visit(node.body);
if (typeParamScope) {
this.close(node);
}
}
TypeAlias(node) {
this._createScopeVariable(node, node.id);
const typeParamScope = this._nestTypeParamScope(node);
this.visit(node.right);
if (typeParamScope) {
this.close(node);
}
}
ClassProperty(node) {
this._visitClassProperty(node);
}
ClassPrivateProperty(node) {
this._visitClassProperty(node);
}
// TODO: Update to visit type annotations when TypeScript/Flow support this syntax.
ClassPrivateMethod(node) {
super.MethodDefinition(node);
}
DeclareModule(node) {
this._visitDeclareX(node);
}
DeclareFunction(node) {
this._visitDeclareX(node);
}
DeclareVariable(node) {
this._visitDeclareX(node);
}
DeclareClass(node) {
this._visitDeclareX(node);
}
// visit OptionalMemberExpression as a MemberExpression.
OptionalMemberExpression(node) {
super.MemberExpression(node);
}
_visitClassProperty(node) {
this._visitTypeAnnotation(node.typeAnnotation);
this.visitProperty(node);
}
_visitDeclareX(node) {
if (node.id) {
this._createScopeVariable(node, node.id);
}
const typeParamScope = this._nestTypeParamScope(node);
if (typeParamScope) {
this.close(node);
}
}
_createScopeVariable(node, name) {
this.currentScope().variableScope.__define(
name,
new Definition("Variable", name, node, null, null, null),
);
}
_nestTypeParamScope(node) {
if (!node.typeParameters) {
return null;
}
const parentScope = this.scopeManager.__currentScope;
const scope = new escope.Scope(
this.scopeManager,
"type-parameters",
parentScope,
node,
false,
);
this.scopeManager.__nestScope(scope);
for (let j = 0; j < node.typeParameters.params.length; j++) {
const name = node.typeParameters.params[j];
scope.__define(name, new Definition("TypeParameter", name, name));
if (name.typeAnnotation) {
this._checkIdentifierOrVisit(name);
}
}
scope.__define = function() {
return parentScope.__define.apply(parentScope, arguments);
};
return scope;
}
_visitTypeAnnotation(node) {
if (!node) {
return;
}
if (Array.isArray(node)) {
node.forEach(this._visitTypeAnnotation, this);
return;
}
// get property to check (params, id, etc...)
const visitorValues = visitorKeysMap[node.type];
if (!visitorValues) {
return;
}
// can have multiple properties
for (let i = 0; i < visitorValues.length; i++) {
const visitorValue = visitorValues[i];
const propertyType = propertyTypes[visitorValue];
const nodeProperty = node[visitorValue];
// check if property or type is defined
if (propertyType == null || nodeProperty == null) {
continue;
}
if (propertyType.type === "loop") {
for (let j = 0; j < nodeProperty.length; j++) {
if (Array.isArray(propertyType.values)) {
for (let k = 0; k < propertyType.values.length; k++) {
const loopPropertyNode = nodeProperty[j][propertyType.values[k]];
if (loopPropertyNode) {
this._checkIdentifierOrVisit(loopPropertyNode);
}
}
} else {
this._checkIdentifierOrVisit(nodeProperty[j]);
}
}
} else if (propertyType.type === "single") {
this._checkIdentifierOrVisit(nodeProperty);
} else if (propertyType.type === "typeAnnotation") {
this._visitTypeAnnotation(node.typeAnnotation);
} else if (propertyType.type === "typeParameters") {
for (let l = 0; l < node.typeParameters.params.length; l++) {
this._checkIdentifierOrVisit(node.typeParameters.params[l]);
}
} else if (propertyType.type === "id") {
if (node.id.type === "Identifier") {
this._checkIdentifierOrVisit(node.id);
} else {
this._visitTypeAnnotation(node.id);
}
}
}
}
_checkIdentifierOrVisit(node) {
if (node?.typeAnnotation) {
this._visitTypeAnnotation(node.typeAnnotation);
} else if (node?.type === "Identifier") {
this.visit(node);
} else {
this._visitTypeAnnotation(node);
}
}
_visitArray(nodeList) {
if (nodeList) {
for (const node of nodeList) {
this.visit(node);
}
}
}
}
export default function(ast, parserOptions) {
const options = {
ignoreEval: true,
optimistic: false,
directive: false,
nodejsScope:
ast.sourceType === "script" &&
(parserOptions.ecmaFeatures &&
parserOptions.ecmaFeatures.globalReturn) === true,
impliedStrict: false,
sourceType: ast.sourceType,
ecmaVersion: parserOptions.ecmaVersion,
fallback,
};
options.childVisitorKeys = childVisitorKeys;
const scopeManager = new escope.ScopeManager(options);
const referencer = new Referencer(options, scopeManager);
referencer.visit(ast);
return scopeManager;
}

View File

@ -1,96 +0,0 @@
import { types as t, traverse } from "@babel/core";
import convertProgramNode from "./convertProgramNode";
const astTransformVisitor = {
noScope: true,
enter(path) {
const node = path.node;
// private var to track original node type
node._babelType = node.type;
if (node.innerComments) {
delete node.innerComments;
}
if (node.trailingComments) {
delete node.trailingComments;
}
if (node.leadingComments) {
delete node.leadingComments;
}
},
exit(path) {
const node = path.node;
if (path.isTypeParameter()) {
node.type = "Identifier";
node.typeAnnotation = node.bound;
delete node.bound;
}
// flow: prevent "no-undef"
// for "Component" in: "let x: React.Component"
if (path.isQualifiedTypeIdentifier()) {
delete node.id;
}
// for "b" in: "var a: { b: Foo }"
if (path.isObjectTypeProperty()) {
delete node.key;
}
// for "indexer" in: "var a: {[indexer: string]: number}"
if (path.isObjectTypeIndexer()) {
delete node.id;
}
// for "param" in: "var a: { func(param: Foo): Bar };"
if (path.isFunctionTypeParam()) {
delete node.name;
}
// modules
if (path.isImportDeclaration()) {
delete node.isType;
}
// template string range fixes
if (path.isTemplateLiteral()) {
for (let i = 0; i < node.quasis.length; i++) {
const q = node.quasis[i];
q.range[0] -= 1;
if (q.tail) {
q.range[1] += 1;
} else {
q.range[1] += 2;
}
q.loc.start.column -= 1;
if (q.tail) {
q.loc.end.column += 1;
} else {
q.loc.end.column += 2;
}
}
}
},
};
export default function(ast, code) {
const state = { source: code };
// Monkey patch visitor keys in order to be able to traverse the estree nodes
t.VISITOR_KEYS.Property = t.VISITOR_KEYS.ObjectProperty;
t.VISITOR_KEYS.MethodDefinition = [
"key",
"value",
"decorators",
"returnType",
"typeParameters",
];
traverse(ast, astTransformVisitor, null, state);
delete t.VISITOR_KEYS.Property;
delete t.VISITOR_KEYS.MethodDefinition;
convertProgramNode(ast);
}

View File

@ -1,15 +0,0 @@
export default function(comments) {
for (let i = 0; i < comments.length; i++) {
const comment = comments[i];
if (comment.type === "CommentBlock") {
comment.type = "Block";
} else if (comment.type === "CommentLine") {
comment.type = "Line";
}
// sometimes comments don't get ranges computed,
// even with options.ranges === true
if (!comment.range) {
comment.range = [comment.start, comment.end];
}
}
}

View File

@ -1,38 +0,0 @@
export default function(ast) {
ast.type = "Program";
ast.sourceType = ast.program.sourceType;
ast.directives = ast.program.directives;
ast.body = ast.program.body;
delete ast.program;
if (ast.comments.length) {
const lastComment = ast.comments[ast.comments.length - 1];
if (!ast.tokens.length) {
// if no tokens, the program starts at the end of the last comment
ast.start = lastComment.end;
ast.loc.start.line = lastComment.loc.end.line;
ast.loc.start.column = lastComment.loc.end.column;
} else {
const lastToken = ast.tokens[ast.tokens.length - 1];
if (lastComment.end > lastToken.end) {
// If there is a comment after the last token, the program ends at the
// last token and not the comment
ast.range[1] = lastToken.end;
ast.loc.end.line = lastToken.loc.end.line;
ast.loc.end.column = lastToken.loc.end.column;
}
}
} else {
if (!ast.tokens.length) {
ast.loc.start.line = 1;
ast.loc.end.line = 1;
}
}
if (ast.body && ast.body.length > 0) {
ast.loc.start.line = ast.body[0].loc.start.line;
ast.range[0] = ast.body[0].start;
}
}

View File

@ -1,92 +0,0 @@
import { tokTypes as tt } from "@babel/core";
export default function(tokens) {
let curlyBrace = null;
let templateTokens = [];
const result = [];
function addTemplateType() {
const start = templateTokens[0];
const end = templateTokens[templateTokens.length - 1];
const value = templateTokens.reduce((result, token) => {
if (token.value) {
result += token.value;
} else if (token.type !== tt.template) {
result += token.type.label;
}
return result;
}, "");
result.push({
type: "Template",
value: value,
start: start.start,
end: end.end,
loc: {
start: start.loc.start,
end: end.loc.end,
},
});
templateTokens = [];
}
tokens.forEach(token => {
switch (token.type) {
case tt.backQuote:
if (curlyBrace) {
result.push(curlyBrace);
curlyBrace = null;
}
templateTokens.push(token);
if (templateTokens.length > 1) {
addTemplateType();
}
break;
case tt.dollarBraceL:
templateTokens.push(token);
addTemplateType();
break;
case tt.braceR:
if (curlyBrace) {
result.push(curlyBrace);
}
curlyBrace = token;
break;
case tt.template:
if (curlyBrace) {
templateTokens.push(curlyBrace);
curlyBrace = null;
}
templateTokens.push(token);
break;
case tt.eof:
if (curlyBrace) {
result.push(curlyBrace);
}
break;
default:
if (curlyBrace) {
result.push(curlyBrace);
curlyBrace = null;
}
result.push(token);
}
});
return result;
}

View File

@ -1,88 +0,0 @@
import { tokTypes as tt } from "@babel/core";
export default function(token, source) {
const type = token.type;
token.range = [token.start, token.end];
if (type === tt.name) {
token.type = "Identifier";
} else if (
type === tt.semi ||
type === tt.comma ||
type === tt.parenL ||
type === tt.parenR ||
type === tt.braceL ||
type === tt.braceR ||
type === tt.slash ||
type === tt.dot ||
type === tt.bracketL ||
type === tt.bracketR ||
type === tt.ellipsis ||
type === tt.arrow ||
type === tt.pipeline ||
type === tt.star ||
type === tt.incDec ||
type === tt.colon ||
type === tt.question ||
type === tt.questionDot ||
type === tt.template ||
type === tt.backQuote ||
type === tt.dollarBraceL ||
type === tt.at ||
type === tt.logicalOR ||
type === tt.logicalAND ||
type === tt.nullishCoalescing ||
type === tt.bitwiseOR ||
type === tt.bitwiseXOR ||
type === tt.bitwiseAND ||
type === tt.equality ||
type === tt.relational ||
type === tt.bitShift ||
type === tt.plusMin ||
type === tt.modulo ||
type === tt.exponent ||
type === tt.bang ||
type === tt.tilde ||
type === tt.doubleColon ||
type === tt.hash ||
type.isAssign
) {
token.type = "Punctuator";
if (!token.value) token.value = type.label;
} else if (type === tt.jsxTagStart) {
token.type = "Punctuator";
token.value = "<";
} else if (type === tt.jsxTagEnd) {
token.type = "Punctuator";
token.value = ">";
} else if (type === tt.jsxName) {
token.type = "JSXIdentifier";
} else if (type === tt.jsxText) {
token.type = "JSXText";
} else if (type.keyword === "null") {
token.type = "Null";
} else if (type.keyword === "false" || type.keyword === "true") {
token.type = "Boolean";
} else if (type.keyword) {
token.type = "Keyword";
} else if (type === tt.num) {
token.type = "Numeric";
token.value = source.slice(token.start, token.end);
} else if (type === tt.string) {
token.type = "String";
token.value = source.slice(token.start, token.end);
} else if (type === tt.regexp) {
token.type = "RegularExpression";
const value = token.value;
token.regex = {
pattern: value.pattern,
flags: value.flags,
};
token.value = `/${value.pattern}/${value.flags}`;
} else if (type === tt.bigint) {
token.type = "Numeric";
token.value = `${token.value}n`;
}
return token;
}

View File

@ -1,8 +0,0 @@
import convertTemplateType from "./convertTemplateType";
import convertToken from "./convertToken";
export default function(tokens, code) {
return convertTemplateType(tokens)
.filter(t => t.type !== "CommentLine" && t.type !== "CommentBlock")
.map(t => convertToken(t, code));
}

View File

@ -1,9 +0,0 @@
import convertTokens from "./convertTokens";
import convertComments from "./convertComments";
import convertAST from "./convertAST";
export default function(ast, code) {
ast.tokens = convertTokens(ast.tokens, code);
convertComments(ast.comments);
convertAST(ast, code);
}

View File

@ -1,61 +0,0 @@
import { loadPartialConfig } from "@babel/core";
export function normalizeESLintConfig(options) {
const defaultOptions = {
babelOptions: {},
ecmaVersion: 2020,
sourceType: "module",
allowImportExportEverywhere: false,
};
return Object.assign(defaultOptions, options);
}
export function normalizeBabelParseConfig(options) {
const parseOptions = {
sourceType: options.sourceType,
filename: options.filePath,
cwd: options.babelOptions.cwd,
root: options.babelOptions.root,
rootMode: options.babelOptions.rootMode,
envName: options.babelOptions.envName,
configFile: options.babelOptions.configFile,
babelrc: options.babelOptions.babelrc,
babelrcRoots: options.babelOptions.babelrcRoots,
extends: options.babelOptions.extends,
env: options.babelOptions.env,
overrides: options.babelOptions.overrides,
test: options.babelOptions.test,
include: options.babelOptions.include,
exclude: options.babelOptions.exclude,
ignore: options.babelOptions.ignore,
only: options.babelOptions.only,
parserOpts: {
allowImportExportEverywhere: options.allowImportExportEverywhere,
allowReturnOutsideFunction: true,
allowSuperOutsideMethod: true,
ranges: true,
tokens: true,
plugins: ["estree"],
},
caller: {
name: "@babel/eslint-parser",
},
};
if (options.requireConfigFile !== false) {
const config = loadPartialConfig(parseOptions);
if (config !== null) {
if (!config.hasFilesystemConfig()) {
throw new Error(
`No Babel config file detected for ${config.options.filename}. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files.`,
);
}
return config.options;
}
}
return parseOptions;
}

View File

@ -1,26 +0,0 @@
import semver from "semver";
import { version as CURRENT_BABEL_VERSION } from "@babel/core";
import parseWithScope from "./parse-with-scope";
import { normalizeESLintConfig } from "./configuration";
import packageJson from "../package.json";
const SUPPORTED_BABEL_VERSION_RANGE =
packageJson.peerDependencies["@babel/core"];
const IS_RUNNING_SUPPORTED_VERSION = semver.satisfies(
semver.coerce(CURRENT_BABEL_VERSION).raw,
SUPPORTED_BABEL_VERSION_RANGE,
);
export function parse(code, options) {
return parseForESLint(code, options).ast;
}
export function parseForESLint(code, options = {}) {
if (!IS_RUNNING_SUPPORTED_VERSION) {
throw new Error(
`babel-eslint@${packageJson.version} does not support @babel/core@${CURRENT_BABEL_VERSION}. Please downgrade to babel-eslint@^10 or upgrade to @babel/core@${SUPPORTED_BABEL_VERSION_RANGE}`,
);
}
return parseWithScope(code, normalizeESLintConfig(options));
}

View File

@ -1,10 +0,0 @@
import visitorKeys from "./visitor-keys";
import analyzeScope from "./analyze-scope";
import parse from "./parse";
export default function(code, options) {
const ast = parse(code, options);
const scopeManager = analyzeScope(ast, options);
return { ast, scopeManager, visitorKeys };
}

View File

@ -1,23 +0,0 @@
import { parseSync as babelParse } from "@babel/core";
import babylonToEspree from "./babylon-to-espree";
import { normalizeBabelParseConfig } from "./configuration";
export default function parse(code, options) {
const parseOptions = normalizeBabelParseConfig(options);
let ast;
try {
ast = babelParse(code, parseOptions);
} catch (err) {
if (err instanceof SyntaxError) {
err.lineNumber = err.loc.line;
err.column = err.loc.column;
}
throw err;
}
babylonToEspree(ast, code);
return ast;
}

View File

@ -1,15 +0,0 @@
import { types as t } from "@babel/core";
import { KEYS as ESLINT_VISITOR_KEYS } from "eslint-visitor-keys";
const { VISITOR_KEYS: BABEL_VISITOR_KEYS } = t;
export default Object.assign(
{
Literal: ESLINT_VISITOR_KEYS.Literal,
MethodDefinition: ["decorators"].concat(
ESLINT_VISITOR_KEYS.MethodDefinition,
),
Property: ["decorators"].concat(ESLINT_VISITOR_KEYS.Property),
},
BABEL_VISITOR_KEYS,
);

View File

@ -1,535 +0,0 @@
import assert from "assert";
import espree from "espree";
import escope from "eslint-scope";
import unpad from "dedent";
import { parseForESLint } from "../src";
import assertImplementsAST from "./helpers/assert-implements-ast";
const babelOptions = {
configFile: require.resolve(
"@babel/eslint-shared-fixtures/config/babel.config.js",
),
};
function parseAndAssertSame(code) {
code = unpad(code);
const esAST = espree.parse(code, {
ecmaFeatures: {
// enable JSX parsing
jsx: true,
// enable return in global scope
globalReturn: true,
// enable implied strict mode (if ecmaVersion >= 5)
impliedStrict: true,
// allow experimental object rest/spread
experimentalObjectRestSpread: true,
},
tokens: true,
loc: true,
range: true,
comment: true,
ecmaVersion: 2020,
sourceType: "module",
});
const babylonAST = parseForESLint(code, {
eslintVisitorKeys: true,
eslintScopeManager: true,
babelOptions,
}).ast;
assertImplementsAST(esAST, babylonAST);
}
describe("babylon-to-espree", () => {
describe("compatibility", () => {
it("should allow ast.analyze to be called without options", function() {
const esAST = parseForESLint("`test`", {
eslintScopeManager: true,
eslintVisitorKeys: true,
babelOptions,
}).ast;
expect(() => {
escope.analyze(esAST);
}).not.toThrow(new TypeError("Should allow no options argument."));
});
});
describe("templates", () => {
it("empty template string", () => {
parseAndAssertSame("``");
});
it("template string", () => {
parseAndAssertSame("`test`");
});
it("template string using $", () => {
parseAndAssertSame("`$`");
});
it("template string with expression", () => {
parseAndAssertSame("`${a}`");
});
it("template string with multiple expressions", () => {
parseAndAssertSame("`${a}${b}${c}`");
});
it("template string with expression and strings", () => {
parseAndAssertSame("`a${a}a`");
});
it("template string with binary expression", () => {
parseAndAssertSame("`a${a + b}a`");
});
it("tagged template", () => {
parseAndAssertSame("jsx`<Button>Click</Button>`");
});
it("tagged template with expression", () => {
parseAndAssertSame("jsx`<Button>Hi ${name}</Button>`");
});
it("tagged template with new operator", () => {
parseAndAssertSame("new raw`42`");
});
it("template with nested function/object", () => {
parseAndAssertSame(
"`outer${{x: {y: 10}}}bar${`nested${function(){return 1;}}endnest`}end`",
);
});
it("template with braces inside and outside of template string #96", () => {
parseAndAssertSame(
"if (a) { var target = `{}a:${webpackPort}{}}}}`; } else { app.use(); }",
);
});
it("template also with braces #96", () => {
parseAndAssertSame(`
export default function f1() {
function f2(foo) {
const bar = 3;
return \`\${foo} \${bar}\`;
}
return f2;
}
`);
});
it("template with destructuring #31", () => {
parseAndAssertSame(`
module.exports = {
render() {
var {name} = this.props;
return Math.max(null, \`Name: \${name}, Name: \${name}\`);
}
};
`);
});
it("template with arrow returning template #603", () => {
parseAndAssertSame(`
var a = \`\${() => {
\`\${''}\`
}}\`;
`);
});
it("template string with object with template string inside", () => {
parseAndAssertSame("`${ { a:`${2}` } }`");
});
});
it("simple expression", () => {
parseAndAssertSame("a = 1");
});
it("logical NOT", () => {
parseAndAssertSame("!0");
});
it("bitwise NOT", () => {
parseAndAssertSame("~0");
});
it("class declaration", () => {
parseAndAssertSame("class Foo {}");
});
it("class expression", () => {
parseAndAssertSame("var a = class Foo {}");
});
it("jsx expression", () => {
parseAndAssertSame("<App />");
});
it("jsx expression with 'this' as identifier", () => {
parseAndAssertSame("<this />");
});
it("jsx expression with a dynamic attribute", () => {
parseAndAssertSame("<App foo={bar} />");
});
it("jsx expression with a member expression as identifier", () => {
parseAndAssertSame("<foo.bar />");
});
it("jsx expression with spread", () => {
parseAndAssertSame("var myDivElement = <div {...this.props} />;");
});
it("empty jsx text", () => {
parseAndAssertSame("<a></a>");
});
it("jsx text with content", () => {
parseAndAssertSame("<a>Hello, world!</a>");
});
it("nested jsx", () => {
parseAndAssertSame("<div>\n<h1>Wat</h1>\n</div>");
});
it("default import", () => {
parseAndAssertSame('import foo from "foo";');
});
it("import specifier", () => {
parseAndAssertSame('import { foo } from "foo";');
});
it("import specifier with name", () => {
parseAndAssertSame('import { foo as bar } from "foo";');
});
it("import bare", () => {
parseAndAssertSame('import "foo";');
});
it("export default class declaration", () => {
parseAndAssertSame("export default class Foo {}");
});
it("export default class expression", () => {
parseAndAssertSame("export default class {}");
});
it("export default function declaration", () => {
parseAndAssertSame("export default function Foo() {}");
});
it("export default function expression", () => {
parseAndAssertSame("export default function () {}");
});
it("export all", () => {
parseAndAssertSame('export * from "foo";');
});
it("export named", () => {
parseAndAssertSame("var foo = 1;export { foo };");
});
it("export named alias", () => {
parseAndAssertSame("var foo = 1;export { foo as bar };");
});
// Espree doesn't support the optional chaining operator yet
it("optional chaining operator (token)", () => {
const code = "foo?.bar";
const babylonAST = parseForESLint(code, {
eslintVisitorKeys: true,
eslintScopeManager: true,
babelOptions,
}).ast;
assert.strictEqual(babylonAST.tokens[1].type, "Punctuator");
});
// Espree doesn't support the nullish coalescing operator yet
it("nullish coalescing operator (token)", () => {
const code = "foo ?? bar";
const babylonAST = parseForESLint(code, {
eslintVisitorKeys: true,
eslintScopeManager: true,
babelOptions,
}).ast;
assert.strictEqual(babylonAST.tokens[1].type, "Punctuator");
});
// Espree doesn't support the pipeline operator yet
it("pipeline operator (token)", () => {
const code = "foo |> bar";
const babylonAST = parseForESLint(code, {
eslintVisitorKeys: true,
eslintScopeManager: true,
babelOptions,
}).ast;
assert.strictEqual(babylonAST.tokens[1].type, "Punctuator");
});
// Espree doesn't support private fields yet
it("hash (token)", () => {
const code = "class A { #x }";
const babylonAST = parseForESLint(code, {
eslintVisitorKeys: true,
eslintScopeManager: true,
babelOptions,
}).ast;
assert.strictEqual(babylonAST.tokens[3].type, "Punctuator");
assert.strictEqual(babylonAST.tokens[3].value, "#");
});
it.skip("empty program with line comment", () => {
parseAndAssertSame("// single comment");
});
it.skip("empty program with block comment", () => {
parseAndAssertSame(" /* multiline\n * comment\n*/");
});
it("line comments", () => {
parseAndAssertSame(`
// single comment
var foo = 15; // comment next to statement
// second comment after statement
`);
});
it("block comments", () => {
parseAndAssertSame(`
/* single comment */
var foo = 15; /* comment next to statement */
/*
* multiline
* comment
*/
`);
});
it("block comments #124", () => {
parseAndAssertSame(`
React.createClass({
render() {
// return (
// <div />
// ); // <-- this is the line that is reported
}
});
`);
});
it("null", () => {
parseAndAssertSame("null");
});
it("boolean", () => {
parseAndAssertSame("if (true) {} else if (false) {}");
});
it("regexp", () => {
parseAndAssertSame("/affix-top|affix-bottom|affix|[a-z]/");
});
it("regexp", () => {
parseAndAssertSame("const foo = /foo/;");
});
it("regexp y flag", () => {
parseAndAssertSame("const foo = /foo/y;");
});
it("regexp u flag", () => {
parseAndAssertSame("const foo = /foo/u;");
});
it("regexp in a template string", () => {
parseAndAssertSame('`${/\\d/.exec("1")[0]}`');
});
it("first line is empty", () => {
parseAndAssertSame('\nimport Immutable from "immutable";');
});
it("empty", () => {
parseAndAssertSame("");
});
it("jsdoc", () => {
parseAndAssertSame(`
/**
* @param {object} options
* @return {number}
*/
const test = function({ a, b, c }) {
return a + b + c;
};
module.exports = test;
`);
});
it("empty block with comment", () => {
parseAndAssertSame(`
function a () {
try {
b();
} catch (e) {
// asdf
}
}
`);
});
describe("babel tests", () => {
it("MethodDefinition", () => {
parseAndAssertSame(`
export default class A {
a() {}
}
`);
});
it("MethodDefinition 2", () => {
parseAndAssertSame(
"export default class Bar { get bar() { return 42; }}",
);
});
it("ClassMethod", () => {
parseAndAssertSame(`
class A {
constructor() {
}
}
`);
});
it("ClassMethod multiple params", () => {
parseAndAssertSame(`
class A {
constructor(a, b, c) {
}
}
`);
});
it("ClassMethod multiline", () => {
parseAndAssertSame(`
class A {
constructor (
a,
b,
c
)
{
}
}
`);
});
it("ClassMethod oneline", () => {
parseAndAssertSame("class A { constructor(a, b, c) {} }");
});
it("ObjectMethod", () => {
parseAndAssertSame(`
var a = {
b(c) {
}
}
`);
});
it("do not allow import export everywhere", () => {
assert.throws(() => {
parseAndAssertSame('function F() { import a from "a"; }');
}, /SyntaxError: 'import' and 'export' may only appear at the top level/);
});
it("return outside function", () => {
parseAndAssertSame("return;");
});
it("super outside method", () => {
assert.throws(() => {
parseAndAssertSame("function F() { super(); }");
}, /SyntaxError: 'super' keyword outside a method/);
});
it("StringLiteral", () => {
parseAndAssertSame("");
parseAndAssertSame("");
parseAndAssertSame("a");
});
it("getters and setters", () => {
parseAndAssertSame("class A { get x ( ) { ; } }");
parseAndAssertSame(`
class A {
get x(
)
{
;
}
}
`);
parseAndAssertSame("class A { set x (a) { ; } }");
parseAndAssertSame(`
class A {
set x(a
)
{
;
}
}
`);
parseAndAssertSame(`
var B = {
get x () {
return this.ecks;
},
set x (ecks) {
this.ecks = ecks;
}
};
`);
});
it("RestOperator", () => {
parseAndAssertSame("var { a, ...b } = c");
parseAndAssertSame("var [ a, ...b ] = c");
parseAndAssertSame("var a = function (...b) {}");
});
it("SpreadOperator", () => {
parseAndAssertSame("var a = { b, ...c }");
parseAndAssertSame("var a = [ a, ...b ]");
parseAndAssertSame("var a = sum(...b)");
});
it("Async/Await", () => {
parseAndAssertSame(`
async function a() {
await 1;
}
`);
});
it("BigInt", () => {
parseAndAssertSame(`
const a = 1n;
`);
});
it("Dynamic Import", () => {
parseAndAssertSame(`
const a = import('a');
`);
});
});
});

View File

@ -1,11 +0,0 @@
root: true
# babel-eslint
parser: ../../../lib/index.js
# use eslint-plugin-import
plugins:
- import
rules:
import/no-named-as-default: error
no-unused-vars: error

View File

@ -1 +0,0 @@
export default function foo() { }

View File

@ -1 +0,0 @@
import foo from './a.js';

View File

@ -1,4 +0,0 @@
// @flow
type Foo = {};
const FlowTypeButton = ({ }: Foo) => { };

View File

@ -1,3 +0,0 @@
function x () {
"use strict";
}

View File

@ -1 +0,0 @@
function x () {}

View File

@ -1,5 +0,0 @@
"use strict";
function x () {
"use strict";
}

View File

@ -1,3 +0,0 @@
"use strict";
function x () {}

View File

@ -1,6 +0,0 @@
"use strict";
/*
The empty statement is intentional. As of now, ESLint won't enforce
string: [2, "global"] on a program with an empty body. A test for that without
massaging the AST to ESlint's input format should fail.
*/

View File

@ -1 +0,0 @@
"no use strict anywhere";

View File

@ -1,6 +0,0 @@
class ClassName {
constructor() {
},
aMethod() {}
}

View File

@ -1,40 +0,0 @@
// Checks if the source ast implements the target ast. Ignores extra keys on source ast
export default function assertImplementsAST(target, source, path) {
if (!path) {
path = [];
}
function error(text) {
const err = new Error(`At ${path.join(".")}: ${text}:`);
err.depth = path.length + 1;
throw err;
}
const typeA = target === null ? "null" : typeof target;
const typeB = source === null ? "null" : typeof source;
if (typeA !== typeB) {
error(
`have different types (${typeA} !== ${typeB}) (${target} !== ${source})`,
);
} else if (
typeA === "object" &&
["RegExp"].indexOf(target.constructor.name) !== -1 &&
target.constructor.name !== source.constructor.name
) {
error(
`object have different constructors (${target.constructor.name} !== ${source.constructor.name}`,
);
} else if (typeA === "object") {
const keysTarget = Object.keys(target);
for (const i in keysTarget) {
const key = keysTarget[i];
path.push(key);
assertImplementsAST(target[key], source[key], path);
path.pop();
}
} else if (target !== source) {
error(
`are different (${JSON.stringify(target)} !== ${JSON.stringify(source)})`,
);
}
}

View File

@ -1,237 +0,0 @@
import eslint from "eslint";
import fs from "fs";
import path from "path";
import * as parser from "../src";
eslint.linter.defineParser("current-babel-eslint", parser);
const paths = {
fixtures: path.join(__dirname, "fixtures", "rules"),
};
const encoding = "utf8";
const errorLevel = 2;
const baseEslintOpts = {
parser: "current-babel-eslint",
parserOptions: {
sourceType: "script",
requireConfigFile: false,
babelOptions: { configFile: false }
},
};
/**
* Load a fixture and run eslint.linter.verify() on it.
* Pass the return value to done().
* @param object opts
* @param function done
*/
function lint(opts, done) {
readFixture(opts.fixture, (err, src) => {
if (err) return done(err);
done(null, eslint.linter.verify(src, opts.eslint));
});
}
/**
* Read a fixture file, passing the content to done().
* @param string|array id
* @param function done
*/
function readFixture(id, done) {
if (Array.isArray(id)) id = path.join.apply(path, id);
if (!path.extname(id)) id += ".js";
fs.readFile(path.join(paths.fixtures, id), encoding, done);
}
// readFixture
describe("Rules:", () => {
describe("`strict`", strictSuite);
});
// describe
function strictSuite() {
const ruleId = "strict";
describe("when set to 'never'", () => {
const eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {},
});
eslintOpts.rules[ruleId] = [errorLevel, "never"];
["global-with", "function-with"].forEach(fixture => {
it(`should error on ${fixture.match(/^[^-]+/)[0]} directive`, done => {
lint(
{
fixture: ["strict", fixture],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report[0].ruleId).toBe(ruleId);
done();
},
);
});
// it
});
});
// describe
describe("when set to 'global'", () => {
const eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {},
});
eslintOpts.rules[ruleId] = [errorLevel, "global"];
it("shouldn't error on single global directive", done => {
lint(
{
fixture: ["strict", "global-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report.length).toBe(0);
done();
},
);
});
// it
it("should error twice on global directive: no and function directive: yes", done => {
lint(
{
fixture: ["strict", "function-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
[0, 1].forEach(i => {
expect(report[0].ruleId).toBe(ruleId);
});
done();
},
);
});
// it
it("should error on function directive", done => {
lint(
{
fixture: ["strict", "global-with-function-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report[0].ruleId).toBe(ruleId);
// This is to make sure the test fails prior to adapting Babel AST
// directive representation to ESLint format. Otherwise it reports an
// error for missing global directive that masquerades as the expected
// result of the previous assertion.
expect(report[0].nodeType).not.toBe("Program");
done();
},
);
});
// it
it("should error on no directive", done => {
lint(
{
fixture: ["strict", "none"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report[0].ruleId).toBe(ruleId);
done();
},
);
});
// it
});
// describe
describe("when set to 'function'", () => {
const eslintOpts = Object.assign({}, baseEslintOpts, {
rules: {},
});
eslintOpts.rules[ruleId] = [errorLevel, "function"];
it("shouldn't error on single function directive", done => {
lint(
{
fixture: ["strict", "function-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report.length).toBe(0);
done();
},
);
});
// it
it("should error twice on function directive: no and global directive: yes", done => {
lint(
{
fixture: ["strict", "global-with-function-without"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
[0, 1].forEach(i => {
expect(report[i].ruleId).toBe(ruleId);
});
done();
},
);
});
// it
it("should error on only global directive", done => {
lint(
{
fixture: ["strict", "global-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report[0].ruleId).toBe(ruleId);
done();
},
);
});
// it
it("should error on extraneous global directive", done => {
lint(
{
fixture: ["strict", "global-with-function-with"],
eslint: eslintOpts,
},
(err, report) => {
if (err) return done(err);
expect(report[0].ruleId).toBe(ruleId);
expect(report[0].nodeType.indexOf("Function")).toBe(-1);
done();
},
);
});
// it
});
}
describe("https://github.com/babel/babel-eslint/issues/558", () => {
it("doesn't crash with eslint-plugin-import", () => {
const engine = new eslint.CLIEngine({ ignore: false });
const files = ["a.js", "b.js", "c.js"];
let fileWithPath = files.map(file =>
path.resolve(__dirname, `./fixtures/eslint-plugin-import/${file}`),
);
engine.executeOnFiles(fileWithPath);
});
});

File diff suppressed because it is too large Load Diff

View File

@ -1,4 +0,0 @@
src
test
.*
*.log

View File

@ -1,38 +0,0 @@
# @babel/eslint-plugin-development
A set of eslint rules to enforce best practices in the development of Babel plugins.
## Installation
You'll first need to install [ESLint](http://eslint.org):
```
$ npm install --save-dev eslint
```
Next, install `@babel/eslint-plugin-development`:
```
$ npm install --save-dev @babel/eslint-plugin-development
```
Then, load the plugin in your `.eslintrc` configuration file. You can omit the `eslint-plugin-` prefix:
```json
{
"plugins": ["@babel/development"]
}
```
## Supported Rules
> Note: Rules marked with :wrench: are autofixable.
* `@babel/development/no-deprecated-clone` (:wrench:): Disallows using the deprecated
`t.clone(node)` and `t.cloneDeep(node)` methods from `@babel/types`. Those
calls are replaced with `t.cloneNode(node)` when using `eslint --fix`.
* `@babel/development/no-undefined-identifier`: Disallows using
`t.identifier("undefined")` to create a node which represents an `undefined`
value, since it might cause problem if `undefined` is redeclared.
* `@babel/development/plugin-name`: Requires plugins to have a `name` property, which
can be useful for debugging purposes.

View File

@ -1,36 +0,0 @@
{
"name": "@babel/eslint-plugin-development",
"version": "7.8.3-csx.2",
"description": "ESLint rules that enforce best practices in the development of Babel plugins.",
"private": true,
"keywords": [
"eslint",
"eslintplugin",
"eslint-plugin"
],
"author": {
"name": "Nicolò Ribaudo",
"email": "nicolo.ribaudo@gmail.com",
"url": "https://github.com/nicolo-ribaudo"
},
"main": "lib/index.js",
"devDependencies": {
"eslint": "^5.9.0"
},
"engines": {
"node": ">=10.9"
},
"publishConfig": {
"access": "public"
},
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/babel/babel.git",
"directory": "eslint/babel-eslint-plugin-development"
},
"bugs": {
"url": "https://github.com/babel/babel/issues"
},
"homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin-development"
}

View File

@ -1,11 +0,0 @@
import noDeprecatedClone from "./rules/no-deprecated-clone";
import noUndefinedIdentifier from "./rules/no-undefined-identifier";
import pluginName from "./rules/plugin-name";
export default {
rules: {
"no-deprecated-clone": noDeprecatedClone,
"no-undefined-identifier": noUndefinedIdentifier,
"plugin-name": pluginName,
},
};

View File

@ -1,39 +0,0 @@
import getReferenceOrigin from "../utils/get-reference-origin";
import isFromBabelTypes from "../utils/is-from-babel-types";
export default {
meta: {
schema: [],
fixable: "code",
},
create(context) {
return {
CallExpression(node) {
const { callee } = node;
const scope = context.getScope();
const origin = getReferenceOrigin(callee, scope);
if (!origin) return;
const { name } = origin;
if (
(name === "clone" || name === "cloneDeep") &&
isFromBabelTypes(origin, scope)
) {
const isMemberExpression = callee.type === "MemberExpression";
const id = isMemberExpression ? callee.property : callee;
context.report({
node: id,
message: `t.${name}() is deprecated. Use t.cloneNode() instead.`,
fix(fixer) {
if (isMemberExpression) {
return fixer.replaceText(id, "cloneNode");
}
},
});
}
},
};
},
};

View File

@ -1,39 +0,0 @@
import getReferenceOrigin from "../utils/get-reference-origin";
import isFromBabelTypes from "../utils/is-from-babel-types";
function firstArgumentIsUndefinedString(argumentsArray) {
return (
argumentsArray.length > 0 &&
argumentsArray[0].type === "Literal" &&
argumentsArray[0].value === "undefined"
);
}
export default {
meta: {
schema: [],
},
create(context) {
return {
CallExpression(node) {
const { callee } = node;
const scope = context.getScope();
const origin = getReferenceOrigin(callee, scope);
if (!origin) return;
const { name } = origin;
if (
(name === "identifier" || name === "Identifier") &&
firstArgumentIsUndefinedString(node.arguments) &&
isFromBabelTypes(origin, scope)
) {
context.report(
node,
"Use path.scope.buildUndefinedNode() to create an undefined identifier directly.",
);
}
},
};
},
};

View File

@ -1,50 +0,0 @@
import isBabelPluginFactory from "../utils/is-babel-plugin-factory";
function getReturnValue(node) {
const { body } = node;
if (body.type === "BlockStatement") {
const returnNode = body.body.find(n => n.type === "ReturnStatement");
return returnNode && returnNode.argument;
}
// Arrow functions with implicit return
return body;
}
export default {
meta: {
schema: [],
},
create(context /*: Context */) {
let pluginFound = false;
return {
FunctionDeclaration: functionVisitor,
FunctionExpression: functionVisitor,
ArrowFunctionExpression: functionVisitor,
"Program:exit"(node) {
if (!pluginFound) {
context.report(node, "This file does not export a Babel plugin.");
}
},
};
function functionVisitor(node) {
if (!isBabelPluginFactory(node, context.getScope())) return;
const returnValue = getReturnValue(node);
if (!returnValue || returnValue.type !== "ObjectExpression") return;
pluginFound = true;
if (!returnValue.properties.some(p => p.key.name === "name")) {
context.report(
returnValue,
"This Babel plugin doesn't have a 'name' property.",
);
}
}
},
};

View File

@ -1,22 +0,0 @@
export default function getExportName(node) {
const { parent } = node;
if (parent.type === "ExportDefaultDeclaration") {
return "default";
}
if (parent.type === "ExportNamedDeclaration") {
return node.id.name;
}
if (
parent.type === "AssignmentExpression" &&
parent.left.type === "MemberExpression" &&
parent.left.object.type === "Identifier" &&
parent.left.object.name === "module" &&
parent.left.property.type === "Identifier" &&
parent.left.property.name === "exports"
) {
return "module.exports";
}
}

View File

@ -1,141 +0,0 @@
/*::
type ReferenceOriginImport = { kind: "import", source: string, name: string };
type ReferenceOriginParam = {
kind: "param",
index: number,
functionNode: Node,
};
type ReferenceOrigin =
| ReferenceOriginImport
| ReferenceOriginParam
| { kind: "import *", source: string }
| {
kind: "property",
base: ReferenceOriginImport | ReferenceOriginParam,
path: string,
name: string,
};
*/
// Given a node and a context, returns a description of where its value comes
// from.
// It resolves imports, parameters of exported functions and property accesses.
// See the ReferenceOrigin type for more informations.
export default function getReferenceOrigin(
node,
scope,
) /*: ?ReferenceOrigin */ {
if (node.type === "Identifier") {
const variable = getVariableDefinition(node.name, scope);
if (!variable) return null;
const definition = variable.definition;
const defNode = definition.node;
if (definition.type === "ImportBinding") {
if (defNode.type === "ImportSpecifier") {
return {
kind: "import",
source: definition.parent.source.value,
name: defNode.imported.name,
};
}
if (defNode.type === "ImportNamespaceSpecifier") {
return {
kind: "import *",
source: definition.parent.source.value,
};
}
}
if (definition.type === "Variable" && defNode.init) {
const origin = getReferenceOrigin(defNode.init, variable.scope);
return origin && patternToProperty(definition.name, origin);
}
if (definition.type === "Parameter") {
return patternToProperty(definition.name, {
kind: "param",
index: definition.index,
functionNode: definition.node,
});
}
}
if (node.type === "MemberExpression" && !node.computed) {
const origin = getReferenceOrigin(node.object, scope);
return origin && addProperty(origin, node.property.name);
}
return null;
}
function getVariableDefinition(name, scope) {
let currentScope = scope;
do {
const variable = currentScope.set.get(name);
if (variable && variable.defs[0]) {
return { scope: currentScope, definition: variable.defs[0] };
}
} while ((currentScope = currentScope.upper));
}
function patternToProperty(id, base) {
const path = getPatternPath(id);
return path && path.reduce(addProperty, base);
}
// Adds a property to a given origin. If it was a namespace import it becomes
// a named import, so that `import * as x from "foo"; x.bar` and
// `import { bar } from "foo"` have the same origin.
function addProperty(origin, name) {
if (origin.kind === "import *") {
return {
kind: "import",
source: origin.source,
name,
};
}
if (origin.kind === "property") {
return {
kind: "property",
base: origin.base,
path: origin.path + "." + name,
name,
};
}
return {
kind: "property",
base: origin,
path: name,
name,
};
}
// if "node" is c of { a: { b: c } }, the result is ["a","b"]
function getPatternPath(node) {
let current = node;
const path = [];
// Unshift keys to path while going up
do {
const property = current.parent;
if (
property.type === "ArrayPattern" ||
property.type === "AssignmentPattern" ||
property.computed
) {
// These nodes are not supported.
return null;
}
if (property.type === "Property") {
path.unshift(property.key.name);
} else {
// The destructuring pattern is finished
break;
}
} while ((current = current.parent.parent));
return path;
}

View File

@ -1,24 +0,0 @@
import getReferenceOrigin from "./get-reference-origin";
import getExportName from "./get-export-name";
export default function isBabelPluginFactory(node, scope) {
const { parent } = node;
if (parent.type === "CallExpression") {
const calleeOrigin = getReferenceOrigin(parent.callee, scope);
// Using "declare" from "@babel/helper-plugin-utils"
return !!(
calleeOrigin &&
calleeOrigin.kind === "import" &&
calleeOrigin.name === "declare" &&
calleeOrigin.source === "@babel/helper-plugin-utils"
);
}
const exportName = getExportName(node);
// export default function ({ types: t }) {}
// module.exports = function ({ types: t }) {}
return exportName === "default" || exportName === "module.exports";
}

View File

@ -1,33 +0,0 @@
import isBabelPluginFactory from "./is-babel-plugin-factory";
// Check if a ReferenceOrigin (returned by ./get-reference-origin.js)
// is a reference to a @babel/types export.
export default function isFromBabelTypes(
origin /*: ReferenceOrigin */,
scope /*: Scope */,
) {
if (origin.kind === "import" && origin.source === "@babel/types") {
// imported from @babel/types
return true;
}
if (
origin.kind === "property" &&
origin.base.kind === "import" &&
origin.base.name === "types" &&
origin.base.source === "@babel/core"
) {
// imported from @babel/core
return true;
}
if (
origin.kind === "property" &&
origin.base.kind === "param" &&
origin.base.index === 0
) {
return isBabelPluginFactory(origin.base.functionNode, scope);
}
return false;
}

View File

@ -1,136 +0,0 @@
import rule from "../../src/rules/no-deprecated-clone";
import { RuleTester } from "eslint";
const cloneError = "t.clone() is deprecated. Use t.cloneNode() instead.";
const cloneDeepError =
"t.cloneDeep() is deprecated. Use t.cloneNode() instead.";
const ruleTester = new RuleTester({
parserOptions: { sourceType: "module" },
});
ruleTester.run("no-deprecated-clone", rule, {
valid: [
`_.clone(obj)`,
`_.cloneDeep(obj)`,
`import * as t from "lib"; t.clone();`,
`import * as t from "lib"; t.cloneDeep();`,
`function f(_) { _.types.clone(); }`,
`function f(_) { _.types.cloneDeep(); }`,
`import * as t from "@babel/types"; t.cloneNode();`,
],
invalid: [
{
code: `import { clone } from "@babel/types"; clone();`,
errors: [cloneError],
},
{
code: `import { cloneDeep } from "@babel/types"; cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `import { clone } from "@babel/types"; var clone2 = clone; clone2();`,
errors: [cloneError],
},
{
code: `import { cloneDeep } from "@babel/types"; var cloneDeep2 = cloneDeep; cloneDeep2();`,
errors: [cloneDeepError],
},
{
code: `import * as t from "@babel/types"; t.clone();`,
errors: [cloneError],
},
{
code: `import * as t from "@babel/types"; t.cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `import * as t from "@babel/types"; var { clone } = t; clone();`,
errors: [cloneError],
},
{
code: `import * as t from "@babel/types"; var { cloneDeep } = t; cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `import { clone as c } from "@babel/types"; c();`,
errors: [cloneError],
},
{
code: `import { cloneDeep as cD } from "@babel/types"; cD();`,
errors: [cloneDeepError],
},
{
code: `import * as babel from "@babel/core"; babel.types.clone();`,
errors: [cloneError],
},
{
code: `import * as babel from "@babel/core"; babel.types.cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `import { types } from "@babel/core"; types.clone();`,
errors: [cloneError],
},
{
code: `import { types } from "@babel/core"; types.cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `import { types as t } from "@babel/core"; t.clone();`,
errors: [cloneError],
},
{
code: `import { types as t } from "@babel/core"; t.cloneDeep();`,
errors: [cloneDeepError],
},
{
code: `export default function plugin(babel) { babel.types.clone() }`,
errors: [cloneError],
},
{
code: `export default function plugin(babel) { babel.types.cloneDeep() }`,
errors: [cloneDeepError],
},
{
code: `export default function plugin({ types }) { types.clone() }`,
errors: [cloneError],
},
{
code: `export default function plugin({ types }) { types.cloneDeep() }`,
errors: [cloneDeepError],
},
{
code: `export default function plugin({ types: t }) { t.clone() }`,
errors: [cloneError],
},
{
code: `export default function plugin({ types: t }) { t.cloneDeep() }`,
errors: [cloneDeepError],
},
{
code: `export default ({ types }) => { types.clone() }`,
errors: [cloneError],
},
{
code: `export default ({ types }) => { types.cloneDeep() }`,
errors: [cloneDeepError],
},
{
code: `module.exports = function plugin({ types }) { types.clone() }`,
errors: [cloneError],
},
{
code: `module.exports = function plugin({ types }) { types.cloneDeep() }`,
errors: [cloneDeepError],
},
{
code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.clone() });`,
errors: [cloneError],
},
{
code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.cloneDeep() });`,
errors: [cloneDeepError],
},
],
});

View File

@ -1,78 +0,0 @@
import rule from "../../src/rules/no-undefined-identifier";
import { RuleTester } from "eslint";
const error =
"Use path.scope.buildUndefinedNode() to create an undefined identifier directly.";
const ruleTester = new RuleTester({
parserOptions: { sourceType: "module" },
});
ruleTester.run("no-undefined-identifier", rule, {
valid: [
`_.identifier("undefined")`,
`_.Identifier("undefined")`,
`import * as t from "lib"; t.identifier("undefined");`,
`function f(_) { _.types.identifier("undefined"); }`,
`import * as t from "@babel/types"; t.identifier("not_undefined");`,
`path.scope.buildUndefinedNode();`,
],
invalid: [
{
code: `import { identifier } from "@babel/types"; identifier("undefined");`,
errors: [error],
},
{
code: `import { Identifier } from "@babel/types"; Identifier("undefined");`,
errors: [error],
},
{
code: `import * as t from "@babel/types"; t.identifier("undefined");`,
errors: [error],
},
{
code: `import * as t from "@babel/types"; var { identifier } = t; identifier("undefined");`,
errors: [error],
},
{
code: `import { identifier as id } from "@babel/types"; id("undefined");`,
errors: [error],
},
{
code: `import * as babel from "@babel/core"; babel.types.identifier("undefined");`,
errors: [error],
},
{
code: `import { types } from "@babel/core"; types.identifier("undefined");`,
errors: [error],
},
{
code: `import { types as t } from "@babel/core"; t.identifier("undefined");`,
errors: [error],
},
{
code: `export default function plugin(babel) { babel.types.identifier("undefined") }`,
errors: [error],
},
{
code: `export default function plugin({ types }) { types.identifier("undefined") }`,
errors: [error],
},
{
code: `export default function plugin({ types: t }) { t.identifier("undefined") }`,
errors: [error],
},
{
code: `export default ({ types }) => { types.identifier("undefined") }`,
errors: [error],
},
{
code: `module.exports = function plugin({ types }) { types.identifier("undefined") }`,
errors: [error],
},
{
code: `import { declare } from "@babel/helper-plugin-utils"; declare(({ types }) => { types.identifier("undefined") });`,
errors: [error],
},
],
});

View File

@ -1,52 +0,0 @@
import rule from "../../src/rules/plugin-name";
import { RuleTester } from "eslint";
const missingPluginError = "This file does not export a Babel plugin.";
const missingNameError = "This Babel plugin doesn't have a 'name' property.";
const ruleTester = new RuleTester({
parserOptions: { sourceType: "module" },
});
ruleTester.run("plugin-name", rule, {
valid: [
`export default function () { return { name: "test-plugin" } }`,
`import { declare } from "@babel/helper-plugin-utils"; declare(() => { return { name: "test-plugin" } })`,
`import { declare } from "@babel/helper-plugin-utils"; declare(() => ({ name: "test-plugin" }))`,
`module.exports = function () { return { name: "foo" }; }`,
],
invalid: [
{
code: `function fn() { return { name: "foo" } }`,
errors: [missingPluginError],
},
{
code: `export function fn() { return { name: "foo" } }`,
errors: [missingPluginError],
},
{
code: `(function fn() { return { name: "foo" } })`,
errors: [missingPluginError],
},
{
code: `() => { return { name: "foo" } }`,
errors: [missingPluginError],
},
{
code: `export default function fn() {}`,
errors: [missingPluginError],
},
{
code: `export default function fn() { return {} }`,
errors: [missingNameError],
},
{
code: `import { declare } from "@babel/helper-plugin-utils"; declare(() => ({}))`,
errors: [missingNameError],
},
{
code: `module.exports = function () { return {} }`,
errors: [missingNameError],
},
],
});

View File

@ -1,4 +0,0 @@
src
test
.*
*.log

View File

@ -1,23 +0,0 @@
Copyright (c) 2014-2015 Jason Quense <jason@quense.me>
Original work by respective rule authors; copywrites noted in files.
MIT License
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

View File

@ -1,47 +0,0 @@
# @babel/eslint-plugin
Companion rules for `@babel/eslint-parser`. `@babel/eslint-parser` does a great job at adapting `eslint`
for use with Babel, but it can't change the built-in rules to support experimental features.
`@babel/eslint-plugin` re-implements problematic rules so they do not give false positives or negatives.
> Requires Node 10.9 or greater
### Install
```sh
npm install @babel/eslint-plugin --save-dev
```
Load the plugin in your `.eslintrc.json` file:
```json
{
"plugins": ["@babel/eslint-plugin"]
}
```
Finally enable all the rules you would like to use (remember to disable the
original ones as well!).
```json
{
"rules": {
"babel/new-cap": "error",
"babel/no-invalid-this": "error",
"babel/no-unused-expressions": "error",
"babel/object-curly-spacing": "error",
"babel/semi": "error",
}
}
```
### Rules
Each rule corresponds to a core `eslint` rule and has the same options.
🛠: means it's autofixable with `--fix`.
- `babel/new-cap`: handles decorators (`@Decorator`)
- `babel/no-invalid-this`: handles class fields and private class methods (`class A { a = this.b; }`)
- `babel/no-unused-expressions`: handles `do` expressions
- `babel/object-curly-spacing`: handles `export * as x from "mod";` (🛠)
- `babel/semi`: Handles class properties (🛠)

View File

@ -1,41 +0,0 @@
{
"name": "@babel/eslint-plugin",
"version": "7.8.3-csx.2",
"description": "Companion rules for @babel/eslint-parser",
"main": "lib/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/babel/babel.git",
"directory": "eslint/babel-eslint-plugin"
},
"keywords": [
"babel",
"eslint",
"eslintplugin",
"eslint-plugin",
"babel-eslint"
],
"author": "Jason Quense @monasticpanic",
"license": "MIT",
"private": true,
"engines": {
"node": ">=10.9"
},
"bugs": {
"url": "https://github.com/babel/babel/issues"
},
"homepage": "https://github.com/babel/babel/tree/master/eslint/babel-eslint-plugin",
"peerDependencies": {
"@babel/eslint-parser": "0.0.0",
"eslint": ">=6.0.0"
},
"dependencies": {
"eslint-rule-composer": "^0.3.0"
},
"devDependencies": {
"@babel/eslint-parser": "7.8.3-csx.2",
"@babel/eslint-shared-fixtures": "7.8.3-csx.2",
"eslint": "^6.0.0",
"lodash.clonedeep": "^4.5.0"
}
}

View File

@ -1,22 +0,0 @@
import newCap from "./rules/new-cap";
import noInvalidThis from "./rules/no-invalid-this";
import noUnusedExpressions from "./rules/no-unused-expressions";
import objectCurlySpacing from "./rules/object-curly-spacing";
import semi from "./rules/semi";
module.exports = {
rules: {
"new-cap": newCap,
"no-invalid-this": noInvalidThis,
"no-unused-expressions": noUnusedExpressions,
"object-curly-spacing": objectCurlySpacing,
semi,
},
rulesConfig: {
"new-cap": "off",
"no-invalid-this": "off",
"no-unused-expressions": "off",
"object-curly-spacing": "off",
semi: "off",
},
};

View File

@ -1,18 +0,0 @@
import ruleComposer from "eslint-rule-composer";
import eslint from "eslint";
const rule = new eslint.Linter().getRules().get("new-cap");
/**
* Returns whether a node is under a decorator or not.
* @param {ASTNode} node CallExpression node
* @returns {Boolean} Returns true if the node is under a decorator.
*/
function isDecorator(node) {
return node.parent.type === "Decorator";
}
export default ruleComposer.filterReports(
rule,
problem => !isDecorator(problem.node),
);

View File

@ -1,20 +0,0 @@
import ruleComposer from "eslint-rule-composer";
import eslint from "eslint";
const noInvalidThisRule = new eslint.Linter().getRules().get("no-invalid-this");
export default ruleComposer.filterReports(noInvalidThisRule, problem => {
let inClassProperty = false;
let node = problem.node;
while (node) {
if (node.type === "ClassProperty" || node.type === "ClassPrivateProperty") {
inClassProperty = true;
return;
}
node = node.parent;
}
return !inClassProperty;
});

View File

@ -1,64 +0,0 @@
import ruleComposer from "eslint-rule-composer";
import eslint from "eslint";
const rule = new eslint.Linter().getRules().get("no-unused-expressions");
/**
* @param {ASTNode} node - any node
* @returns {boolean} whether the given node is either an IfStatement or an
* ExpressionStatement and is the last node in the body of a BlockStatement
*/
function isFinalStatementInBlockStatement(node) {
const parent = node.parent;
return (
/^(?:If|Expression)Statement$/.test(node.type) &&
parent.type === "BlockStatement" &&
parent.body[parent.body.length - 1] === node
);
}
/**
* @param {ASTNode} node - any node
* @returns {boolean} whether the given node represents an unbroken chain of
* tail ExpressionStatements and IfStatements within a DoExpression
* https://github.com/tc39/proposal-do-expressions
*/
function isInDoStatement(node) {
if (!node) return false;
if (node.type === "DoExpression") return true;
// this is an `else if`
if (
node.type === "IfStatement" &&
node.parent &&
node.parent.type === "IfStatement"
) {
return isInDoStatement(node.parent);
}
if (isFinalStatementInBlockStatement(node)) {
return isInDoStatement(node.parent.parent);
}
return false;
}
/**
* @param {ASTNode} node - any node
* @returns {boolean} whether the given node is an optional call expression,
* https://github.com/tc39/proposal-optional-chaining
*/
function isOptionalCallExpression(node) {
return (
!!node &&
node.type === "ExpressionStatement" &&
node.expression.type === "OptionalCallExpression"
);
}
export default ruleComposer.filterReports(
rule,
problem =>
!isInDoStatement(problem.node) && !isOptionalCallExpression(problem.node),
);

View File

@ -1,20 +0,0 @@
import ruleComposer from "eslint-rule-composer";
import eslint from "eslint";
const rule = new eslint.Linter().getRules().get("object-curly-spacing");
export default ruleComposer.filterReports(rule, problem => {
const node = problem.node;
// Allow exportDefaultFrom syntax:
// export x from '...';
if (
node.type === "ExportNamedDeclaration" &&
node.specifiers.length === 1 &&
node.specifiers[0].type === "ExportDefaultSpecifier"
) {
return false;
}
return true;
});

View File

@ -1,105 +0,0 @@
import ruleComposer from "eslint-rule-composer";
import eslint from "eslint";
const OPT_OUT_PATTERN = /^[-[(/+`]/; // One of [(/+-`
const rule = new eslint.Linter().getRules().get("semi");
function isSemicolon(token) {
return token.type === "Punctuator" && token.value === ";";
}
function isUnnecessarySemicolon(context, lastToken) {
if (!isSemicolon(lastToken)) {
return false;
}
const nextToken = context.getSourceCode().getTokenAfter(lastToken);
if (!nextToken) {
return true;
}
const lastTokenLine = lastToken.loc.end.line;
const nextTokenLine = nextToken.loc.start.line;
const isOptOutToken =
OPT_OUT_PATTERN.test(nextToken.value) &&
nextToken.value !== "++" &&
nextToken.value !== "--";
const isDivider = nextToken.value === "}" || nextToken.value === ";";
return (lastTokenLine !== nextTokenLine && !isOptOutToken) || isDivider;
}
function isOneLinerBlock(context, node) {
const nextToken = context.getSourceCode().getTokenAfter(node);
if (!nextToken || nextToken.value !== "}") {
return false;
}
const parent = node.parent;
return (
parent &&
parent.type === "BlockStatement" &&
parent.loc.start.line === parent.loc.end.line
);
}
function report(context, node, missing) {
const lastToken = context.getSourceCode().getLastToken(node);
let message,
fix,
loc = lastToken.loc;
if (!missing) {
message = "Missing semicolon.";
loc = loc.end;
fix = function(fixer) {
return fixer.insertTextAfter(lastToken, ";");
};
} else {
message = "Extra semicolon.";
loc = loc.start;
fix = function(fixer) {
return fixer.remove(lastToken);
};
}
context.report({
node,
loc,
message,
fix,
});
}
export default ruleComposer.joinReports([
rule,
context => ({
ClassProperty(node) {
const options = context.options[1];
const exceptOneLine = options && options.omitLastInOneLineBlock === true;
const sourceCode = context.getSourceCode();
const lastToken = sourceCode.getLastToken(node);
if (context.options[0] === "never") {
if (isUnnecessarySemicolon(context, lastToken)) {
report(context, node, true);
}
} else {
if (!isSemicolon(lastToken)) {
if (!exceptOneLine || !isOneLinerBlock(context, node)) {
report(context, node);
}
} else {
if (exceptOneLine && isOneLinerBlock(context, node)) {
report(context, node, true);
}
}
}
},
}),
]);

View File

@ -1,14 +0,0 @@
import { RuleTester } from "eslint";
RuleTester.setDefaultConfig({
parser: require.resolve("@babel/eslint-parser"),
parserOptions: {
babelOptions: {
configFile: require.resolve(
"@babel/eslint-shared-fixtures/config/babel.config.js",
),
},
},
});
export default RuleTester;

View File

@ -1,12 +0,0 @@
import rule from "../../src/rules/new-cap";
import RuleTester from "../helpers/RuleTester";
const ruleTester = new RuleTester();
ruleTester.run("@babel/new-cap", rule, {
valid: [
{
code: "@MyDecorator(123) class MyClass{}",
},
],
invalid: [],
});

View File

@ -1,121 +0,0 @@
import cloneDeep from "lodash.clonedeep";
import rule from "../../src/rules/no-invalid-this";
import RuleTester from "../helpers/RuleTester";
/**
* A constant value for non strict mode environment.
* @returns {void}
*/
function NORMAL(pattern) {
pattern.parserOptions.sourceType = "script";
}
/**
* A constant value for strict mode environment.
* This modifies pattern object to make strict mode.
* @param {Object} pattern - A pattern object to modify.
* @returns {void}
*/
function USE_STRICT(pattern) {
pattern.code = '"use strict"; ' + pattern.code;
}
/**
* A constant value for implied strict mode.
* This modifies pattern object to impose strict mode.
* @param {Object} pattern - A pattern object to modify.
* @returns {void}
*/
function IMPLIED_STRICT(pattern) {
pattern.code = "/* implied strict mode */ " + pattern.code;
pattern.parserOptions.ecmaFeatures = pattern.parserOptions.ecmaFeatures || {};
pattern.parserOptions.ecmaFeatures.impliedStrict = true;
}
/**
* A constant value for modules environment.
* This modifies pattern object to make modules.
* @param {Object} pattern - A pattern object to modify.
* @returns {void}
*/
function MODULES(pattern) {
pattern.code = "/* modules */ " + pattern.code;
}
/**
* Extracts patterns each condition for a specified type. The type is `valid` or `invalid`.
* @param {Object[]} patterns - Original patterns.
* @param {string} type - One of `"valid"` or `"invalid"`.
* @returns {Object[]} Test patterns.
*/
function extractPatterns(patterns, type) {
// Clone and apply the pattern environment.
const patternsList = patterns.map(function(pattern) {
return pattern[type].map(function(applyCondition) {
const thisPattern = cloneDeep(pattern);
applyCondition(thisPattern);
if (type === "valid") {
thisPattern.errors = [];
} else {
thisPattern.code += " /* should error */";
}
delete thisPattern.invalid;
delete thisPattern.valid;
return thisPattern;
});
});
// Flatten.
return Array.prototype.concat.apply([], patternsList);
}
//------------------------------------------------------------------------------
// Tests
//------------------------------------------------------------------------------
const errors = [
{ message: "Unexpected 'this'.", type: "ThisExpression" },
{ message: "Unexpected 'this'.", type: "ThisExpression" },
];
const patterns = [
// Class private fields
{
code: "class A {a = this.b;};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: [],
},
{
code: "class A {a = () => {return this.b;};};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: [],
},
// Class Private methods
{
code: "class A {#a = this.b;};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: [],
},
{
code: "class A {#a = () => {return this.b;};};",
parserOptions: { ecmaVersion: 6 },
valid: [NORMAL, USE_STRICT, IMPLIED_STRICT, MODULES],
invalid: [],
},
];
const ruleTester = new RuleTester();
ruleTester.run("@babel/no-invalid-this", rule, {
valid: extractPatterns(patterns, "valid"),
invalid: extractPatterns(patterns, "invalid"),
});

View File

@ -1,37 +0,0 @@
import rule from "../../src/rules/no-unused-expressions";
import RuleTester from "../helpers/RuleTester";
const ruleTester = new RuleTester();
ruleTester.run("@babel/no-unused-expressions", rule, {
valid: [
"let a = do { if (foo) { foo.bar; } }",
"let a = do { foo; }",
"let a = do { let b = 2; foo; }",
"let a = do { (foo + 1); }",
"let a = do { if (foo) { if (foo.bar) { foo.bar; } } }",
"let a = do { if (foo) { if (foo.bar) { foo.bar; } else if (foo.baz) { foo.baz; } } }",
"foo.bar?.();",
],
invalid: [
{
code: "let a = do { foo; let b = 2; }",
errors: [
{
message:
"Expected an assignment or function call and instead saw an expression.",
type: "ExpressionStatement",
},
],
},
{
code: "let a = do { if (foo) { foo.bar } else { a; bar.foo } }",
errors: [
{
message:
"Expected an assignment or function call and instead saw an expression.",
type: "ExpressionStatement",
},
],
},
],
});

View File

@ -1,13 +0,0 @@
import rule from "../../src/rules/object-curly-spacing";
import RuleTester from "../helpers/RuleTester";
const ruleTester = new RuleTester();
ruleTester.run("@babel/object-curly-spacing", rule, {
valid: [
{
code: 'export x from "mod";',
},
],
invalid: [],
});

View File

@ -1,52 +0,0 @@
import rule from "../../src/rules/semi";
import RuleTester from "../helpers/RuleTester";
const ruleTester = new RuleTester();
ruleTester.run("semi", rule, {
valid: [
"class Foo { bar = 'example'; }",
"class Foo { static bar = 'example'; }",
{
code: "class Foo { bar = () => {}; }",
options: ["always", { omitLastInOneLineBlock: true }],
},
// never
{ code: "class Foo { bar = 'example' }", options: ["never"] },
{ code: "class Foo { static bar = 'example' }", options: ["never"] },
{ code: "class Foo { bar = () => {} }", options: ["never"] },
],
invalid: [
{
code: "class Foo { bar = 'example' }",
errors: [{ message: "Missing semicolon." }],
},
{
code: "class Foo { static bar = 'example' }",
errors: [{ message: "Missing semicolon." }],
},
{
code: "class Foo { bar = () => {} }",
options: ["always", { omitLastInOneLineBlock: true }],
errors: [{ message: "Missing semicolon." }],
},
// "never"
{
code: "class Foo { bar = 'example'; }",
options: ["never"],
errors: [{ message: "Extra semicolon." }],
},
{
code: "class Foo { static bar = 'example'; }",
options: ["never"],
errors: [{ message: "Extra semicolon." }],
},
{
code: "class Foo { bar = () => {}; }",
options: ["never"],
errors: [{ message: "Extra semicolon." }],
},
],
});

View File

@ -1,6 +0,0 @@
"use strict";
module.exports = {
presets: [["@babel/preset-env", { forceAllTransforms: true }]],
plugins: [["@babel/plugin-proposal-decorators", { legacy: true }]],
};

View File

@ -1,24 +0,0 @@
"use strict";
module.exports = {
presets: [
["@babel/preset-env", { forceAllTransforms: true }],
["@babel/preset-flow", { all: true }],
"@babel/preset-react",
],
plugins: [
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-syntax-import-meta",
"@babel/plugin-syntax-export-default-from",
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-nullish-coalescing-operator",
"@babel/plugin-proposal-optional-chaining",
"@babel/plugin-syntax-numeric-separator",
"@babel/plugin-syntax-export-namespace-from",
["@babel/plugin-proposal-decorators", { decoratorsBeforeExport: false }],
["@babel/plugin-proposal-pipeline-operator", { proposal: "minimal" }],
"@babel/plugin-syntax-bigint",
"@babel/plugin-proposal-private-methods",
"@babel/plugin-proposal-do-expressions",
],
};

View File

@ -1,25 +0,0 @@
{
"name": "@babel/eslint-shared-fixtures",
"version": "7.8.3-csx.2",
"description": "Shared fixtures for testing @babel/eslint-* packages",
"license": "MIT",
"private": true,
"dependencies": {
"@babel/plugin-proposal-class-properties": "^7.1.0",
"@babel/plugin-proposal-decorators": "^7.1.2",
"@babel/plugin-proposal-do-expressions": "^7.7.4",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.0.0",
"@babel/plugin-proposal-optional-chaining": "^7.0.0",
"@babel/plugin-proposal-pipeline-operator": "^7.0.0",
"@babel/plugin-proposal-private-methods": "^7.7.4",
"@babel/plugin-syntax-bigint": "^7.7.4",
"@babel/plugin-syntax-dynamic-import": "^7.0.0",
"@babel/plugin-syntax-export-default-from": "^7.0.0",
"@babel/plugin-syntax-export-namespace-from": "^7.0.0",
"@babel/plugin-syntax-import-meta": "^7.0.0",
"@babel/plugin-syntax-numeric-separator": "^7.0.0",
"@babel/preset-env": "^7.1.5",
"@babel/preset-flow": "^7.0.0",
"@babel/preset-react": "^7.0.0"
}
}

View File

@ -1,68 +0,0 @@
// These packages undet the @babel namespace aren't in this monorepo.
const externalBabelPackages = [
"plugin-syntax-async-generators",
"plugin-syntax-bigint",
"plugin-syntax-dynamic-import",
"plugin-syntax-json-strings",
"plugin-syntax-nullish-coalescing-operator",
"plugin-syntax-object-rest-spread",
"plugin-syntax-optional-catch-binding",
"plugin-syntax-optional-chaining",
];
// prettier-ignore
const monorepoPackagePattern =
`^@babel/(?!eslint-)(?!${externalBabelPackages.join("|")})([a-zA-Z0-9_-]+)$`;
module.exports = {
collectCoverageFrom: [
"packages/*/src/**/*.mjs",
"packages/*/src/**/*.js",
"codemods/*/src/**/*.mjs",
"codemods/*/src/**/*.js",
"eslint/*/src/**/*.mjs",
"eslint/*/src/**/*.js",
],
// The eslint/* packages use ESLint v6, which has dropped support for Node v6.
// TODO: Remove this process.version check in Babel 8.
testRegex: `./(packages|codemods${
/^v6./u.test(process.version) ? "" : "|eslint"
})/[^/]+/test/.+\\.m?js$`,
testPathIgnorePatterns: [
"/node_modules/",
"/test/fixtures/",
"/test/debug-fixtures/",
"/babel-parser/test/expressions/",
"/test/tmp/",
"/test/__data__/",
"/test/helpers/",
"<rootDir>/test/warning\\.js",
"<rootDir>/build/",
"_browser\\.js",
],
testEnvironment: "node",
setupFilesAfterEnv: ["<rootDir>/test/testSetupFile.js"],
transformIgnorePatterns: [
"/node_modules/",
"<rootDir>/packages/babel-standalone/babel(\\.min)?\\.js",
"<rootDir>/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
"/test/(fixtures|tmp|__data__)/",
"<rootDir>/(packages|codemods|eslint)/[^/]+/lib/",
],
coveragePathIgnorePatterns: [
"/node_modules/",
"<rootDir>/packages/babel-standalone/babel(\\.min)?\\.js",
"<rootDir>/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
"/test/(fixtures|tmp|__data__)/",
],
modulePathIgnorePatterns: [
"/test/fixtures/",
"/test/tmp/",
"/test/__data__/",
"<rootDir>/build/",
],
moduleNameMapper: {
[monorepoPackagePattern]: "<rootDir>/packages/babel-$1/",
"^@babel/eslint-([a-zA-Z0-9_-]+)$": "<rootDir>/eslint/babel-eslint-$1/",
},
};

View File

@ -1,5 +1,5 @@
{ {
"version": "7.8.3-csx.2", "version": "7.7.3",
"changelog": { "changelog": {
"repo": "babel/babel", "repo": "babel/babel",
"cacheDir": ".changelog", "cacheDir": ".changelog",
@ -11,8 +11,7 @@
"PR: Polish :nail_care:": ":nail_care: Polish", "PR: Polish :nail_care:": ":nail_care: Polish",
"PR: Docs :memo:": ":memo: Documentation", "PR: Docs :memo:": ":memo: Documentation",
"PR: Internal :house:": ":house: Internal", "PR: Internal :house:": ":house: Internal",
"PR: Performance :running_woman:": ":running_woman: Performance", "PR: Performance :running_woman:": ":running_woman: Performance"
"PR: Revert :leftwards_arrow_with_hook:": ":leftwards_arrow_with_hook: Revert"
} }
}, },
"command": { "command": {
@ -21,22 +20,21 @@
"*.md", "*.md",
"*.txt", "*.txt",
"test/**", "test/**",
"**/test/**",
"codemods/**", "codemods/**",
"# We ignore every JSON file, except for built-in-modules, built-ins and plugins defined in babel-preset-env/data.", "# We ignore every JSON file, except for built-in-modules, built-ins and plugins defined in babel-preset-env/data.",
"@(!(built-in-modules|built-ins|plugins|package)).json", "@(!(built-in-modules|built-ins|plugins|package)).json"
"# Until the ESLint packages version are aligned with Babel's, we ignore them",
"eslint/**"
] ]
} }
}, },
"packages": [ "packages": [
"codemods/*", "codemods/*",
"eslint/*",
"packages/*" "packages/*"
], ],
"npmClient": "yarn", "npmClient": "yarn",
"npmClientArgs": [ "npmClientArgs": [
"--no-lockfile" "--no-lockfile"
] ],
"publishConfig": {
"registry": "https://npm.cerxes.net"
}
} }

View File

@ -4,7 +4,6 @@
declare module "resolve" { declare module "resolve" {
declare export default { declare export default {
(string, {| basedir: string |}, (err: ?Error, res: string) => void): void;
sync: (string, {| basedir: string |}) => string; sync: (string, {| basedir: string |}) => string;
}; };
} }
@ -179,7 +178,7 @@ declare module "convert-source-map" {
SourceMap: SourceMap, SourceMap: SourceMap,
Converter: Converter, Converter: Converter,
fromObject(obj: SourceMap | SourceMapGenerator): Converter, fromObject(obj: SourceMap | SourceMapGenerator): Converter,
fromJSON(str: string | Buffer): Converter, fromJSON(str: string): Converter,
fromBase64(str: string): Converter, fromBase64(str: string): Converter,
fromComment(str: string): Converter, fromComment(str: string): Converter,
fromMapFileComment(str: string, dir: string): Converter, fromMapFileComment(str: string, dir: string): Converter,
@ -191,6 +190,12 @@ declare module "convert-source-map" {
}; };
} }
declare module "js-levenshtein" {
declare module.exports: {
(string, string): number,
};
}
declare module "core-js-compat/data" { declare module "core-js-compat/data" {
declare type Target = "node" | "chrome" | "opera" | "edge" | "firefox" | "safari" | "ie" | "ios" | "android" | "electron" | "samsung"; declare type Target = "node" | "chrome" | "opera" | "edge" | "firefox" | "safari" | "ie" | "ios" | "android" | "electron" | "samsung";

View File

@ -3,44 +3,39 @@
"private": true, "private": true,
"license": "MIT", "license": "MIT",
"scripts": { "scripts": {
"bootstrap": "make bootstrap",
"build": "make build", "build": "make build",
"fix": "make fix", "fix": "make fix",
"lint": "make lint", "lint": "make lint",
"test": "make test" "test": "make test"
}, },
"devDependencies": { "devDependencies": {
"@babel/cli": "^7.7.0", "@babel/cli": "^7.6.0",
"@babel/core": "^7.7.2", "@babel/core": "^7.6.0",
"@babel/eslint-plugin-development": "^1.0.1", "@babel/eslint-plugin-development": "^1.0.1",
"@babel/plugin-proposal-class-properties": "^7.7.0", "@babel/plugin-proposal-class-properties": "^7.5.5",
"@babel/plugin-proposal-export-namespace-from": "^7.5.2", "@babel/plugin-proposal-export-namespace-from": "^7.5.2",
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.4.4", "@babel/plugin-proposal-nullish-coalescing-operator": "^7.4.4",
"@babel/plugin-proposal-numeric-separator": "^7.2.0", "@babel/plugin-proposal-numeric-separator": "^7.2.0",
"@babel/plugin-proposal-object-rest-spread": "^7.7.4",
"@babel/plugin-proposal-optional-chaining": "^7.6.0", "@babel/plugin-proposal-optional-chaining": "^7.6.0",
"@babel/plugin-transform-flow-strip-types": "^7.7.4", "@babel/plugin-transform-modules-commonjs": "^7.6.0",
"@babel/plugin-transform-for-of": "^7.7.4", "@babel/plugin-transform-runtime": "^7.6.0",
"@babel/plugin-transform-modules-commonjs": "^7.7.0", "@babel/preset-env": "^7.6.0",
"@babel/plugin-transform-runtime": "^7.6.2",
"@babel/preset-env": "^7.7.1",
"@babel/preset-flow": "^7.0.0", "@babel/preset-flow": "^7.0.0",
"@babel/register": "^7.7.0", "@babel/register": "^7.6.0",
"@babel/runtime": "^7.7.2", "@babel/runtime": "^7.6.0",
"@rollup/plugin-alias": "^2.2.0", "babel-eslint": "^11.0.0-beta.0",
"@rollup/plugin-json": "^4.0.0",
"babel-eslint": "^11.0.0-beta.2",
"babel-jest": "^24.9.0", "babel-jest": "^24.9.0",
"babel-loader": "^8.0.6",
"babel-plugin-transform-charcodes": "^0.2.0", "babel-plugin-transform-charcodes": "^0.2.0",
"browserify": "^16.2.3", "browserify": "^16.2.3",
"bundle-collapser": "^1.2.1", "bundle-collapser": "^1.2.1",
"chalk": "^2.4.2", "chalk": "^2.4.2",
"charcodes": "^0.2.0", "charcodes": "^0.2.0",
"derequire": "^2.0.2", "derequire": "^2.0.2",
"duplicate-package-checker-webpack-plugin": "^2.1.0",
"enhanced-resolve": "^3.0.0", "enhanced-resolve": "^3.0.0",
"eslint": "^6.0.1", "eslint": "^6.0.1",
"eslint-config-babel": "^9.0.0", "eslint-config-babel": "^9.0.0",
"eslint-import-resolver-node": "^0.3.2",
"eslint-plugin-flowtype": "^3.8.2", "eslint-plugin-flowtype": "^3.8.2",
"eslint-plugin-import": "^2.17.2", "eslint-plugin-import": "^2.17.2",
"eslint-plugin-prettier": "^3.1.0", "eslint-plugin-prettier": "^3.1.0",
@ -53,32 +48,32 @@
"gulp-newer": "^1.0.0", "gulp-newer": "^1.0.0",
"gulp-plumber": "^1.2.1", "gulp-plumber": "^1.2.1",
"gulp-rename": "^1.4.0", "gulp-rename": "^1.4.0",
"gulp-uglify": "^3.0.2",
"gulp-watch": "^5.0.1", "gulp-watch": "^5.0.1",
"husky": "^3.0.0", "husky": "^3.0.0",
"jest": "^24.9.0", "jest": "^24.9.0",
"lerna": "^3.19.0", "lerna": "^3.16.0",
"lerna-changelog": "^0.5.0", "lerna-changelog": "^0.5.0",
"lint-staged": "^9.2.0", "lint-staged": "^9.2.0",
"lodash": "^4.17.13", "lodash": "^4.17.13",
"mergeiterator": "^1.2.5",
"output-file-sync": "^2.0.0", "output-file-sync": "^2.0.0",
"prettier": "^1.19.1", "prettier": "^1.17.1",
"pump": "^3.0.0", "pump": "^3.0.0",
"rimraf": "^2.6.3", "rimraf": "^2.6.3",
"rollup": "^1.27.5", "rollup": "^1.12.0",
"rollup-plugin-babel": "^4.0.0", "rollup-plugin-babel": "^4.0.0",
"rollup-plugin-commonjs": "^10.1.0",
"rollup-plugin-node-builtins": "^2.1.2",
"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-node-resolve": "^5.0.0", "rollup-plugin-node-resolve": "^5.0.0",
"rollup-plugin-replace": "^2.2.0", "rollup-plugin-replace": "^2.2.0",
"rollup-plugin-terser": "^5.1.2",
"test262-stream": "^1.3.0", "test262-stream": "^1.3.0",
"through2": "^2.0.0", "through2": "^2.0.0",
"typescript": "^3.6.3" "typescript": "^3.6.3",
"warnings-to-errors-webpack-plugin": "^2.0.0",
"webpack": "^3.4.1",
"webpack-dependency-suite": "^2.4.4",
"webpack-stream": "^4.0.0"
}, },
"resolutions": { "resolutions": {
"@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates" "@lerna/**/@lerna/collect-updates": "https://github.com/babel/lerna.git#babel-collect-updates"
}, },
"engines": { "engines": {
"node": ">= 6.9.0 < 14.0.0", "node": ">= 6.9.0 < 14.0.0",
@ -94,5 +89,53 @@
"hooks": { "hooks": {
"pre-commit": "lint-staged" "pre-commit": "lint-staged"
} }
},
"jest": {
"collectCoverageFrom": [
"packages/*/src/**/*.mjs",
"packages/*/src/**/*.js",
"codemods/*/src/**/*.mjs",
"codemods/*/src/**/*.js"
],
"testRegex": "./(packages|codemods)/[^/]+/test/.+\\.m?js$",
"testPathIgnorePatterns": [
"/node_modules/",
"/test/fixtures/",
"/test/debug-fixtures/",
"/babel-parser/test/expressions/",
"/test/tmp/",
"/test/__data__/",
"/test/helpers/",
"<rootDir>/test/warning\\.js",
"<rootDir>/build/",
"_browser\\.js"
],
"testEnvironment": "node",
"setupFilesAfterEnv": [
"<rootDir>/test/testSetupFile.js"
],
"transformIgnorePatterns": [
"/node_modules/",
"/packages/babel-standalone/babel.js",
"<rootDir>/packages/babel-standalone/babel(\\.min)?\\.js",
"<rootDir>/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
"/test/(fixtures|tmp|__data__)/",
"<rootDir>/(packages|codemods)/[^/]+/lib/"
],
"coveragePathIgnorePatterns": [
"/node_modules/",
"<rootDir>/packages/babel-standalone/babel(\\.min)?\\.js",
"<rootDir>/packages/babel-preset-env-standalone/babel-preset-env(\\.min)?\\.js",
"/test/(fixtures|tmp|__data__)/"
],
"modulePathIgnorePatterns": [
"/test/fixtures/",
"/test/tmp/",
"/test/__data__/",
"<rootDir>/build/"
],
"moduleNameMapper": {
"^@babel/([a-zA-Z0-9_-]+)$": "<rootDir>/packages/babel-$1/"
}
} }
} }

View File

@ -1,6 +1,6 @@
{ {
"name": "@babel/cli", "name": "@babel/cli",
"version": "7.8.3-csx.2", "version": "7.7.0",
"description": "Babel command line.", "description": "Babel command line.",
"author": "Sebastian McKenzie <sebmck@gmail.com>", "author": "Sebastian McKenzie <sebmck@gmail.com>",
"homepage": "https://babeljs.io/", "homepage": "https://babeljs.io/",
@ -19,7 +19,7 @@
"compiler" "compiler"
], ],
"dependencies": { "dependencies": {
"commander": "^4.0.1", "commander": "^2.8.1",
"convert-source-map": "^1.1.0", "convert-source-map": "^1.1.0",
"fs-readdir-recursive": "^1.1.0", "fs-readdir-recursive": "^1.1.0",
"glob": "^7.0.0", "glob": "^7.0.0",
@ -35,9 +35,8 @@
"@babel/core": "^7.0.0-0 || csx" "@babel/core": "^7.0.0-0 || csx"
}, },
"devDependencies": { "devDependencies": {
"@babel/core": "7.8.3-csx.2", "@babel/core": "^7.7.0",
"@babel/helper-fixtures": "7.8.3-csx.2", "@babel/helper-fixtures": "^7.6.3"
"rimraf": "^3.0.0"
}, },
"bin": { "bin": {
"babel": "./bin/babel.js", "babel": "./bin/babel.js",

View File

@ -9,13 +9,6 @@ import fs from "fs";
import * as util from "./util"; import * as util from "./util";
import { type CmdOptions } from "./options"; import { type CmdOptions } from "./options";
const FILE_TYPE = Object.freeze({
NON_COMPILABLE: "NON_COMPILABLE",
COMPILED: "COMPILED",
IGNORED: "IGNORED",
ERR_COMPILATION: "ERR_COMPILATION",
});
function outputFileSync(filePath: string, data: string | Buffer): void { function outputFileSync(filePath: string, data: string | Buffer): void {
makeDirSync(path.dirname(filePath)); makeDirSync(path.dirname(filePath));
fs.writeFileSync(filePath, data); fs.writeFileSync(filePath, data);
@ -27,22 +20,15 @@ export default async function({
}: CmdOptions): Promise<void> { }: CmdOptions): Promise<void> {
const filenames = cliOptions.filenames; const filenames = cliOptions.filenames;
async function write( async function write(src: string, base: string): Promise<boolean> {
src: string,
base: string,
): Promise<$Keys<typeof FILE_TYPE>> {
let relative = path.relative(base, src); let relative = path.relative(base, src);
if (!util.isCompilableExtension(relative, cliOptions.extensions)) { if (!util.isCompilableExtension(relative, cliOptions.extensions)) {
return FILE_TYPE.NON_COMPILABLE; return false;
} }
relative = util.withExtension( // remove extension and then append back on .js
relative, relative = util.adjustRelative(relative, cliOptions.keepFileExtension);
cliOptions.keepFileExtension
? path.extname(relative)
: cliOptions.outFileExtension,
);
const dest = getDest(relative, base); const dest = getDest(relative, base);
@ -57,7 +43,7 @@ export default async function({
), ),
); );
if (!res) return FILE_TYPE.IGNORED; if (!res) return false;
// we've requested explicit sourcemaps to be written to disk // we've requested explicit sourcemaps to be written to disk
if ( if (
@ -78,11 +64,11 @@ export default async function({
console.log(src + " -> " + dest); console.log(src + " -> " + dest);
} }
return FILE_TYPE.COMPILED; return true;
} catch (err) { } catch (err) {
if (cliOptions.watch) { if (cliOptions.watch) {
console.error(err); console.error(err);
return FILE_TYPE.ERR_COMPILATION; return false;
} }
throw err; throw err;
@ -99,16 +85,13 @@ export default async function({
async function handleFile(src: string, base: string): Promise<boolean> { async function handleFile(src: string, base: string): Promise<boolean> {
const written = await write(src, base); const written = await write(src, base);
if ( if (!written && cliOptions.copyFiles) {
(cliOptions.copyFiles && written === FILE_TYPE.NON_COMPILABLE) ||
(cliOptions.copyIgnored && written === FILE_TYPE.IGNORED)
) {
const filename = path.relative(base, src); const filename = path.relative(base, src);
const dest = getDest(filename, base); const dest = getDest(filename, base);
outputFileSync(dest, fs.readFileSync(src)); outputFileSync(dest, fs.readFileSync(src));
util.chmod(src, dest); util.chmod(src, dest);
} }
return written === FILE_TYPE.COMPILED; return written;
} }
async function handle(filenameOrDir: string): Promise<number> { async function handle(filenameOrDir: string): Promise<number> {
@ -162,7 +145,7 @@ export default async function({
if (cliOptions.watch) { if (cliOptions.watch) {
const chokidar = util.requireChokidar(); const chokidar = util.requireChokidar();
filenames.forEach(function(filenameOrDir: string): void { filenames.forEach(function(filenameOrDir) {
const watcher = chokidar.watch(filenameOrDir, { const watcher = chokidar.watch(filenameOrDir, {
persistent: true, persistent: true,
ignoreInitial: true, ignoreInitial: true,
@ -172,8 +155,8 @@ export default async function({
}, },
}); });
["add", "change"].forEach(function(type: string): void { ["add", "change"].forEach(function(type) {
watcher.on(type, function(filename: string): void { watcher.on(type, function(filename) {
handleFile( handleFile(
filename, filename,
filename === filenameOrDir filename === filenameOrDir

View File

@ -216,7 +216,6 @@ export default async function({
const chokidar = util.requireChokidar(); const chokidar = util.requireChokidar();
chokidar chokidar
.watch(filenames, { .watch(filenames, {
disableGlobbing: true,
persistent: true, persistent: true,
ignoreInitial: true, ignoreInitial: true,
awaitWriteFinish: { awaitWriteFinish: {
@ -224,11 +223,8 @@ export default async function({
pollInterval: 10, pollInterval: 10,
}, },
}) })
.on("all", function(type: string, filename: string): void { .on("all", function(type: string, filename: string) {
if ( if (!util.isCompilableExtension(filename, cliOptions.extensions)) {
!util.isCompilableExtension(filename, cliOptions.extensions) &&
!filenames.includes(filename)
) {
return; return;
} }

View File

@ -74,8 +74,8 @@ commander.option(
booleanify, booleanify,
); );
commander.option( commander.option(
"--minified", "--minified [true|false]",
"Save as many bytes when printing. (false by default)", "Save as many bytes when printing.",
); );
commander.option( commander.option(
"--auxiliary-comment-before [string]", "--auxiliary-comment-before [string]",
@ -160,22 +160,9 @@ commander.option(
"--delete-dir-on-start", "--delete-dir-on-start",
"Delete the out directory before compilation.", "Delete the out directory before compilation.",
); );
commander.option(
"--out-file-extension [string]",
"Use a specific extension for the output files",
);
commander.option(
"--copy-ignored",
"Include ignored files when copying non-compilable files.",
);
commander.version(pkg.version + " (@babel/core " + version + ")"); commander.version(pkg.version + " (@babel/core " + version + ")");
commander.usage("[options] <files ...>"); commander.usage("[options] <files ...>");
// register an empty action handler so that commander.js can throw on
// unknown options _after_ args
// see https://github.com/tj/commander.js/issues/561#issuecomment-522209408
commander.action(() => {});
export type CmdOptions = { export type CmdOptions = {
babelOptions: Object, babelOptions: Object,
@ -246,12 +233,6 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
); );
} }
if (commander.keepFileExtension && commander.outFileExtension) {
errors.push(
"--out-file-extension cannot be used with --keep-file-extension",
);
}
if (errors.length) { if (errors.length) {
console.error("babel:"); console.error("babel:");
errors.forEach(function(e) { errors.forEach(function(e) {
@ -308,7 +289,6 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
filenames, filenames,
extensions: opts.extensions, extensions: opts.extensions,
keepFileExtension: opts.keepFileExtension, keepFileExtension: opts.keepFileExtension,
outFileExtension: opts.outFileExtension,
watch: opts.watch, watch: opts.watch,
skipInitialBuild: opts.skipInitialBuild, skipInitialBuild: opts.skipInitialBuild,
outFile: opts.outFile, outFile: opts.outFile,
@ -320,7 +300,6 @@ export default function parseArgv(args: Array<string>): CmdOptions | null {
quiet: opts.quiet, quiet: opts.quiet,
deleteDirOnStart: opts.deleteDirOnStart, deleteDirOnStart: opts.deleteDirOnStart,
sourceMapTarget: opts.sourceMapTarget, sourceMapTarget: opts.sourceMapTarget,
copyIgnored: opts.copyIgnored,
}, },
}; };
} }
@ -337,10 +316,7 @@ function booleanify(val: any): boolean | any {
return val; return val;
} }
function collect( function collect(value, previousValue): Array<string> {
value: string | any,
previousValue: Array<string>,
): Array<string> {
// If the user passed the option with no value, like "babel file.js --presets", do nothing. // If the user passed the option with no value, like "babel file.js --presets", do nothing.
if (typeof value !== "string") return previousValue; if (typeof value !== "string") return previousValue;

View File

@ -127,7 +127,12 @@ export function requireChokidar(): Object {
} }
} }
export function withExtension(filename: string, ext: string = ".js") { export function adjustRelative(
const newBasename = path.basename(filename, path.extname(filename)) + ext; relative: string,
return path.join(path.dirname(filename), newBasename); keepFileExtension: boolean,
): string {
if (keepFileExtension) {
return relative;
}
return relative.replace(/\.(\w*?)$/, "") + ".js";
} }

Some files were not shown because too many files have changed in this diff Show More