cerxes/csx
3
1
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removed some Todo's that were no longer a TODO

Browse Source
This commit is contained in:
Miel Truyen 2019-11-08 20:04:23 +01:00
parent 3b0dce6fbe
commit 51f894c616
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/csx-custom-elements/src/vdom/render.js
View File

@ -6,8 +6,6 @@ import {
NodeTreeRenderer NodeTreeRenderer
} from "./renderers"; } from "./renderers";
// TODO consider using existence of renderer.remove to identify whether a VNode is ChildNode or not
// TODO Rework all below so we can determine per type how to handle it (not all represent a childNode of the host etc...)
// TODO Element renderer (for things that are already DOM-elements) // TODO Element renderer (for things that are already DOM-elements)
export function getNodeMeta(vnode){ export function getNodeMeta(vnode){
if(vnode===undefined||vnode===null) return undefined; // Indicate it shouldn't render if(vnode===undefined||vnode===null) return undefined; // Indicate it shouldn't render
@ -49,7 +47,6 @@ export function getNodeMeta(vnode){
export function render(vnode, opts = {}) { export function render(vnode, opts = {}) {
// TODO innerHTML, innerText and other tags/props that are trickyer then just mapping value to attribute (see NodeTreeRenderer) // TODO innerHTML, innerText and other tags/props that are trickyer then just mapping value to attribute (see NodeTreeRenderer)
// TODO ref-prop (should it only return once all child els are created and appended to the child?!) // TODO ref-prop (should it only return once all child els are created and appended to the child?!)
// TODO Proper updating of a previous rendered vnode (we're working on it!)
/** /**
* *
@ -182,7 +179,7 @@ export function render(vnode, opts = {}) {
else else
item.host.removeChild(oldChild.element); item.host.removeChild(oldChild.element);
} }
queuedItems.push(child);// TODO where should the new child be inserted... queuedItems.push(child);
} }
previous = child.item; previous = child.item;
} }