Improved update performance of mountain_peak layer (#1508)

Improved update performance of mountain_peak layer
- Refactored IDs to be unique in mountain_linestring.osm_ids and mountain_peak_point.osm_ids
- Restricted updates to INSERT and UPDATE operations during mountain_linestring.refresh and mountain_peak_point.refresh
- Added analyze statements before update queries during mountain_linestring.refresh and mountain_peak_point.refresh
This commit is contained in:
benedikt-brandtner-bikemap 2023-03-22 12:13:05 +01:00 committed by GitHub
parent d97d86320b
commit 1126e30d0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 16 deletions

View File

@ -6,7 +6,7 @@ CREATE SCHEMA IF NOT EXISTS mountain_linestring;
CREATE TABLE IF NOT EXISTS mountain_linestring.osm_ids CREATE TABLE IF NOT EXISTS mountain_linestring.osm_ids
( (
osm_id bigint osm_id bigint PRIMARY KEY
); );
-- etldoc: osm_mountain_linestring -> osm_mountain_linestring -- etldoc: osm_mountain_linestring -> osm_mountain_linestring
@ -26,11 +26,7 @@ SELECT update_osm_mountain_linestring(true);
CREATE OR REPLACE FUNCTION mountain_linestring.store() RETURNS trigger AS CREATE OR REPLACE FUNCTION mountain_linestring.store() RETURNS trigger AS
$$ $$
BEGIN BEGIN
IF (tg_op = 'DELETE') THEN INSERT INTO mountain_linestring.osm_ids VALUES (NEW.osm_id) ON CONFLICT (osm_id) DO NOTHING;
INSERT INTO mountain_linestring.osm_ids VALUES (OLD.osm_id);
ELSE
INSERT INTO mountain_linestring.osm_ids VALUES (NEW.osm_id);
END IF;
RETURN NULL; RETURN NULL;
END; END;
$$ LANGUAGE plpgsql; $$ LANGUAGE plpgsql;
@ -55,6 +51,11 @@ DECLARE
t TIMESTAMP WITH TIME ZONE := clock_timestamp(); t TIMESTAMP WITH TIME ZONE := clock_timestamp();
BEGIN BEGIN
RAISE LOG 'Refresh mountain_linestring'; RAISE LOG 'Refresh mountain_linestring';
-- Analyze tracking and source tables before performing update
ANALYZE mountain_linestring.osm_ids;
ANALYZE osm_mountain_linestring;
PERFORM update_osm_mountain_linestring(false); PERFORM update_osm_mountain_linestring(false);
-- noinspection SqlWithoutWhere -- noinspection SqlWithoutWhere
DELETE FROM mountain_linestring.osm_ids; DELETE FROM mountain_linestring.osm_ids;
@ -67,13 +68,13 @@ END;
$$ LANGUAGE plpgsql; $$ LANGUAGE plpgsql;
CREATE TRIGGER trigger_store CREATE TRIGGER trigger_store
AFTER INSERT OR UPDATE OR DELETE AFTER INSERT OR UPDATE
ON osm_mountain_linestring ON osm_mountain_linestring
FOR EACH ROW FOR EACH ROW
EXECUTE PROCEDURE mountain_linestring.store(); EXECUTE PROCEDURE mountain_linestring.store();
CREATE TRIGGER trigger_flag CREATE TRIGGER trigger_flag
AFTER INSERT OR UPDATE OR DELETE AFTER INSERT OR UPDATE
ON osm_mountain_linestring ON osm_mountain_linestring
FOR EACH STATEMENT FOR EACH STATEMENT
EXECUTE PROCEDURE mountain_linestring.flag(); EXECUTE PROCEDURE mountain_linestring.flag();

View File

@ -6,7 +6,7 @@ CREATE SCHEMA IF NOT EXISTS mountain_peak_point;
CREATE TABLE IF NOT EXISTS mountain_peak_point.osm_ids CREATE TABLE IF NOT EXISTS mountain_peak_point.osm_ids
( (
osm_id bigint osm_id bigint PRIMARY KEY
); );
-- etldoc: osm_peak_point -> osm_peak_point -- etldoc: osm_peak_point -> osm_peak_point
@ -26,11 +26,7 @@ SELECT update_osm_peak_point(true);
CREATE OR REPLACE FUNCTION mountain_peak_point.store() RETURNS trigger AS CREATE OR REPLACE FUNCTION mountain_peak_point.store() RETURNS trigger AS
$$ $$
BEGIN BEGIN
IF (tg_op = 'DELETE') THEN INSERT INTO mountain_peak_point.osm_ids VALUES (NEW.osm_id) ON CONFLICT (osm_id) DO NOTHING;
INSERT INTO mountain_peak_point.osm_ids VALUES (OLD.osm_id);
ELSE
INSERT INTO mountain_peak_point.osm_ids VALUES (NEW.osm_id);
END IF;
RETURN NULL; RETURN NULL;
END; END;
$$ LANGUAGE plpgsql; $$ LANGUAGE plpgsql;
@ -55,6 +51,11 @@ DECLARE
t TIMESTAMP WITH TIME ZONE := clock_timestamp(); t TIMESTAMP WITH TIME ZONE := clock_timestamp();
BEGIN BEGIN
RAISE LOG 'Refresh mountain_peak_point'; RAISE LOG 'Refresh mountain_peak_point';
-- Analyze tracking and source tables before performing update
ANALYZE mountain_peak_point.osm_ids;
ANALYZE osm_peak_point;
PERFORM update_osm_peak_point(false); PERFORM update_osm_peak_point(false);
-- noinspection SqlWithoutWhere -- noinspection SqlWithoutWhere
DELETE FROM mountain_peak_point.osm_ids; DELETE FROM mountain_peak_point.osm_ids;
@ -67,13 +68,13 @@ END;
$$ LANGUAGE plpgsql; $$ LANGUAGE plpgsql;
CREATE TRIGGER trigger_store CREATE TRIGGER trigger_store
AFTER INSERT OR UPDATE OR DELETE AFTER INSERT OR UPDATE
ON osm_peak_point ON osm_peak_point
FOR EACH ROW FOR EACH ROW
EXECUTE PROCEDURE mountain_peak_point.store(); EXECUTE PROCEDURE mountain_peak_point.store();
CREATE TRIGGER trigger_flag CREATE TRIGGER trigger_flag
AFTER INSERT OR UPDATE OR DELETE AFTER INSERT OR UPDATE
ON osm_peak_point ON osm_peak_point
FOR EACH STATEMENT FOR EACH STATEMENT
EXECUTE PROCEDURE mountain_peak_point.flag(); EXECUTE PROCEDURE mountain_peak_point.flag();